John Haubrich <spacecowboy4@gmail.com>: Author Summary
| Build | Completed | Code commits | Tests |
|---|---|---|---|
| SMACK › NIGHTLY › #1697 | 3 months ago | 735 passed | |
| SMACK › CIMASTER › #659 | 3 months ago |
gradle: Ensure git command is run projectDir rather than CWD.
The assert on line 659 was causing my build to fail. Two issues caused gitCommit to be empty. 1. The cmd 'git describe --always --tags --dirty=+' was not given enough time to complete and had not exited which meant no text in proc.text 2. The two git commands on lines 653 and 658 were run from the CWD of my Eclipse IDE, not the $projectDir which caused git to return an error 128. To solve the two issues I added a waitForOrKill method call to proc (like the srCmd had) and I set the execute to run in $projectDir which I think was the intent/assumption in the original code. Also add waitFor on git describe command. |
735 passed |
| Build | Completed | Code commits | Tests |
|---|
| Build | Completed | Code commits | Tests |
|---|
The assert on line 659 was causing my build to fail. Two issues caused
gitCommit to be empty.
1. The cmd 'git describe --always --tags --dirty=+' was not given
enough time to complete and had not exited which meant no text in
proc.text
2. The two git commands on lines 653 and 658 were run from the
CWD of my Eclipse IDE, not the $projectDir which caused git to return
an error 128.
To solve the two issues I added a waitForOrKill method call to
proc (like the srCmd had) and I set the execute to run in $projectDir
which I think was the intent/assumption in the original code.
Also add waitFor on git describe command.