Build: #10 was successful Manual run by Guus der Kinderen
Code commits
Openfire (master)
-
akrherz <akrherz@iastate.edu> 41041642078a1e498c4f8b6e6a5b226409b5dbcd
Denote Openfire 4.6.0 Beta Release
- distribution/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- i18n/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- plugins/openfire-plugin-assembly-descriptor/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- plugins/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- starter/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- xmppserver/changelog.html (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- xmppserver/pom.xml (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/XMPPServerInfoImpl.java (version 41041642078a1e498c4f8b6e6a5b226409b5dbcd)
-
daryl herzmann <akrherz@iastate.edu> b8e7df59068b85070c25103bddf3b9ae759094b7
Merge pull request #1640 from guusdk/fmuc
OF-2030: Add support for FMUC -
Guus der Kinderen 8377c627e0d07590b6b0b51eb3de975bb4301887
OF-2030: Work around self-presence race-condition
A race condition can occur where 'occupantsByFullJID' does not yet (or no longer, in case of a 'leave') contain
the originator of the presence stanza. To work around this, the "self-presence" is sent after all other occupants
have been processed.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/cluster/BroadcastPresenceRequest.java (version 8377c627e0d07590b6b0b51eb3de975bb4301887)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 8377c627e0d07590b6b0b51eb3de975bb4301887)
-
Guus der Kinderen 3e701ce4bc204321dcd9f9f3f3a7988f2fd875a6
OF-2030: Send 'leave' presence before removing occupant from room, to allow leave presence to be echo'd back to the occupant that's leaving.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 3e701ce4bc204321dcd9f9f3f3a7988f2fd875a6)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 3e701ce4bc204321dcd9f9f3f3a7988f2fd875a6)
-
lishan89 <56140323+lishan89@users.noreply.github.com> d7281eb6867e76010cf8f3ea4624783a5516cf31
Fix an issue in Fixtures.java and add some Unit Tests for UserManager (#1650)
Co-authored-by: Tao Sun <tsun@marketo.com>- xmppserver/src/test/java/org/jivesoftware/Fixtures.java (version d7281eb6867e76010cf8f3ea4624783a5516cf31)
- xmppserver/src/test/java/org/jivesoftware/openfire/user/UserManagerTest.java (version d7281eb6867e76010cf8f3ea4624783a5516cf31)
-
Guus der Kinderen 146c5027a4cba80317f9e2884d57f0c04c416dc0
OF-2030: (FMUC) Basic support for stopping and starting FMUC independent directly (eg: not depending on user presence)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 146c5027a4cba80317f9e2884d57f0c04c416dc0)
-
Guus der Kinderen 4cbb5a59703845b5c5732d1eecbf49c50d9cbb06
OF-2030: Fix javadoc
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 4cbb5a59703845b5c5732d1eecbf49c50d9cbb06)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 4cbb5a59703845b5c5732d1eecbf49c50d9cbb06)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 4cbb5a59703845b5c5732d1eecbf49c50d9cbb06)
-
Guus der Kinderen 8304c94b0960e28017dc38fe9db1521b984fd40e
OF-2030: (FMUC) Remove occupant only after the leave stanzas have been processed.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 8304c94b0960e28017dc38fe9db1521b984fd40e)
-
Guus der Kinderen 8776829815c7989623790841873d8df682bc7047
OF-2030: (FMUC) queue stanzas to be shared with FMUC while federation is in process of being set up.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 8776829815c7989623790841873d8df682bc7047)
-
Guus der Kinderen 9b54bbca0093d1d94c27bf9432813516b079e0ad
OF-2030: (FMUC) Improve scenario where occupants are leaving.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 9b54bbca0093d1d94c27bf9432813516b079e0ad)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 9b54bbca0093d1d94c27bf9432813516b079e0ad)
-
Guus der Kinderen 4034831358c2a2cf6a15dede0ed79b8821de705e
OF-2030: Show pending FMUC federation on admin console.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 4034831358c2a2cf6a15dede0ed79b8821de705e)
- xmppserver/src/main/webapp/muc-room-federation.jsp (version 4034831358c2a2cf6a15dede0ed79b8821de705e)
-
Guus der Kinderen 18ad82c0eef3e0f86308f81685d2285f397751cb
OF-2030: Stop processing a join stanza after the stanza has been deemed invalid
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 18ad82c0eef3e0f86308f81685d2285f397751cb)
-
Guus der Kinderen fd08b031011caedddad0c37be2b742f8b2fb4692
OF-2030: Do not process FMUC if FMUC is disabled.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version fd08b031011caedddad0c37be2b742f8b2fb4692)
-
Guus der Kinderen 62d39c93f6d44baba291b7bf1bddcfa922295933
OF-2030: Allow FMUC sessions to be terminated from the admin console.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 62d39c93f6d44baba291b7bf1bddcfa922295933)
- xmppserver/src/main/webapp/muc-room-federation.jsp (version 62d39c93f6d44baba291b7bf1bddcfa922295933)
-
Guus der Kinderen 358e864c11cbcb889a2c4be4ddb2e22d5ec8c41e
OF-2030: Disable FMUC by default
Use a normal property instead of a muc service property. A normal property can easily be modified in the admin console.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 358e864c11cbcb889a2c4be4ddb2e22d5ec8c41e)
-
Guus der Kinderen 41510d2bec2c38fe9e0ce2a48518b6695b6fcfac
OF-2030: (FMUC) Enhance admin console
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 41510d2bec2c38fe9e0ce2a48518b6695b6fcfac)
- xmppserver/src/main/webapp/muc-room-federation.jsp (version 41510d2bec2c38fe9e0ce2a48518b6695b6fcfac)
-
Guus der Kinderen 9e4c08d25e58f3a411afc553cee00056a471af65
OF-2030: (FMUC) Make outbound joins configurable
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 9e4c08d25e58f3a411afc553cee00056a471af65)
- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 9e4c08d25e58f3a411afc553cee00056a471af65)
-
Guus der Kinderen 8ceed8670cdc0b640f421c9dfeb3a72eb1bf2f9f
OF-2030: (FMUC) reject federation request from a node we're configured to federate with.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 8ceed8670cdc0b640f421c9dfeb3a72eb1bf2f9f)
-
Guus der Kinderen 3ae7eb9012f9895be16a324e70481a9ea743dbab
OF-2030: (FMUC) fix addressing of stanzas arriving from other nodes.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 3ae7eb9012f9895be16a324e70481a9ea743dbab)
-
Guus der Kinderen 69ec27ee646d5027a42ecf6b89150b756af7e0d9
OF-2030: (FMUC) Fix detection of 'delay' element.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 69ec27ee646d5027a42ecf6b89150b756af7e0d9)
-
Guus der Kinderen 4d03dd5c89665e1b166eb2e88408fb51071575d5
OF-2030: Remove from config the verbose log level used during develoment.
- distribution/src/resources/log4j2.xml (version 4d03dd5c89665e1b166eb2e88408fb51071575d5)
-
Guus der Kinderen 9d0e397a055038108a0c9ede799e6b660ee389ef
OF-2030: (FMUC) introduce new admin panel page
- i18n/src/main/resources/openfire_i18n.properties (version 9d0e397a055038108a0c9ede799e6b660ee389ef)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 9d0e397a055038108a0c9ede799e6b660ee389ef)
- xmppserver/src/main/resources/admin-sidebar.xml (version 9d0e397a055038108a0c9ede799e6b660ee389ef)
- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 9d0e397a055038108a0c9ede799e6b660ee389ef)
- xmppserver/src/main/webapp/muc-room-federation.jsp (version 9d0e397a055038108a0c9ede799e6b660ee389ef)
-
Guus der Kinderen e4e1aac100f8f8000cbf3180d39c92a5978ed784
OF-2030: Always show federated FMUC nodes, even if they have no occupants.
- xmppserver/src/main/webapp/muc-room-federation.jsp (version e4e1aac100f8f8000cbf3180d39c92a5978ed784)
-
Guus der Kinderen bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62
OF-2030: (FMUC) Two-way join direction, separation of concerns
Adding support for both inbound as well as outbound joins.
Separating concerns for FMUC handling from regular FMUC implementation.
Added implementation of processing of most (but not all) stanzas that are exchanged through FMUC.
This commit is the result of a few weeks of work and should probably have been split up in multiple distinct commits.- distribution/src/resources/log4j2.xml (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCMode.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQAdminHandler.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQMUCRegisterHandler.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQOwnerHandler.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRole.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/RemoteMUCRole.java (version bac3f2f08fc7e52eb1e5cb5f172edc3aea203a62)
-
Guus der Kinderen a25c929537254ec270576c28ba1c1c95493447b9
OF-2030: Make FMUC enabling/disabling a system property, dynamic, and its status displayed on the admin console page.
- i18n/src/main/resources/openfire_i18n.properties (version a25c929537254ec270576c28ba1c1c95493447b9)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version a25c929537254ec270576c28ba1c1c95493447b9)
- xmppserver/src/main/webapp/muc-room-federation.jsp (version a25c929537254ec270576c28ba1c1c95493447b9)
-
Guus der Kinderen 522e93ff00fd57081ffc2ad6ce51e01b044a1c31
OF-2030: (FMUC) send room history after node joins FMUC set.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 522e93ff00fd57081ffc2ad6ce51e01b044a1c31)
-
Guus der Kinderen e6c4a603638832118ed3413388fcef0920f4a93a
OF-2030: (FMUC) subject sync on join, lots of debug logging
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version e6c4a603638832118ed3413388fcef0920f4a93a)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version e6c4a603638832118ed3413388fcef0920f4a93a)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version e6c4a603638832118ed3413388fcef0920f4a93a)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version e6c4a603638832118ed3413388fcef0920f4a93a)
-
Guus der Kinderen 1f8837f92ab81e238d8f84a08edc8c3ca98faa05
OF-2030: Allow FMUC configuration to be changed when join is in progress.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 1f8837f92ab81e238d8f84a08edc8c3ca98faa05)
-
Guus der Kinderen 81e9add493e12278baffa2adce3fc63a79f9b2b3
OF-2030: (FMUC) process inbound join from joining node
This adds processing that processes a presence-stanza based join from a remote, joining FMUC node.
A basic MUC Service property (room.fmucEnabled) is used to reject or allow the FMUC join. Upon rejection, a proper error is returned. Allowing the join currently does not yet invoke any FMUC-specific functionality.
TODO: Make enabling FMUC support configurable per room (it's now a per service setting).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/FMUCException.java (version 81e9add493e12278baffa2adce3fc63a79f9b2b3)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 81e9add493e12278baffa2adce3fc63a79f9b2b3)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 81e9add493e12278baffa2adce3fc63a79f9b2b3)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 81e9add493e12278baffa2adce3fc63a79f9b2b3)
-
Guus der Kinderen 4ed229834513afd7c008261402528bfbad9f48a7
OF-2030: (FMUC) ensure fmuc element in outbound data
When fmuc data is sent from a local room to a joined room on a different domain, an 'fmuc' element including the 'from' address of original sender of the data should be present. This commit adds those.
TODO:
- As the data is parsed late in the stanza flow, the 'form' is deduced based on the nickname of the user that sent the stanza. This makes it impossible to determine what resource sent the data, when the user joined the chatroom with more than one device (using the same nickname). As a compromise, Openfire will use a bare JID (as opposed to a full JID) to populate the 'from' value in the 'fmuc' element. It is yet to be determined if this is an acceptable compromise (but for now, it allows for basic functionality).
- Determine how presence updates from users on joined FMUC nodes should be processed.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version 4ed229834513afd7c008261402528bfbad9f48a7)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/cluster/OccupantAddedEvent.java (version 4ed229834513afd7c008261402528bfbad9f48a7)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRole.java (version 4ed229834513afd7c008261402528bfbad9f48a7)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 4ed229834513afd7c008261402528bfbad9f48a7)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/RemoteMUCRole.java (version 4ed229834513afd7c008261402528bfbad9f48a7)
-
Guus der Kinderen 4db169ca653e91fb0e8febbd1af6d7c2cc4267c8
Refactoring of LocalMUCRoom's 'joinRoom' method
Splitting up the large, complex method 'joinRoom' in LocalMUCRoom to have a better separation of responsibilities and more manageble code.
Added human readible text to most of the errors generated in this class.
Introduced the @Nullable and @Nonnull annotations to aid IDEs with problem detection.
Added lots of debug logging.
This commit should not have introduced significant functional changes.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 4db169ca653e91fb0e8febbd1af6d7c2cc4267c8)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 4db169ca653e91fb0e8febbd1af6d7c2cc4267c8)
-
Guus der Kinderen ce136a55a324559ea65c4d75145a604d5529a8e5
Refactoring of LocalMUCUser
Splitting up the large, complex methods in LocalMUCUser to have a better separation of responsibilities and more manageble code.
Added human readible text to most of the errors generated in this class.
Introduced the @Nullable and @Nonnull annotations to aid IDEs with problem detection.
Added lots of debug logging.
This commit should not have introduced significant functional changes.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version ce136a55a324559ea65c4d75145a604d5529a8e5)
-
Guus der Kinderen 428eac2876121e6dd2e2eb8a282a2b8640208e19
fixed typo in comment
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 428eac2876121e6dd2e2eb8a282a2b8640208e19)
-
Guus der Kinderen 5f0d443aaf3deeb3f2f8f187705027a0caf30fe1
Update continuous-integration-workflow.yml
Make the aioxmpp flow fail if the python process has a non-zero exit code.- .github/workflows/continuous-integration-workflow.yml (version 5f0d443aaf3deeb3f2f8f187705027a0caf30fe1)
-
daryl herzmann <akrherz@iastate.edu> 8501f5708380e54e1aaed353bb9fa24355d78b04
Merge pull request #1648 from guusdk/fix_for_log
A collection of minor improvements -
Guus der Kinderen d458f95fccec7e643ce2be22070504ea24b34e34
Replace manual max and min value calculations with Java's implementation
- starter/src/main/java/org/jivesoftware/openfire/launcher/GraphicUtils.java (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/java/org/dom4j/io/XMPPPacketReader.java (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/component-session-summary.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/muc-room-summary.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/muc-service-summary.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/server-db-stats.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/server-session-summary.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/user-roster.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
- xmppserver/src/main/webapp/user-summary.jsp (version d458f95fccec7e643ce2be22070504ea24b34e34)
-
Guus der Kinderen 7869189852b5f5bd5d42b89ca8294feb239eb4bd
Use uppercase L instead of lowercase l (which is similar to the number 1) when specifying a long literal.
- xmppserver/src/main/java/org/apache/mina/management/MINAStatCollector.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
- xmppserver/src/main/java/org/jivesoftware/database/SequenceManager.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
- xmppserver/src/main/java/org/jivesoftware/openfire/audit/spi/AuditorImpl.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
- xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginCacheRegistry.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
- xmppserver/src/main/java/org/jivesoftware/util/cache/CacheFactory.java (version 7869189852b5f5bd5d42b89ca8294feb239eb4bd)
-
Guus der Kinderen 8fb60d953feee81e86b11258d427e7402b842636
Remove unneeded imports
- xmppserver/src/main/java/org/jivesoftware/database/bugfix/OF1515.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/Connection.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/auth/AuthToken.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/component/InternalComponentManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginIconServlet.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/UserFeaturesProvider.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/group/ConcurrentGroupMap.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQPrivateHandler.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpBindServlet.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpSessionManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/http/SessionEventDispatcher.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStore.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStoreManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/mediaproxy/MediaProxyService.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/HistoryRequest.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketReader.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/TLSWrapper.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/nio/ClientConnectionHandler.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProvider.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/DefaultNodeConfiguration.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/LeafNode.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/NodeAffiliate.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/server/OutgoingSessionPromise.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/SoftwareServerVersionManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/vcard/VCardManager.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketConnection.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/util/CertificateEventListener.java (version 8fb60d953feee81e86b11258d427e7402b842636)
- xmppserver/src/main/java/org/jivesoftware/util/S2STestService.java (version 8fb60d953feee81e86b11258d427e7402b842636)
-
Guus der Kinderen 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d
Do not completely ignore exceptions. At least log them to trace or debug.
- xmppserver/src/main/java/org/apache/mina/management/MINAStatCollector.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/dom4j/io/XMPPPacketReader.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/admin/AdminConsole.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/admin/LdapGroupTester.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationMapping.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationPolicy.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapUserProvider.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketSendingTracker.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubServiceInfo.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/util/BeanUtils.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/util/ParamUtils.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/util/StringUtils.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/util/WebManager.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
- xmppserver/src/main/java/org/jivesoftware/util/XMLWriter.java (version 0bb4e6cd396ea7b38fbc8d8c1b7c2fd5e2fec13d)
-
Guus der Kinderen f5a7995c2feefbe71618e0490f62b378eebe337c
Fixes for javadoc
- xmppserver/src/main/java/org/jivesoftware/openfire/audit/spi/AuditorImpl.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupPropertyMap.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/mediaproxy/Channel.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubEngine.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
- xmppserver/src/main/java/org/jivesoftware/util/BeanUtils.java (version f5a7995c2feefbe71618e0490f62b378eebe337c)
-
Guus der Kinderen 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe
Change Jive's license from GPL -> Apache, as is done with other code
- xmppserver/src/main/java/org/jivesoftware/database/AbstractConnection.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/database/CallableStatementWrapper.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/database/PreparedStatementWrapper.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/database/ProfiledConnection.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/database/ProfiledConnectionEntry.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/database/StatementWrapper.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
- xmppserver/src/main/java/org/jivesoftware/openfire/audit/Auditor.java (version 60392eaa9adefac0bd2b32a7c4f4adf918da3ffe)
-
Guus der Kinderen 67a9f6f50e8727905470c9af971a9becc2305400
Fix logging (incorrect amount of placeholders)
- xmppserver/src/main/java/org/jivesoftware/openfire/server/OutgoingSessionPromise.java (version 67a9f6f50e8727905470c9af971a9becc2305400)
- xmppserver/src/main/java/org/jivesoftware/util/SmsService.java (version 67a9f6f50e8727905470c9af971a9becc2305400)
- xmppserver/src/main/java/org/jivesoftware/util/TaskEngine.java (version 67a9f6f50e8727905470c9af971a9becc2305400)
-
Guus der Kinderen 3722611adf0dcd93acd6f3edf3b6b65607d4b511
Disable SINT tests that occasionaly fail due to OF-2039 & OF-2040
- .github/workflows/continuous-integration-workflow.yml (version 3722611adf0dcd93acd6f3edf3b6b65607d4b511)
- runIntegrationTests (version 3722611adf0dcd93acd6f3edf3b6b65607d4b511)
-
Guus der Kinderen b7f80c2c21bbb9e645205dc2793ef5efa3318754
OF-1837: JDBCProviders - allow JID nodes to be (un)escaped.
- xmppserver/src/main/java/org/jivesoftware/openfire/admin/JDBCAdminProvider.java (version b7f80c2c21bbb9e645205dc2793ef5efa3318754)
- xmppserver/src/main/java/org/jivesoftware/openfire/auth/JDBCAuthProvider.java (version b7f80c2c21bbb9e645205dc2793ef5efa3318754)
- xmppserver/src/main/java/org/jivesoftware/openfire/group/JDBCGroupProvider.java (version b7f80c2c21bbb9e645205dc2793ef5efa3318754)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/JDBCUserProvider.java (version b7f80c2c21bbb9e645205dc2793ef5efa3318754)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/property/JDBCUserPropertyProvider.java (version b7f80c2c21bbb9e645205dc2793ef5efa3318754)
-
Guus der Kinderen eed224b791e27ef02bc07f03bdfc890f4bda5b31
Applied various minor improvements suggested by the IDE.
- xmppserver/src/main/java/org/jivesoftware/openfire/auth/JDBCAuthProvider.java (version eed224b791e27ef02bc07f03bdfc890f4bda5b31)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/JDBCUserProvider.java (version eed224b791e27ef02bc07f03bdfc890f4bda5b31)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/property/JDBCUserPropertyProvider.java (version eed224b791e27ef02bc07f03bdfc890f4bda5b31)
-
mightymop <totzkotz@gmail.com> ca9b8a38d6587f37136cf425d30aade9ba030681
OF-2038: Search for shared Groups in DB instead of LDAP
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version ca9b8a38d6587f37136cf425d30aade9ba030681)
-
Guus der Kinderen af9106607919270e936f95f9252f89cb3fc250ce
OF-2031: Update dom4j to version 2.1.3
Version 2.1.3 fixes a vulnerability identified as CVE-2020-10683- xmppserver/pom.xml (version af9106607919270e936f95f9252f89cb3fc250ce)
-
Guus der Kinderen bfdb31a05d6377622995d30c47b83d340e579222
OF-2032 Merge pull request #1639 from promiselaoliu/webadmin
WEBADMIN should be of C2S connection type -
Guus der Kinderen 7da52b08bef13f0a279a3fdf1026e7c5e4fcc714
OF-1998: Remove broken support for event listener on single HTTP session
Note that it continues to be possible to register SesionListener instances that trigger on events for all (as opposed to a single) HttpSession instances through org.jivesoftware.openfire.http.SessionEventDispatcher- xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpSession.java (version 7da52b08bef13f0a279a3fdf1026e7c5e4fcc714)
-
Guus der Kinderen ede343d2ca453a2920935ccabe6a4a58fcc3eb77
OF-2012: Remove, instead of add, a route when a session becomes unavailable
- xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version ede343d2ca453a2920935ccabe6a4a58fcc3eb77)
-
akrherz <akrherz@iastate.edu> f7cb442535c0d5bb2db4b801b49cc4522700f4ac
verbatim install4j 8.0.6 initiated schema update
- distribution/src/installer/openfire.install4j (version f7cb442535c0d5bb2db4b801b49cc4522700f4ac)
-
akrherz <akrherz@iastate.edu> 8cbb4118620d2c5f3a313526dfd72e554c173781
OF-1982: add JVM arguments for better TLS compat
- distribution/src/installer/openfire.install4j (version 8cbb4118620d2c5f3a313526dfd72e554c173781)
-
Guus der Kinderen 2d468a782246effaf8cfc85718201880f200e923
OF-1982: Additional JVM arguments to have better TLS compatibility
- distribution/src/bin/openfire-dev.bat (version 2d468a782246effaf8cfc85718201880f200e923)
- distribution/src/bin/openfire.bat (version 2d468a782246effaf8cfc85718201880f200e923)
- distribution/src/bin/openfire.sh (version 2d468a782246effaf8cfc85718201880f200e923)
- distribution/src/bin/openfirectl (version 2d468a782246effaf8cfc85718201880f200e923)
-
Liu, Yong-Liang <yong-liang.liu@microfocus.com> 1215c6ef8e1c1229c87d2651cb8d6d11d2bc67e4
WEBADMIN should be C2S
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionType.java (version 1215c6ef8e1c1229c87d2651cb8d6d11d2bc67e4)
-
Guus der Kinderen 2c81dca147504b38d3d8ae686f0041970d97e30a
Update muc-room-edit-form.jsp
Fix for broken HTML tag.- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 2c81dca147504b38d3d8ae686f0041970d97e30a)
-
Guus der Kinderen eec3b3b9565e7f0d020101c776e4487a8e3d8a9c
OF-2026: Do not require XEP-0359 values to be UUIDs
- xmppserver/src/main/java/org/jivesoftware/openfire/stanzaid/StanzaIDUtil.java (version eec3b3b9565e7f0d020101c776e4487a8e3d8a9c)
- xmppserver/src/test/java/org/jivesoftware/openfire/stanzaid/StanzaIDUtilTest.java (version eec3b3b9565e7f0d020101c776e4487a8e3d8a9c)
-
daryl herzmann <akrherz@iastate.edu> 033d15b1851bf411b6d208dd878ef7da8034b889
Merge pull request #1631 from guusdk/OF-2019_MUC-Archiving-delay-start
OF-2019 muc archiving delay start -
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> e6c084407a6fa2de6aded261b3d5f7cd408909f9
OF-2019: Go back to old naming of the logConversationBatchSize property, to not break 3rd party code.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version e6c084407a6fa2de6aded261b3d5f7cd408909f9)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version e6c084407a6fa2de6aded261b3d5f7cd408909f9)
- xmppserver/src/main/webapp/muc-tasks.jsp (version e6c084407a6fa2de6aded261b3d5f7cd408909f9)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> a0fec31a5f8a732b9cb57e953433d3d310a5b644
OF-2019: Do not create the archiver before its first use. This saves performance overhead for situations where conversation logging is not used.
- xmppserver/src/main/java/org/jivesoftware/openfire/archive/Archiver.java (version a0fec31a5f8a732b9cb57e953433d3d310a5b644)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version a0fec31a5f8a732b9cb57e953433d3d310a5b644)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version a0fec31a5f8a732b9cb57e953433d3d310a5b644)
- xmppserver/src/main/webapp/muc-tasks.jsp (version a0fec31a5f8a732b9cb57e953433d3d310a5b644)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> baed8e7f83148ac8cd850706d126316ef24bca74
OF-2019: Correction: use the non-deprecated accessors from the configuration jsp as well.
- xmppserver/src/main/webapp/muc-tasks.jsp (version baed8e7f83148ac8cd850706d126316ef24bca74)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> 55b3de5d370a5b8519a420f4e5f09cbc280e11d4
OF-2019: Lazy instantiation of archiver now applies the double-check idiom.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 55b3de5d370a5b8519a420f4e5f09cbc280e11d4)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> 9bbf86f7cb6675c9c7d2033215804dc4ae984c76
OF-2019: Support two different names for the max conversation batch size: the one that was specified in the interface, and the one that was specified in the implementation.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 9bbf86f7cb6675c9c7d2033215804dc4ae984c76)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> 88fac7df0a551bfae3e555881532f2a160afd1bf
OF-2019: Reordering of property names in interface and impl. Now there is a clear separation between "old" deprecated properties and newer properties that are used to configure the archiving process. Property names are still quite similar though, so take care to not use the deprecated ones.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version 88fac7df0a551bfae3e555881532f2a160afd1bf)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 88fac7df0a551bfae3e555881532f2a160afd1bf)
-
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> dbf42ecde240a7b6562a2bf5cf4084246ec050ee
OF-2019: Restore the getArchiver() accessor, as it is essential for the monitoring plugin and possibly other plugins.
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version dbf42ecde240a7b6562a2bf5cf4084246ec050ee)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version dbf42ecde240a7b6562a2bf5cf4084246ec050ee)
-
daryl herzmann <akrherz@iastate.edu> 804741c75acb6d93054ff0613b48a7a0ea015a57
Merge pull request #1633 from guusdk/add-debug-logging
Fix OF-2025 and add debug logging -
Guus der Kinderen 369765dbb0efb6b1f8b786e42158f5ef2ed20495
OF-2025: PEP: evaluate all full JIDs for each subscriber
When processing full JIDs for each subscriber to see if a notification needs to be delivered, do not stop after finding the first full JID that is not to receive a notification. Others might still be eligible.- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPService.java (version 369765dbb0efb6b1f8b786e42158f5ef2ed20495)
-
Guus der Kinderen faa93bd31785041591cc654ea9158ab8510377b8
Add trace logging to CAPS processing
- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version faa93bd31785041591cc654ea9158ab8510377b8)
-
Guus der Kinderen cff16684fb4566d4e7a8db31884d4cd0be9afa07
Add trace logging statements to PEP
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPService.java (version cff16684fb4566d4e7a8db31884d4cd0be9afa07)
-
Guus der Kinderen 90322236f9615b6ca54fbc3bf95bbb1b659f4d9a
Upgrade Smack used in integration tests.
This commit upgrades Smack to version 4.4.0-alpha3-20200513.010448-11 which pulls in the fix for Smack to pick up PEP notifications that are of a different stanza type than 'headline' (see https://github.com/igniterealtime/Smack/commit/25a5261dc0e7a702ee7488f2954390d46f2cd702)- .github/workflows/continuous-integration-workflow.yml (version 90322236f9615b6ca54fbc3bf95bbb1b659f4d9a)
- runIntegrationTests (version 90322236f9615b6ca54fbc3bf95bbb1b659f4d9a)
-
Guus der Kinderen 6f2de0a11da3c26a725d8e25b6d11e4bf6631176
Re-enable Smacks MoodIntegrationTest integration test
The Mood implementation is based on PEP, just like the UserTune test which now consistently (?) succeeds.- .github/workflows/continuous-integration-workflow.yml (version 6f2de0a11da3c26a725d8e25b6d11e4bf6631176)
- runIntegrationTests (version 6f2de0a11da3c26a725d8e25b6d11e4bf6631176)
-
Guus der Kinderen 457922ccf0ffd59307813dd85b4d666b67cb4678
OF-2020: Don't recreate pepservice in process of deleting it.
When a PEP Service is destroyed, all of its nodes are destroyed as well.
The current implementation first deletes the PEP service itself, and then iterates over all of its nodes to delete them.
When deleting a node, the internal code tries to obtain its PEP service. As that was just deleted, it's auto-created again (or, alternatively, an exception occurs).
Openfire should first delete the nodes and only then remove the PEP service to avoid this issue.- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPServiceManager.java (version 457922ccf0ffd59307813dd85b4d666b67cb4678)
-
Guus der Kinderen e610a612becc61a1d49b358120490ff31bde17ed
OF-1990 / OF-1989: Ensure that pubsub items can be overwritten by using the same ID.
XEP-0060 (section 7.1.2) states that if the publisher previously published an item with the same ItemID, successfully processing the request means that the service MUST overwrite the old item with the new item.
Prior to the changes in OF-1990, Openfire probably did this implicitly, through its use of caches. After these changes, duplicate key SQL errors occur when an item with a pre-existing ItemID is being saved (conditionally - when the Cached provider is used, the error seems to be gobbled up).
A similar error is present in the InMemory provider, which will simply add (not replace) the new Item to the node. As test cases use the default max_items value of 1, this has gone unnoticed during testing.- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/DefaultPubSubPersistenceProvider.java (version e610a612becc61a1d49b358120490ff31bde17ed)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/InMemoryPubSubPersistenceProvider.java (version e610a612becc61a1d49b358120490ff31bde17ed)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubPersistenceProvider.java (version e610a612becc61a1d49b358120490ff31bde17ed)
-
Guus der Kinderen 9269d00766a336a3f4805be18d99ea148726bd07
OF-1985: Seperate pubsub service creation that requires service to exist.
When creating a pubsub/pep service, some initialization requires the service to exist. This leads to a chicken/egg problem.
This commit splits off the code that requires the service to have been constructed from the constructor, and calls that initialization only after the newly created service has been registered.- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPService.java (version 9269d00766a336a3f4805be18d99ea148726bd07)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPServiceManager.java (version 9269d00766a336a3f4805be18d99ea148726bd07)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/DefaultPubSubPersistenceProvider.java (version 9269d00766a336a3f4805be18d99ea148726bd07)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/InMemoryPubSubPersistenceProvider.java (version 9269d00766a336a3f4805be18d99ea148726bd07)
-
Guus der Kinderen 7c437ebaffa404c06244ecfcce8c0bdcae109374
OF-1988: Correcting property name for i81n
This prevents the '???' from showing up in the system property listing on the Admin console.- i18n/src/main/resources/openfire_i18n.properties (version 7c437ebaffa404c06244ecfcce8c0bdcae109374)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 7c437ebaffa404c06244ecfcce8c0bdcae109374)
-
Guus der Kinderen fda380c8c02eac31fb14145083a2ebe0b4103b87
Fix comment
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/Node.java (version fda380c8c02eac31fb14145083a2ebe0b4103b87)
-
Guus der Kinderen a4571cb12c83b12374df2f6163672d0530717e70
OF-2016: CachingPubsubPersistenceProvider: flush immediately after creating root node of new PEP service
If the root node lingers in the caching layer, the PEP service for which the root node is created isn't accessible.- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProvider.java (version a4571cb12c83b12374df2f6163672d0530717e70)
-
Guus der Kinderen 79836eb8f0e89ee67d37f22ac48a4743d85d5048
OF-2016: Do not use Pubsub service when creating a node
When creating the root node of a Pubsub service, the service itself does not yet exist (which leads to nullpointers). This can be prevented by using the pubsub service identifier directly, rather than using the pubsub service instance to obtain that identifier.- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/DefaultPubSubPersistenceProvider.java (version 79836eb8f0e89ee67d37f22ac48a4743d85d5048)
-
Guus der Kinderen 067a71c9017bb2105838e9441fa47b1f56e84bf4
OF-2019: MUC archive worker need not start until work is produced
The Archive implementation (which is used to persist chat room history) polls quite aggresively. This has proven to be a problem in an environment that has many MUC services, as many threads performing these polls require quite some CPU resources.
When logging does not take place (eg: when it has been disabled) all of this is quite wasteful. This commit introduces a latch that, if used, delays the pollig until after the first message to-be-logged has been produced. This intends to prevent polling to take place on services where not a single message is being logged.- xmppserver/src/main/java/org/jivesoftware/openfire/archive/Archiver.java (version 067a71c9017bb2105838e9441fa47b1f56e84bf4)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 067a71c9017bb2105838e9441fa47b1f56e84bf4)
-
Guus der Kinderen f533a6500865dc00b438b5f1ba10c7dcd8a2c865
OF-1788: Adding feature to changelog for Openfire 4.4.0
OF-1788 was fixed in Openfire 4.4.0. We've previously neglected to close the JIRA issue, which made this feature not pop up in the changelog before.- xmppserver/changelog.html (version f533a6500865dc00b438b5f1ba10c7dcd8a2c865)
-
Guus der Kinderen 9db2722ba0986ba620c0b110e624ac123dede2c5
Cleanup of code layout
- xmppserver/src/main/java/org/jivesoftware/openfire/archive/ArchiveManager.java (version 9db2722ba0986ba620c0b110e624ac123dede2c5)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 9db2722ba0986ba620c0b110e624ac123dede2c5)
-
Dele Olajide <dele@4ng.net> 3bd834bf82d079523f0b50d2a16e654276e1d363
OF-963: WebSocket keep-alive is not working as expected
XEP-0198 stream resumption is not yet implemented.
Prevent resumption from being negotiated for WS sessions.- xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version 3bd834bf82d079523f0b50d2a16e654276e1d363)
- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/XmppWebSocket.java (version 3bd834bf82d079523f0b50d2a16e654276e1d363)
-
daryl herzmann <akrherz@iastate.edu> 5017d0a10e1b91812bed74cdb426f730a108155f
Merge pull request #1629 from igniterealtime/fix-issue-OF-2017
Update Jetty to 9.4.28.v20200408 -
Dele Olajide <dele@4ng.net> 2200700b1d08a7b83a2ad91edc32241a0f80d480
Update Jetty to 9.4.28.v20200408
- pom.xml (version 2200700b1d08a7b83a2ad91edc32241a0f80d480)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/EncryptionArtifactFactory.java (version 2200700b1d08a7b83a2ad91edc32241a0f80d480)
-
daryl herzmann <akrherz@iastate.edu> e46bca20b638a3c164365e0040662b3568bbc430
Merge pull request #1626 from guusdk/sm-invalid-connection-fixes
Various fixes for Stream Management -
Guus der Kinderen 481f555554ab258ebcfc19ed6a6ad5053cd56026
Adding debug logging
- xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version 481f555554ab258ebcfc19ed6a6ad5053cd56026)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/LocalRoutingTable.java (version 481f555554ab258ebcfc19ed6a6ad5053cd56026)
-
Guus der Kinderen cff87d5620cf27266df7821e36dd14b5984a6284
OF-2015: Clean up the donor immediately after session resumption.
When Stream Management is used to resume an old session, the session that was used to resume the old session should be cleaned up immediately. Before this fix, the session lingers in a state of being 'detached'. Not only is there no reason for it to linger (it can't be resumed), marking it as 'detached' is semantically wrong: this session never reached a state where it makes sense to resume it later. The changes in this commit clean up the donor session immediately after resuption.- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalSession.java (version cff87d5620cf27266df7821e36dd14b5984a6284)
- xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version cff87d5620cf27266df7821e36dd14b5984a6284)
-
Guus der Kinderen 09d4b9a44a5fe25ee3ae24c55e99a6a91df1517f
OF-2014: Update OnConnectionClose callback object when re-initializing connection.
When a connection gets a new owner (Session), make sure that the old owner that was registered with the callback function gets replaced by the new owner. Without this, the callback will be invoked on the old (non-existing) session. This, among others, prevents Stream Management from working properly after a stream has been resumed for the first time.- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketConnection.java (version 09d4b9a44a5fe25ee3ae24c55e99a6a91df1517f)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/VirtualConnection.java (version 09d4b9a44a5fe25ee3ae24c55e99a6a91df1517f)
- xmppserver/src/main/java/org/jivesoftware/openfire/nio/NIOConnection.java (version 09d4b9a44a5fe25ee3ae24c55e99a6a91df1517f)
-
Guus der Kinderen 4033eefbdb788fb191efcd20b64f3e97526b0319
OF-2013: Improve detection of 'detached' session state.
Instead of assuming that a session is detached when it's connection is null (which could also be caused by the connection being closed), verify if the session is currently in the collection of detached sessions.- xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version 4033eefbdb788fb191efcd20b64f3e97526b0319)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalSession.java (version 4033eefbdb788fb191efcd20b64f3e97526b0319)
-
daryl herzmann <akrherz@iastate.edu> 38b32135db83be58bc69525727bb5860d975164a
Merge pull request #1625 from pzygielo/typos
Fix some typos -
Piotrek Żygieło <pzygielo@users.noreply.github.com> d0429321bb6eb98d46889f8aeca15373cbf12c23
Fix some typos
- i18n/src/main/resources/openfire_i18n.properties (version d0429321bb6eb98d46889f8aeca15373cbf12c23)
-
Florian Schmaus <flo@geekplace.eu> 9877e530aea904c03c671c48e101314628211325
sinttest: update smack to 4.4.0-alpha3-20200416.010506-6
and disable tests that fail with openfire.- runIntegrationTests (version 9877e530aea904c03c671c48e101314628211325)
- test.gradle (version 9877e530aea904c03c671c48e101314628211325)
-
daryl herzmann <akrherz@iastate.edu> 5b10a785248422d77be216d6535eb6097dc217e5
Merge pull request #1591 from guusdk/OF-158_Make-room-defaults-configurable
OF-158: Make room default settings use configurable service defaults. -
daryl herzmann <akrherz@iastate.edu> eadd16056413f9c97437da9f02132f5d2a322ead
Merge pull request #1621 from guusdk/OF-2008_autosetup-usrs
OF-2008: Allow users to be provisioned through autosetup -
Guus der Kinderen 72afcf63042e71f4ef8783080bad944d7067fe64
OF-2008: Allow users to be provisioned through autosetup
- distribution/src/conf/openfire-demoboot.xml (version 72afcf63042e71f4ef8783080bad944d7067fe64)
- documentation/install-guide.html (version 72afcf63042e71f4ef8783080bad944d7067fe64)
- xmppserver/src/main/java/org/jivesoftware/openfire/XMPPServer.java (version 72afcf63042e71f4ef8783080bad944d7067fe64)
-
Guus der Kinderen 058fdc20cc8804faf95ca8d78d222643aea049cb
aioxmpp tests: use their 'devel' instead of feature branch
- .github/workflows/continuous-integration-workflow.yml (version 058fdc20cc8804faf95ca8d78d222643aea049cb)
- runAioxmppIntegrationTests (version 058fdc20cc8804faf95ca8d78d222643aea049cb)
-
daryl herzmann <akrherz@iastate.edu> 35c72dffbb95babe4fe9be2f3790082085989784
Merge pull request #1605 from guusdk/OF-1996_shutdown-order
OF-1996: shutdown order -
daryl herzmann <akrherz@iastate.edu> c6e621c30f09612aafe8576ee5807dad495f74c3
Merge pull request #1608 from guusdk/OF-2000_no-more-string-intern-locks
OF-2000: Stop using intern'ed strings as locks -
daryl herzmann <akrherz@iastate.edu> aaab1a804c54edd76051e7db667010378a8d6411
Merge pull request #1604 from akrherz/ci
update Travis-CI badge -
Guus der Kinderen 549568c21a2ee0b6253998630127e24922d0474b
OF-2000: Stop using intern'ed strings as locks
This replaces the (often namespaced) interned strings used to synchronize on (which introduces a risk of deadlock) with a dedicated map of locks that mimics String interning for any other object type (that should be immutable).
Drawbacks of this solution:
- provided by Google Guava that is marked as 'Beta'
- probably more resource intensive than the native, String-based mutex.- xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version 549568c21a2ee0b6253998630127e24922d0474b)
- xmppserver/src/main/java/org/jivesoftware/openfire/lockout/LockOutManager.java (version 549568c21a2ee0b6253998630127e24922d0474b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 549568c21a2ee0b6253998630127e24922d0474b)
- xmppserver/src/main/java/org/jivesoftware/openfire/server/OutgoingSessionPromise.java (version 549568c21a2ee0b6253998630127e24922d0474b)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/UserManager.java (version 549568c21a2ee0b6253998630127e24922d0474b)
- xmppserver/src/main/java/org/jivesoftware/openfire/vcard/DefaultVCardProvider.java (version 549568c21a2ee0b6253998630127e24922d0474b)
-
Guus der Kinderen c6dff44d339c51794562a08691c9e90c180b32b6
OF-1996: Shut down plugins before modules
- xmppserver/src/main/java/org/jivesoftware/openfire/XMPPServer.java (version c6dff44d339c51794562a08691c9e90c180b32b6)