Build: #1300 was successful Manual run by daryl herzmann
Code commits
Openfire (master)
-
akrherz <akrherz@iastate.edu> 13e73ed3d7fc00646c642d02b66b50a86cd1c42b
Denote Openfire 4.6.0 Release
- distribution/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- i18n/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- plugins/openfire-plugin-assembly-descriptor/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- plugins/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- starter/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- xmppserver/changelog.html (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- xmppserver/pom.xml (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/XMPPServerInfoImpl.java (version 13e73ed3d7fc00646c642d02b66b50a86cd1c42b)
-
daryl herzmann <akrherz@iastate.edu> 623bf527044cc51ee547726a760497aedd5cf16f
Merge pull request #1738 from guusdk/OF-1789_jetty-restart-issue
OF-1789: Explicitly close all handlers when stopping Jetty -
Guus der Kinderen 22d1afa2a3087ba5a89e3e03c8c2887db996f32a
OF-1789: Explicitly close all handlers when stopping Jetty
Without this, restarting Jetty (sometimes) causes an error, indiating that we're trying to start something that's already started. This seems to happen only when the handler was being used when it was supposed to be stopped (eg: have an active BOSH connection).- xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpBindManager.java (version 22d1afa2a3087ba5a89e3e03c8c2887db996f32a)
-
daryl herzmann <akrherz@iastate.edu> e1c09cb2250cc1ac978ef27c56e36cdd07b05367
Merge pull request #1737 from Fishbowler/no_mvn_publish_on_forks
Github Actions: Only run maven publish on IgniteRealtime, not on forks -
Dan Caseley <dan@caseley.me.uk> a4435755ccbb929bee0955bd4174599dc12b824c
Github Actions: Only run maven publish on IgniteRealtime, not on forks
- .github/workflows/continuous-integration-workflow.yml (version a4435755ccbb929bee0955bd4174599dc12b824c)
-
Guus der Kinderen 34aa365b95929afba612f97ad1ea431e73f9a9e1
OF-2033: Add Dutch translations
- i18n/src/main/resources/openfire_i18n_nl.properties (version 34aa365b95929afba612f97ad1ea431e73f9a9e1)
-
daryl herzmann <akrherz@iastate.edu> 62836bde5a7d1cae780a1e086deba4083160695d
Merge pull request #1654 from mightymop/offdelete2
OF-2033 Feature: Add automatic cleaning of outdated offline messages -
daryl herzmann <akrherz@iastate.edu> 3e9362abbd6b57d52c7bd78e9a0fa766c9533d8a
Merge pull request #1736 from Fishbowler/codeql
Add GitHub CodeQL to Openfire -
Dan Caseley <dan@caseley.me.uk> b374e659fd48ed6eb5e2d2267bcd501b9ac99e35
Use assertEquals for booleans
- xmppserver/src/test/java/org/jivesoftware/openfire/spi/ConnectionTypeTest.java (version b374e659fd48ed6eb5e2d2267bcd501b9ac99e35)
-
Dan Caseley <dan@caseley.me.uk> c80e4382bb85d00603a81ec992ef5b29be02c5c6
Refactor ConnectionTypeTest to be parameterised
Test from #1652 had a typo, so a good opportunity- xmppserver/src/test/java/org/jivesoftware/openfire/spi/ConnectionTypeTest.java (version c80e4382bb85d00603a81ec992ef5b29be02c5c6)
-
Guus der Kinderen 86942be3b6758c6708de1b7537f2e58be4e99f16
OF-2033: Refactoring
By using Duration instances, rather than longs, the unit of time is not implicit. That makes for less error-prone code.
Using the SystemProperty value directly, rather than using an in-between field that holds the numeric, unit-less equivalent, reduces code complexity.
Various other bits and bobs that tweak things to conform more to ... well, personal preference really. ;)- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version 86942be3b6758c6708de1b7537f2e58be4e99f16)
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStrategy.java (version 86942be3b6758c6708de1b7537f2e58be4e99f16)
- xmppserver/src/main/webapp/offline-messages.jsp (version 86942be3b6758c6708de1b7537f2e58be4e99f16)
-
Guus der Kinderen 0818be6f14a00f349de3ea99bb4d098334892ee1
OF-2033: Prevent incorrect error detection
The original code logs that an error occurred, while in fact, that has not been the case.
(note that this commit removes closure of a statement: this will be restored in the next commit)- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version 0818be6f14a00f349de3ea99bb4d098334892ee1)
-
Guus der Kinderen 4d4ffa6cb27c00af228b8d3a232136a06efb4ca2
OF-2033: Add Dutch translations
- i18n/src/main/resources/openfire_i18n_nl.properties (version 4d4ffa6cb27c00af228b8d3a232136a06efb4ca2)
-
mightymop <totzkotz@gmail.com> bc941ff9567c6384e194a14ccd26105f8a09082d
Add brackets, changed logging...
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version bc941ff9567c6384e194a14ccd26105f8a09082d)
-
mightymop <totzkotz@gmail.com> fc2e92639b0af328611f50978a41200d37da0e60
OF-2033 Feature: Add automatic cleaning of outdated offline messages
- i18n/src/main/resources/openfire_i18n.properties (version fc2e92639b0af328611f50978a41200d37da0e60)
- i18n/src/main/resources/openfire_i18n_de.properties (version fc2e92639b0af328611f50978a41200d37da0e60)
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version fc2e92639b0af328611f50978a41200d37da0e60)
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStrategy.java (version fc2e92639b0af328611f50978a41200d37da0e60)
- xmppserver/src/main/webapp/offline-messages.jsp (version fc2e92639b0af328611f50978a41200d37da0e60)
-
Guus der Kinderen 7a026e376c9d1f8a749cdeeae6ba5d1ab99e6ba3
OF-2033: Fix SQL query syntax
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version 7a026e376c9d1f8a749cdeeae6ba5d1ab99e6ba3)
-
Dan Caseley <dan@caseley.me.uk> 82dc5f84fb175a6981c3b00c20498e35244a2801
Fix codeql-analysis.yml
- .github/workflows/codeql-analysis.yml (version 82dc5f84fb175a6981c3b00c20498e35244a2801)
-
Dan Caseley <dan@caseley.me.uk> 451eda75fb1e23d85ac24e20d2011fb3c7d31cc3
Create codeql-analysis.yml
- .github/workflows/codeql-analysis.yml (version 451eda75fb1e23d85ac24e20d2011fb3c7d31cc3)
-
Guus der Kinderen 0bbdac0d89702a71d21b3afe5f2a830811b52b2c
OF-2092: Additional logging around pubsub persistence
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProvider.java (version 0bbdac0d89702a71d21b3afe5f2a830811b52b2c)
-
Guus der Kinderen 325e0fbc324120c53c5840579b27fe925a159635
OF-2106: Replace deprecated usage of IsRegisteredUser in PubSubServiceInfo
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubServiceInfo.java (version 325e0fbc324120c53c5840579b27fe925a159635)
-
Guus der Kinderen 768f36cc795a0b53cd4306c4d2561e7d43f5213f
OF-2106: Simplify usage of IsRegisteredUser in IQPrivateHandler
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQPrivateHandler.java (version 768f36cc795a0b53cd4306c4d2561e7d43f5213f)
-
Guus der Kinderen 33fc572efc6a907af9e95d6a1cd790dead9a0446
OF-2106: Added additional unit test for new method
- xmppserver/src/test/java/org/jivesoftware/openfire/user/UserManagerTest.java (version 33fc572efc6a907af9e95d6a1cd790dead9a0446)
-
Guus der Kinderen 59956f18bee983011b8428151c3b718862b88401
OF-2106: Bugfix: usage of IsRegisteredUser in IQBlockingHandler should be limited to local domain
The code intends to verify the existence of a local user, but did not. This change fixes that (and potentially prevents a costly lookup).- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQBlockingHandler.java (version 59956f18bee983011b8428151c3b718862b88401)
-
Guus der Kinderen 56988e31eb7b75d11959562ae577f3821b21ffb1
OF-2106: Deprecate `UserManager.isRegisteredUser(String username)`
This method easily leads to bugs, as most of the invocations neglect to verify that the domain part of the associated user refers to the local XMPP domain.
Usages should be replaced by `UserManager.isRegisteredUser(username, false)`- xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStrategy.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/DiscoInfoProvider.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQOfflineMessagesHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQPrivacyHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQRosterHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/PresenceSubscribeHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/PresenceUpdateHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPServiceManager.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubServiceInfo.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/PresenceManagerImpl.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
- xmppserver/src/main/java/org/jivesoftware/openfire/user/UserManager.java (version 56988e31eb7b75d11959562ae577f3821b21ffb1)
-
Guus der Kinderen 04b5d6ff70ab6b9e1a9c7730a72599e3da53facd
OF-2106: Bugfix: usage of IsRegisteredUser in MultiUserChatServiceImpl should be limited to local domain
The code intends to verify the existence of a local user, but did not. This change fixes that (and potentially prevents a costly lookup).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 04b5d6ff70ab6b9e1a9c7730a72599e3da53facd)
-
Guus der Kinderen e734ebe5465ad2c752bb2b76cc55729fb6f1a4e6
OF-2106: argument to isRegisteredUser should not be null
- xmppserver/src/main/java/org/jivesoftware/openfire/user/UserManager.java (version e734ebe5465ad2c752bb2b76cc55729fb6f1a4e6)
-
Guus der Kinderen 5255fc859f746aae9882de0a47161cb61560af64
OF-2107: Message broadcast to full JID fix
This change fixes the implementation to do what the javadoc says it does, particularly in context of full JID addresses.
This commit also removes the potentially costly lookup of 'registered user' (that could do remote lookups, see OF-2106).- xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version 5255fc859f746aae9882de0a47161cb61560af64)
-
Guus der Kinderen c69802d9a1a710e7c509398fa78072a4746ed2bc
OF-2106: Replace IsRegisteredUser with clearer signature
This commit deprecates the existing IsRegisteredUser(JID jid) implemenation, which is easily used to introduce bugs.
The original signature is retained for backwards compatibility, marked as being deprecated.
The new singature takes a boolean flag that is used to explicitly indicate if it's desirable to perform S2S lookups.- xmppserver/src/main/java/org/jivesoftware/openfire/user/UserManager.java (version c69802d9a1a710e7c509398fa78072a4746ed2bc)
-
Guus der Kinderen 425d16948588806b35bed3b6ccf58716676103da
OF-2106: Bugfix: usage of IsRegisteredUser in group-edit.jsp should be limited to local domain
The code intends to verify the existence of a local user, but did not. This change fixes that (and potentially prevents a costly lookup).- xmppserver/src/main/webapp/group-edit.jsp (version 425d16948588806b35bed3b6ccf58716676103da)
-
Guus der Kinderen 157752674530ad43e7f3194f9ffddc690230a4dc
OF-2106: Simplify usage of IsRegisteredUser in OfflineMessageStore
- xmppserver/src/main/java/org/jivesoftware/openfire/OfflineMessageStore.java (version 157752674530ad43e7f3194f9ffddc690230a4dc)
-
Guus der Kinderen a86d35a8555592363687339c57bb06623fe6b4d8
OF-2106: Replace deprecated usage of IsRegisteredUser in PubSubEngine
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubEngine.java (version a86d35a8555592363687339c57bb06623fe6b4d8)
-
Guus der Kinderen 8a1f51c4025ced9c5704f9d59927d3b62f92644e
OF-2106: Simplify usage of IsRegisteredUser in IQDiscoInfoHandler
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version 8a1f51c4025ced9c5704f9d59927d3b62f92644e)
-
Guus der Kinderen 02a8afc343993635f4522bbf8e29360b6b5ae4a0
OF-2110: Verify fallbacks all the way down
This catches potential future modifications where the chain of fallbacks is longer than one.
Also added a bit of unit tests.- xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionType.java (version 02a8afc343993635f4522bbf8e29360b6b5ae4a0)
- xmppserver/src/test/java/org/jivesoftware/openfire/spi/ConnectionTypeTest.java (version 02a8afc343993635f4522bbf8e29360b6b5ae4a0)
-
Liu, Yong-Liang <yong-liang.liu@microfocus.com> 8b7e482876b5846ed4f6bba711e5c1f01c84b8a6
Refactoring of conditions for C2S
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStoreManager.java (version 8b7e482876b5846ed4f6bba711e5c1f01c84b8a6)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionType.java (version 8b7e482876b5846ed4f6bba711e5c1f01c84b8a6)
- xmppserver/src/main/webapp/security-certificate-store-management.jsp (version 8b7e482876b5846ed4f6bba711e5c1f01c84b8a6)
-
Liu, Yong-Liang <yong-liang.liu@microfocus.com> 5a2670d17626ddda7ada75053b6f649e2ba4f3c7
replace tab with spaces
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionType.java (version 5a2670d17626ddda7ada75053b6f649e2ba4f3c7)
-
Liu, Yong-Liang <yong-liang.liu@microfocus.com> c83627db724c80ecf623950a28a3ed1a4f1ef015
rename to isClientOriented
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStoreManager.java (version c83627db724c80ecf623950a28a3ed1a4f1ef015)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionType.java (version c83627db724c80ecf623950a28a3ed1a4f1ef015)
- xmppserver/src/main/webapp/security-certificate-store-management.jsp (version c83627db724c80ecf623950a28a3ed1a4f1ef015)
-
Nikola <nikola@feinfone.com> 0be88765f7320bd8427f9aec413a38c94408ba1f
XEP-0045 7.2.13 - ofrom adresse in message stanza
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 0be88765f7320bd8427f9aec413a38c94408ba1f)