Build: #1188 was successful Scheduled with changes by 3 people

Build result summary

Details

Completed
Queue duration
6 minutes
Duration
3 minutes
Labels
None
Revision
4acc9b381307eba567c2a35db59848b4559a4edd
Total tests
600
Successful since
#1139 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 4acc9b381307eba567c2a35db59848b4559a4edd OF-2424: Assert when LocalSession is null
Under certain circumstances (notably, when a session is detached), a session's connection can be null.

This commit adds assertions to identify the null-ability of a sessin's connection, and ensures that a null connection is not attempted to be used in a context where it is assumed to be non-null.
Guus der Kinderen Guus der Kinderen 992a5d17f127a3db480ef1ce83f3131efa069a60 OF-2456: properly propagate a nickname change over the cluster.
Guus der Kinderen Guus der Kinderen 4a5f96f1d6626638ced429455113885dc937096d OF-2458: Guard access to field to prevent ConcurrentModificationException
The internal field 'presence' should not be modified when read, as that has been observed to lead to ConcurrentModificationException being thrown.

This commit adds a lock to all access to the 'presence' and related 'extendedInformation' fields, to prevent this from happening.

Additionaly, the instance returned by the `getPresence()` method has been replaced with a defensive copy (much of the invoking code did immediately create such a copy after acquiring the instance, which now has been removed).
Guus der Kinderen Guus der Kinderen a9d17739849cab460c8b424f88273bc79cac593d Minor non-functional changes (mostly spelling)
Guus der Kinderen Guus der Kinderen 9c22fcafd25714a97518f1e0ee372eeb42337119 Removed two redundant null-checks spotted by LGTM.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2424Could not obtain issue details from Jira
Unknown Issue TypeOF-2444Could not obtain issue details from Jira
Unknown Issue TypeOF-2456Could not obtain issue details from Jira
Unknown Issue TypeOF-2458Could not obtain issue details from Jira