Build: #1245 was successful Manual run by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
1 second
Duration
1 minute
Labels
None
Agent
Default Agent
Revision
834544344819f37d2bc38190cfb98b9c1b934350
Total tests
466
Successful since
#749 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 834544344819f37d2bc38190cfb98b9c1b934350 OF-2289: Do not use Interner<String>
com.google.common.collect.Interner is not safe when used with Strings: as with String.intern(), an equal string value could end up being used as a mutex for unrelated code blocks (introducing the risk of deadlocks between code blocks that have no functional relation).

When an Interner instance is used with anohter immutable type, the generated mutexes are local to the Interner instance. This allows, for example, for the same JID value to be used with two different Interner instances, without the resulting mutexes influencing each-other.

This commit replaces all occurrances of Interner<String>.
Guus der Kinderen Guus der Kinderen 7872f54fa4b1c8c56b4af1ed03f1521f41108f1e OF-2315: First log, then process
By first logging the error condition, the log file will contain a cause for the problem if processing the problem generates a (new) stacktrace (which hides the original one).
Guus der Kinderen Guus der Kinderen c6a54b6cb5379c7815757a8013608a6eccd803a5 OF-2316: Make fast-discard timeout configurable
Guus der Kinderen Guus der Kinderen 7c08a12d9544b35933a3a9b4a403a602f8caf018 OF-2315: Don't attempt to reply to IQ responses
An IQ 'result' or 'error' stanza cannot be responded to. Attempting to do so might cause endless loops of responses to responses, if the code would not have nullpointered out because of a lack of child element to respond to.
Emiel van der Herberg <emiel.van.der.herberg@marviq.com> Emiel van der Herberg <emiel.van.der.herberg@marviq.com> b5ad6278231ebf268199d5df035b212b88c3c20a OF-2314 Prevent problem in one s2s connection close from blocking others.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2289Could not obtain issue details from Jira
Unknown Issue TypeOF-2314Could not obtain issue details from Jira
Unknown Issue TypeOF-2315Could not obtain issue details from Jira
Unknown Issue TypeOF-2316Could not obtain issue details from Jira
Unknown Issue TypeOF-2317Could not obtain issue details from Jira