Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #2356 was successful Changes by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
4 minutes
Labels
None
Agent
Default Agent
Revision
317e0659aa3be5c50a18ccd44697338e4d37cc41
Total tests
647
Successful since
#2354 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 317e0659aa3be5c50a18ccd44697338e4d37cc41 OF-2556: Add unit tests and rename method
Guus der Kinderen Guus der Kinderen 5dbf2a7699e7165177a9f8294b0879648bc5bb7d OF-2556: Record namespace prefixes sent on root XML element
XMPP connections take the form of an XML document, starting with a 'stream' root element.

Openfire processes the direct child elements as if they were individual documents (for reasons beyond the scope of this issue). In that approach, any namespaces defined in the original root element are lost.

Generally, this isn't much of an issue, as a default namespace is assumed/used that is specific to the connection type. However, if the root element defined _other_ issues, that information is lost.

Defining additional namespaces is allowed in XML/XMPP, but isn't typically used. If it were, we would have hit problems long ago. There is one known application of this, which is Dialback (refactoring Openfire's S2S server to use MINA as part of OF-1112 is how this issue was found).

Openfire should be able to XML-parse child elements of the root 'stream' tags, if those child elements use a prefix that refers to a namespace defined on that root element.

This commit achieves that, by recording such declarations in the `Connection` representation over which they were sent. When such declarations are found, each stanza that is processed is wrapped in dummy root element, on which those definitions are placed, prioer to XML parsing. After parsing, the root element is discarded again.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-1112Could not obtain issue details from Jira
Unknown Issue TypeOF-2556Could not obtain issue details from Jira