Build #743

Plan branch:
Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #743 was successful Changes by Florian Schmaus <flo@geekplace.eu>

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
4 minutes
Labels
None
Agent
Default Agent
Revision
c80afbbce79940ec9309b7544d644e3d6545cfb3
Total tests
775
Successful since
#690 ()

Tests

Code commits

Author Commit Message Commit date
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> c80afbbce79940ec9309b7544d644e3d6545cfb3 Merge pull request #404 from Flowdalic/ibb-manager-fix
[ibb] Ensure InBandBytestreamManager is a singleton
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> ed02bcf0d4a6e67fb496cb30bf15a6977825c37b [ibb] Ensure InBandBytestreamManager is a singleton
InBandBytestreamManager followed an unusual pattern: Within the
connectionTermianted() callback, it would remove itself from the
'managers' map. This allowed for multiple instances of an
InBandBytestreamManager to exist for the same connection, causing all
kinds of issues.

This fixes the issue by changing InBandBytestreamManager to use the
Smack-idiomatic pattern used by managers.

We also do no longer reset the listeners if the connection is
termianted, as listeners (and handlers) typically persist until they
are explicitly removed by the user.

As positive side-effect, the number of indeterministic unit-tests,
caused by using Thread.sleep(), is reduced. The executor service in
InitiationListener was also removed, because the IQ handler is already
called asynchronously to the connections main loop.

Thanks to Anno van Vliet for reporting this.