Nightly Distribution of the master branch

Build: #1650 was successful Changes by Florian Schmaus

Stages & jobs

  1. Default Stage

  2. Deploy

Build result summary

Details

Completed
Duration
9 minutes
Labels
None
Revision
d10319f1a0d1e3d90b346396d02ad84092ec4284 d10319f1a0d1e3d90b346396d02ad84092ec4284
Total tests
683
First to pass since
#1649 (Changes by Florian Schmaus)

Tests

Code commits

Author Commit Message Commit date
Florian Schmaus Florian Schmaus d10319f1a0d1e3d90b346396d02ad84092ec4284 d10319f1a0d1e3d90b346396d02ad84092ec4284 Merge branch '4.3'
Florian Schmaus Florian Schmaus c499556d077131c33714452917410dc28c5bce4d c499556d077131c33714452917410dc28c5bce4d Remove dead code from OmemoService
Florian Schmaus Florian Schmaus 7d7fbe68286d77f60c8f390034ee39f849f42dfa 7d7fbe68286d77f60c8f390034ee39f849f42dfa Do not explicity select the (crypto) Provider in smack-omemo
This makes the system select the "best" available provider.

Also the 'BC' provider in newer Android version does not longer
implement certain Ciphers, which causes an NoSuchAlgorithmException if
the Cipher is requested explicitly by the 'BC' provider:

E/XmppService: XmppServiceConnection - Error while sending pending messages
  org.jivesoftware.smackx.omemo.exceptions.CryptoFailedException: java.security.NoSuchAlgorithmException: The BC provider no longer provides an implementation for Cipher.AES/GCM/NoPadding.  Please see https://android-developers.googleblog.com/2018/03/cryptography-changes-in-android-p.html for more details.
      at org.jivesoftware.smackx.omemo.OmemoService.encrypt(OmemoService.java:375)
      at org.jivesoftware.smackx.omemo.OmemoService.createOmemoMessage(OmemoService.java:537)
      at org.jivesoftware.smackx.omemo.OmemoManager.encrypt(OmemoManager.java:341)
      at org.jivesoftware.smackx.omemo.OmemoManager.encrypt(OmemoManager.java:314)
      at es.iecisa.xmppservice.XmppServiceConnection.lambda$sendMessage$0(XmppServiceConnection.java:516)
      at es.iecisa.xmppservice.-$$Lambda$XmppServiceConnection$aBU_80chagvypMTSd-aSm7pRQRY.run(Unknown Source:4)
      at java.lang.Thread.run(Thread.java:764)
   Caused by: java.security.NoSuchAlgorithmException: The BC provider no longer provides an implementation for Cipher.AES/GCM/NoPadding.  Please see https://android-developers.googleblog.com/2018/03/cryptography-changes-in-android-p.html for more details.
      at sun.security.jca.Providers.checkBouncyCastleDeprecation(Providers.java:563)
      at sun.security.jca.Providers.checkBouncyCastleDeprecation(Providers.java:346)
      at javax.crypto.Cipher.createCipher(Cipher.java:722)
      at javax.crypto.Cipher.getInstance(Cipher.java:717)
      at javax.crypto.Cipher.getInstance(Cipher.java:674)
      at org.jivesoftware.smackx.omemo.util.OmemoMessageBuilder.setMessage(OmemoMessageBuilder.java:169)
      at org.jivesoftware.smackx.omemo.util.OmemoMessageBuilder.<init>(OmemoMessageBuilder.java:116)
      at org.jivesoftware.smackx.omemo.OmemoService.encrypt(OmemoService.java:372)
      at org.jivesoftware.smackx.omemo.OmemoService.createOmemoMessage(OmemoService.java:537)
      at org.jivesoftware.smackx.omemo.OmemoManager.encrypt(OmemoManager.java:341)
      at org.jivesoftware.smackx.omemo.OmemoManager.encrypt(OmemoManager.java:314)
      at es.iecisa.xmppservice.XmppServiceConnection.lambda$sendMessage$0(XmppServiceConnection.java:516)
      at es.iecisa.xmppservice.-$$Lambda$XmppServiceConnection$aBU_80chagvypMTSd-aSm7pRQRY.run(Unknown Source:4)
      at java.lang.Thread.run(Thread.java:764)
Florian Schmaus Florian Schmaus 9f8d13b8cdb53f2e2373a92203c5aa32b09a23fa 9f8d13b8cdb53f2e2373a92203c5aa32b09a23fa Do not explicitly select the Provider in HashManager
Note that we still setup the BouncyCastleProvider so all requested
MessageDigest instances should be avaialble.
Florian Schmaus Florian Schmaus d6a90942a45bcae9cf0a54583cdc30b3ee896a6a d6a90942a45bcae9cf0a54583cdc30b3ee896a6a Unify Bouncy Castle versions: Add bouncyCastleVersion variable

Jira issues

IssueDescriptionStatus
Unknown Issue TypeSMACK-383Could not obtain issue details from Jira
Unknown Issue TypeSMACK-861Could not obtain issue details from Jira