Build: #1695 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> 93aaf6d8d7df1071a224ef406738ff322c20724b
Remove SASLAuthentication.init()
-
Florian Schmaus <flo@geekplace.eu> bf538129c29a95ba3bed2c06247ab939bc38a624
SASL: Add missing InterruptedException to "else if" cascade
-
Florian Schmaus <flo@geekplace.eu> 5b1d2664af583e7c88101a1040e6c8ea3640ed78
Clear saslException class field before throwing
Thanks to PolFW, who writes:
A SASLErrorException is thrown before we have received the "<success
xmlns='urn:ietf:params:xml:ns:xmpp-sasl'/>". This is because
SASLAuthentication is keeping a reference to a "saslException" so to
clear that after a authentication failure we have to invoke again
connect on the xmpptcpconnection to initialize again the
saslAuthentication. But it doesn't solve the issue because an
AlreadyConnectedException is thrown before the initialisation of the
"this.saslAuthentication.init();"
Note that the user uses one time tokens for authentication. -
Florian Schmaus <flo@geekplace.eu> 002d060584251b1b014d9a5b05006a0d0bf6b72b
XmlStringBuilder: Map all XML serialization to appendXmlTo()
this is now the single place where serializatin happens. -
Florian Schmaus <flo@geekplace.eu> be0830fc8f22daa4f2a3ffa23af76d5cbf110cb0
smack-xmlparser: Improve ISE message
-
Florian Schmaus <flo@geekplace.eu> 6d7b2b70e8143febbd17a3b174789f436f4e42f1
Add util.Consumer and use it in StateDescriptorGraph
-
Florian Schmaus <flo@geekplace.eu> b1a5509927fe74d095add35ae014a713a169c49e
smack-tcp: Split dot to png into two makefile steps
Since using a pipe, as we did previously would not error the target if
the first command in the pipe fails.
It is still far from ideal, since the dot file is also generated if
the gradle command fails. At some point, this should probably become
part of gradle build step instead of shelling out to a Makefile. -
Florian Schmaus <flo@geekplace.eu> bd4b91fc26ff2007a24a33d514e6226c15016402
Introduce AbstractXMPPConnection.outgoingStreamXmlEnvironment
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version bd4b91fc26ff2007a24a33d514e6226c15016402) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/packet/XmlEnvironment.java (version bd4b91fc26ff2007a24a33d514e6226c15016402) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java (version bd4b91fc26ff2007a24a33d514e6226c15016402) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version bd4b91fc26ff2007a24a33d514e6226c15016402) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java (version bd4b91fc26ff2007a24a33d514e6226c15016402) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 28ef30b4b38c8f8b862df3da66e41ed5122d35d1
smack-java7: Add missing smack-xmlparser-stax dependency
Since 2f667f95a ("gradle: Remove archives configuration") the
:smack-repl:printXmppNioTcpConnectionStateGraph
JavaExec task failed with
> Task :smack-repl:printXmppNioTcpConnectionStateGraph FAILED
Exception in thread "main" java.lang.ExceptionInInitializerError
at org.jivesoftware.smack.SmackConfiguration.getVersion(SmackConfiguration.java:108)
at org.jivesoftware.smack.AbstractXMPPConnection.<clinit>(AbstractXMPPConnection.java:187)
at org.igniterealtime.smack.smackrepl.StateGraph.main(StateGraph.java:37)
Caused by: java.lang.IllegalStateException: Could not parse Smack configuration file
at org.jivesoftware.smack.SmackInitialization.<clinit>(SmackInitialization.java:100)
... 3 more
Caused by: java.lang.IllegalStateException: Could not load a XmlPullParserFactory via Service Provider Interface (SPI)
at org.jivesoftware.smack.xml.SmackXmlParser.getXmlPullParserFactory(SmackXmlParser.java:34)
at org.jivesoftware.smack.xml.SmackXmlParser.newXmlParser(SmackXmlParser.java:53)
at org.jivesoftware.smack.util.PacketParserUtils.getParserFor(PacketParserUtils.java:76)
at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:144)
at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:139)
at org.jivesoftware.smack.SmackInitialization.<clinit>(SmackInitialization.java:97)
... 3 more
because no XmlPullParser was registered via SPI. The 'archives'
configuration which was removed with 2f667f95a ("gradle: Remove
archives configuration"), previously pulled in the parser.
Just like smack-android delcares a dependency on smack-xmlparser-xpp3,
smack-java7 should declare a dependency on smack-xmlparser-stax.