Build: #1764 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> b7fe56fb9ba3bf4547999f0a18759e5ad1f8b16e
[xdata] Add message to IllegalArgumentException
-
Florian Schmaus <flo@geekplace.eu> 3e8666cd9197f94ccbfe0eaf184de707fb263496
[xdata] Fix case in FillableForm
-
Florian Schmaus <flo@geekplace.eu> 89e39fadd2717c1102913293dc72cd3574bfe25f
Merge pull request #403 from adiaholic/bugFix
Remove unrequired assignment of value to connectionEndpoint variable -
Florian Schmaus <flo@geekplace.eu> b1c0f3fa264bb1f6caf4104888e0e2a5b121e200
Merge branch 'master' of github.com:igniterealtime/Smack
-
Florian Schmaus <flo@geekplace.eu> c80afbbce79940ec9309b7544d644e3d6545cfb3
Merge pull request #404 from Flowdalic/ibb-manager-fix
[ibb] Ensure InBandBytestreamManager is a singleton -
Florian Schmaus <flo@geekplace.eu> ed02bcf0d4a6e67fb496cb30bf15a6977825c37b
[ibb] Ensure InBandBytestreamManager is a singleton
InBandBytestreamManager followed an unusual pattern: Within the
connectionTermianted() callback, it would remove itself from the
'managers' map. This allowed for multiple instances of an
InBandBytestreamManager to exist for the same connection, causing all
kinds of issues.
This fixes the issue by changing InBandBytestreamManager to use the
Smack-idiomatic pattern used by managers.
We also do no longer reset the listeners if the connection is
termianted, as listeners (and handlers) typically persist until they
are explicitly removed by the user.
As positive side-effect, the number of indeterministic unit-tests,
caused by using Thread.sleep(), is reduced. The executor service in
InitiationListener was also removed, because the IQ handler is already
called asynchronously to the connections main loop.
Thanks to Anno van Vliet for reporting this.- smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java (version ed02bcf0d4a6e67fb496cb30bf15a6977825c37b) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InitiationListener.java (version ed02bcf0d4a6e67fb496cb30bf15a6977825c37b) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/ibb/InitiationListenerTest.java (version ed02bcf0d4a6e67fb496cb30bf15a6977825c37b) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 049d68777868cb530eec6d51553a14cbfed0e100 m
[gradle] Add fix for javadoc search
-
Aditya Borikar <adityaborikar2@gmail.com> 45f75d5ce0dcb4e8c68ea59109211dda8799565f m
Remove unrequired assignment of value to connectionEndpoint variable
The current code would work just fine for a connection having
multiple endpoints. However, when there is only one endpoint
ConnectionAttemptState.nextAddress() would return null, since
connectionEndpointIterator has already iterated over the only
possible value in the contructor leading to a NullPointerException.
This means that during establishment of a connection having multiple
endpoints, the first value inside connectionEndpointIterator would
always be overlooked.