Build: #213 was successful Changes by Florian Schmaus <flo@geekplace.eu>

Build result summary

Details

Completed
Queue duration
8 minutes
Duration
11 minutes
Labels
None
Agent
Default Agent
Revision
8736e3e4345ad49e2e922e999770cdd31c10a1e5 8736e3e4345ad49e2e922e999770cdd31c10a1e5
Total tests
809
Successful since
#189 ()

Tests

Code commits

Author Commit Message Commit date
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> 8736e3e4345ad49e2e922e999770cdd31c10a1e5 8736e3e4345ad49e2e922e999770cdd31c10a1e5 [core] Remove erroneous "assert !connected" in connect()
Connections like XMPPTCPConnection may still reported connected, if
they are, for example disconnected but resumable. This is already
accounted for in throwAlreadyConnectedExceptionIfAppropriate(), hence
the assert is unnecessary and leads to false negatives for
XMPPTCPConnection.

For the sake of completeness, the right condition, assuming
XMPPTCPConnection is used, for the assert would be:

        assert !connected || disconnectedButResumable;

Shared artifacts

Artifact File size
Project binary files 22 MB