Build #406

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Build: #406 was successful Changes by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
22 seconds
Labels
None
Agent
Default Agent
Revision
2c99a4d16559b9968abd43879b468229024de84a
Total tests
5
Successful since
#340 ()

Tests

  • 0 New failures
  • 0 Existing failures
  • 0 Fixed

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 51fda254777a7e92e43b9e70ba4b3cc319e8f370 SPARK-2263: Fallback to room JID if bookmark has no name
In the ‘Bookmarks’ drop down menu, all bookmarks are shown by their name.

Bookmarks set by some other clients (like Conversations) do not have a name. This causes the bookmark to show as an empty text.

If this happens, Spark should use another value, like the localpart of the room JID.
Guus der Kinderen Guus der Kinderen 2c99a4d16559b9968abd43879b468229024de84a SPARK-2264: Use nickname in bookmark if set
Bookmarks can have an optional ‘nickname’ element. When joining a chat room from a bookmark, Spark should use the nickname, if it’s present.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeSPARK-2263Could not obtain issue details from Jira
Unknown Issue TypeSPARK-2264Could not obtain issue details from Jira