| Tests: | 770 passed |
|---|---|
| Duration: | 12 minutes |
| Changes: | Who: Florian Schmaus Why: Merge pull request #404 from Flowdalic/ibb-manager-fix [ibb] Ensure InBandBytestreamManager is a singleton Who: Florian Schmaus Why: Merge pull request #403 from adiaholic/bugFix Remove unrequired assignment of value to connectionEndpoint variable Who: Florian Schmaus Why: [ibb] Ensure InBandBytestreamManager is a singleton InBandBytestreamManager followed an unusual pattern: Within the connectionTermianted() callback, it would remove itself from the "managers" map. This allowed for multiple instances of an InBandBytestreamManager to exist for the same connection, causing all kinds of issues. This fixes the issue by changing InBandBytestreamManager to use the Smack-idiomatic pattern used by managers. We also do no longer reset the listeners if the connection is termianted, as listeners (and handlers) typically persist until they are explicitly removed by the user. As positive side-effect, the number of indeterministic unit-tests, caused by using Thread.sleep(), is reduced. The executor service in InitiationListener was also removed, because the IQ handler is already called asynchronously to the connections main loop. Thanks to Anno van Vliet for reporting this. Who: Florian Schmaus Why: [xdata] Fix case in FillableForm Who: Florian Schmaus Why: Merge branch "master" of github.com:igniterealtime/Smack ... |