Build #2,098

Plan branch:
Generates the latest/greatest Maven-based artifacts for the Openfire project, every night.

Build: #2098 was successful

Job: Run Maven was successful

Stages & jobs

  1. Build and Package

  2. Deploy

  3. copy nightlies to website

Code commits

Openfire (master)

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 7c563f57b188df71db5e67fcc857821470d73439

    Merge pull request #2169 from guusdk/OF-2566_StreamManagement-resumption-for-websockets
    Refactor WebSocket implementation

  • Guus der Kinderen

    Guus der Kinderen 230762cb7e878ae4a303ffb76ca743d883c24bfb

    OF-2566: Refactor WebSockets to reinstate Stream Management
    With OF-963, the 'resume' feature of Stream Management (XEP-0198) was disabled, as it was buggy. The purpose of this commit is to reinstate this feature.

    To do this, the implementation of WebSockets has been refactored to more closely resemble the implementation of the standard (socket/NIO-based) client
    connection handling. It does so by introducing a `WebSocketClientConnectionHandler` and a `WebSocketClientStanzaHandler` that mimics the application of
    `ClientConnectionHandler` and `ClientStanzaHandler` respectively, used for NIO/TCP sockets.

    The motivation to make the WebSocket handling more similar to that of NIO/TCP sockets is two-fold:
    - the latter is does not suffer from the Stream Management issue - it apparently does something better.
    - maintenance of the code will be simplified, by having the same approach being re-used.

    • i18n/src/main/resources/openfire_i18n.properties (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • i18n/src/main/resources/openfire_i18n_nl.properties (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientStanzaHandler.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalSession.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/Session.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/OpenfireWebSocketServlet.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketClientConnectionHandler.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketClientStanzaHandler.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketConnection.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/XmppWebSocket.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
    • xmppserver/src/test/java/org/jivesoftware/openfire/session/SessionTest.java (version 230762cb7e878ae4a303ffb76ca743d883c24bfb)
  • Guus der Kinderen

    Guus der Kinderen e111c7d063151557245346925a335d939972e9bc

    OF-2566: Revoke workaround for OF-2473
    With the refactoring of the websocket implementation in the previous commit, the workaround that addressed the threading issue (OF-2473) does no longer seem to be needed. I've executed the Tsung-based reproduction from that issue on the new code repeatedly, without reproducing the issue. This commit removes the work-around.

    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketClientConnectionHandler.java (version e111c7d063151557245346925a335d939972e9bc)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketConnection.java (version e111c7d063151557245346925a335d939972e9bc)
  • Guus der Kinderen

    Guus der Kinderen 08220e8cfe4d118ad054b79ab733c7b3b21136e7

    Refactor StanzaHandler: introduce StreamErrorException
    When validating a stream that is being set up, using a dedicated Exception instead of booleans will improve readability of the code, and will make it easier to extend the class.

    This commit introduces a StreamErrorException and uses that when validating a new stream.

    No functional changes are intended to be introduced by this commit.

    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientStanzaHandler.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ComponentStanzaHandler.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/MultiplexerStanzaHandler.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ServerStanzaHandler.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
    • xmppserver/src/main/java/org/jivesoftware/util/StreamErrorException.java (version 08220e8cfe4d118ad054b79ab733c7b3b21136e7)
  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 323ae3a38bfa35ec863af8ad6c8b4fec73a3efb8

    Merge pull request #2170 from guusdk/OF-2568_Stream-Management-ack-rollover
    OF-2568: Improve Stream Management roll-over detection

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> b58213c6f69d2703b2bed450ea9c6f8d239a80e2

    Merge pull request #2112 from guusdk/OF-2508_MUC-room-name-nodeprep
    OF-2508: Nodeprep room name when creating through Ad-hoc command

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 69b5b17124a0858d2847fd361a4a57b641f36655

    Merge pull request #2139 from guusdk/OF-2538_Fix-property-child-delete
    OF-2538: Only delete true child properties

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 304882ce006b321d4be8efa55d76999b66ee8e54

    Merge pull request #2131 from Fishbowler/OF-2527_milliseconds_in_log4j
    OF-2527: Default to millisecond-precision in log4j

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> b643026422c45ce7e2fac34cb4f3adeb9033ae81

    Merge pull request #2125 from akrherz/bump_install4j_maven
    bump install4j maven plugin to latest release

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> e6f1e7e0deac9c13dcb2836cb0075638879e7d50

    Merge pull request #2151 from guusdk/OF-2550_dnsutil-logging
    OF-2550: Additional logging when dnsutil.dnsOverride is used

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> b49b2703f7f9685e07dff487b6b1da8b229d3163

    Merge pull request #2155 from igniterealtime/dependabot/maven/build/ci/updater/org.postgresql-postgresql-42.4.3
    Bump postgresql from 42.4.1 to 42.4.3 in /build/ci/updater

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> a8e359d5431f1f45d930475ed576619509ac973b

    Merge pull request #2154 from igniterealtime/dependabot/maven/xmppserver/org.postgresql-postgresql-42.4.3
    Bump postgresql from 42.4.1 to 42.4.3 in /xmppserver

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> aacbba514a20368360223256e9b2c79262c1005d

    Merge pull request #2168 from guusdk/OF-2565_Drop-stream-prior-to-resource-binding
    OF-2565: Should drop stream when client sends stanzas prior to resource binding

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> e10b4da8ec55def3c8b5ada684e6b2d8eee50b92

    Merge pull request #2167 from guusdk/OF-2564_ServerSession-authentication-state
    OF-2564: Refactor server session authentication state

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 9c7a7df77c1e43fc9dc6a59dab3ee463eea5e105

    Merge pull request #2158 from guusdk/OF-2556-also-ignore-stream
    OF-2556: Ignore stream namespace

  • Guus der Kinderen

    Guus der Kinderen 186b04451239d74e5d814fc03836a8a290f2ecea

    OF-2568: Improve Stream Management roll-over detection
    When a client Ack's with a value _lower_ than the previous Ack'ed value, this should be interpreted as it Acking a stanza count that rolls over (2^32)-1. This very likely should cause the stream to be closed.

    • xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version 186b04451239d74e5d814fc03836a8a290f2ecea)
    • xmppserver/src/test/java/org/jivesoftware/openfire/streammanagement/StreamManagerTest.java (version 186b04451239d74e5d814fc03836a8a290f2ecea)
  • Guus der Kinderen

    Guus der Kinderen 8094b39d6fceceb593e2e9ed113fee5decd469ae m

    OF-2565: Should drop stream when client sends stanzas prior to resource binding
    RFC 6120, section 7.1 dictates:
    > If, before completing the resource binding step, the client attempts to send an XML
    > stanza to an entity other than the server itself or the client's account, the server MUST NOT process the
    > stanza and MUST close the stream with a `<not-authorized>` stream error.

    Openfire, prior to this commit, would reply to pretty much all stanzas that are sent prior to resource binding with a
    stanza (not stream) error, and would not terminate the stream when the stanza is addressed to an entity other than the
    server itself or the client's account.

    With this commit, stanzas that match the RFC definition will now cause the stream to be closed with a stream error.
    The prior behavior will remain in place for all other stanzas.

    Arguably, there is room for further optimization:
    - There appears to be duplication of processing in IQ-, Message- and PresenceRouter. However, they are invoked by other
      instances than those of SessionPacketRouter (which may in itself be something that's desirable to change)
    - XmppWebSocket appears to duplicate part of the processing of data that is exchanged during session setup. Comments
      have been added for future improvement.
    - The Openfire API makes it hard to distinghuish between 'client authenticated & completed resource binding' and
      'client authenticated, but did not complete resource binding yet'. There are no explicit handling for the latter
      scenario, which again could be improved upon in the future.

    • xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
    • xmppserver/src/main/java/org/jivesoftware/openfire/MessageRouter.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
    • xmppserver/src/main/java/org/jivesoftware/openfire/PresenceRouter.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
    • xmppserver/src/main/java/org/jivesoftware/openfire/SessionPacketRouter.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/XmppWebSocket.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
    • xmppserver/src/test/java/org/jivesoftware/openfire/SessionPacketRouterTest.java (version 8094b39d6fceceb593e2e9ed113fee5decd469ae)
  • Guus der Kinderen

    Guus der Kinderen 01660b4bbb1c2d77f832f52901e5dbcbff413c2e m

    OF-2564: Introduce enum for 'authentication method' for S2S session
    Prior to this commit, an S2S session was marked as 'Dialback', unless overridden (even non-authenticated sessions were marked as 'Dialback').

    Now, a session defines the authentication method that was used explicitly, and only after authentication has occurred.

    • i18n/src/main/resources/openfire_i18n.properties (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/SASLAuthentication.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/server/ServerDialback.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/IncomingServerSessionTask.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/OutgoingServerSessionTask.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteIncomingServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteOutgoingServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteSessionTask.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/ServerSession.java (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
    • xmppserver/src/main/webapp/server-session-details.jsp (version 01660b4bbb1c2d77f832f52901e5dbcbff413c2e)
  • Guus der Kinderen

    Guus der Kinderen 9535f35a757dca64f7d8e571b96cbf131f8f1e56 m

    OF-2564: Make sure S2S sessions get flagged as 'authenticated'

    • xmppserver/src/main/java/org/jivesoftware/openfire/server/ServerDialback.java (version 9535f35a757dca64f7d8e571b96cbf131f8f1e56)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 9535f35a757dca64f7d8e571b96cbf131f8f1e56)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version 9535f35a757dca64f7d8e571b96cbf131f8f1e56)
  • Guus der Kinderen

    Guus der Kinderen 89877e47c4fac303306d41d02e81ff91194b7508 m

    OF-2556: Ignore stream namespace
    Additionally ignore any explicity declaration of the http://etherx.jabber.org/streams namespace.

    • xmppserver/src/main/java/org/dom4j/io/XMPPPacketReader.java (version 89877e47c4fac303306d41d02e81ff91194b7508)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 89877e47c4fac303306d41d02e81ff91194b7508)
    • xmppserver/src/test/java/dom/io/XMPPPacketReaderTest.java (version 89877e47c4fac303306d41d02e81ff91194b7508)
  • dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bac127e0e952e22c9dacbd7dc34b5f3dc8ef363e m

    Bump postgresql from 42.4.1 to 42.4.3 in /xmppserver
    Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.1 to 42.4.3.
    - [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
    - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.3)

    ---
    updated-dependencies:
    - dependency-name: org.postgresql:postgresql
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    • xmppserver/pom.xml (version bac127e0e952e22c9dacbd7dc34b5f3dc8ef363e)
  • dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> b815c92a83e1a27b0c67a323faeeb16e05d4a4e3 m

    Bump postgresql from 42.4.1 to 42.4.3 in /build/ci/updater
    Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.1 to 42.4.3.
    - [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
    - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.3)

    ---
    updated-dependencies:
    - dependency-name: org.postgresql:postgresql
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    • build/ci/updater/pom.xml (version b815c92a83e1a27b0c67a323faeeb16e05d4a4e3)
  • Guus der Kinderen

    Guus der Kinderen 8b76b91d66455d43e005689c80ceef554ae9fd8d m

    OF-2550: Additional logging when dnsutil.dnsOverride is used

    • xmppserver/src/main/java/org/jivesoftware/openfire/net/DNSUtil.java (version 8b76b91d66455d43e005689c80ceef554ae9fd8d)
  • Guus der Kinderen

    Guus der Kinderen 9cd7d85b56d1d86dbce3ce1794bbf389e1fd6d95 m

    OF-2538: Only delete true child properties
    When deleting a property, its child properties are expected to be deleted.

    The original code would also delete properties that shared a common prefix. That is fixed by this commit.

    • xmppserver/src/main/java/org/jivesoftware/util/JiveProperties.java (version 9cd7d85b56d1d86dbce3ce1794bbf389e1fd6d95)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 3bf8dc4ade7a075ab3a304a82071f05413418b0d m

    OF-2527: Default to millisecond-precision in log4j

    • distribution/src/resources/log4j2.xml (version 3bf8dc4ade7a075ab3a304a82071f05413418b0d)
  • akrherz <akrherz@iastate.edu>

    akrherz <akrherz@iastate.edu> 488625c54c9a9eff007f5f2b926eb886dd43c8db m

    bump install4j maven plugin to latest release

    • distribution/pom.xml (version 488625c54c9a9eff007f5f2b926eb886dd43c8db)
  • Guus der Kinderen

    Guus der Kinderen abbeb78c34fce74bae0b8bb41e23de6ab1a3adc0 m

    OF-2508: Nodeprep room name when creating through Ad-hoc command
    Openfire provides an ad-hoc command that can be used to create a room. Openfire must ensure that room name values provided through that command are properly normalized (nodeprepped).

    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/muc/CreateMUCRoom.java (version abbeb78c34fce74bae0b8bb41e23de6ab1a3adc0)