Build: #1294 was successful Scheduled with changes by Guus der Kinderen

Build result summary


Queue duration
3 minutes
3 minutes
Total tests
Successful since
#1139 ()


Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen bf1382c23e3918541f23728c1277bd5d696d7002 OF-2524: Add database index for MUC room log retrieval
When loading the MUC room history for a single room, a query is executed that is not optimized by the existing database indexes:

`SELECT sender, nickname, logTime, subject, body, stanza FROM ofMucConversationLog WHERE logTime>? AND roomID=? AND (nickname IS NOT NULL OR subject IS NOT NULL) ORDER BY logTime`

On Ignite's server, this takes more than 400 milliseconds to execute.

When room preloading is disabled, all rooms that are being used need to be loaded from memory. Looking at the admin console will load all rooms on that page. If that contains 25 rooms, then this query alone causes a delay of many seconds before the page is loaded.
Guus der Kinderen Guus der Kinderen 56ba04f815a163ff2e833c1e5ec04b648cb517f9 OF-2524: Add MUC message history in bulk
Instead of loading message and adding to MUC room history one-by-one, do this in a batch.

With OF-2499, adding a message requires a lock to be held. In clustering, the repeated acquiring and releasing of that lock adds notable delays.

This commit prevents much of this overhead by adding all history in one go, replacing the lock contention for each message, with one singular lock.
Guus der Kinderen Guus der Kinderen e5e71ef5ac8f3e2efdd16f2f611aa8a3a5b4a13e OF-2521: Admin console: Rename S2S auth 'certificate' -> 'SASL EXTERNAL'.
Guus der Kinderen Guus der Kinderen bed928558ba0084500bbcdd571e5e57ee596e1e4 OF-2521: Allow SASL EXTERNAL for S2S by default
For SASL EXTERNAL to be used to authenticate server-to-server connections, Java's "client authentication" must be enabled, allowing peer certificates to be processed.

This improves on the changes in OF-1855, which would enable this by default _if_ the local server had a non-selfsigned certificate installed. That condition does not make a lot of sense, as the local certificate does/should not affect the validation of the certificates provided by the peer.

Jira issues

Unknown Issue TypeOF-1855Could not obtain issue details from Jira
Unknown Issue TypeOF-2499Could not obtain issue details from Jira
Unknown Issue TypeOF-2521Could not obtain issue details from Jira
Unknown Issue TypeOF-2524Could not obtain issue details from Jira