Build #1,840

Plan branch:
Nightly Distribution of the master branch

Build: #1840 was successful Changes by Florian Schmaus <flo@geekplace.eu>

Stages & jobs

  1. Default Stage

  2. Deploy

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
22 minutes
Labels
None
Revision
cad63bc1078524bf5ddf2515fe656adceb93034f cad63bc1078524bf5ddf2515fe656adceb93034f
Total tests
828
Successful since
#1831 ()

Tests

Code commits

Author Commit Message Commit date
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> cad63bc1078524bf5ddf2515fe656adceb93034f cad63bc1078524bf5ddf2515fe656adceb93034f Merge branch '4.4'
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> 8736e3e4345ad49e2e922e999770cdd31c10a1e5 m 8736e3e4345ad49e2e922e999770cdd31c10a1e5 [core] Remove erroneous "assert !connected" in connect()
Connections like XMPPTCPConnection may still reported connected, if
they are, for example disconnected but resumable. This is already
accounted for in throwAlreadyConnectedExceptionIfAppropriate(), hence
the assert is unnecessary and leads to false negatives for
XMPPTCPConnection.

For the sake of completeness, the right condition, assuming
XMPPTCPConnection is used, for the assert would be:

        assert !connected || disconnectedButResumable;
Florian Schmaus <flo@geekplace.eu> Florian Schmaus <flo@geekplace.eu> 403890d9884fac25073413aa7d8ce5238e0f7770 m 403890d9884fac25073413aa7d8ce5238e0f7770 Smack 4.4.5-SNAPSHOT