Build: #177 was successful Changes by Florian Schmaus

Build result summary


10 minutes
Default Agent
02341f6330e9b53938fba3c04f30785cee393fd1 02341f6330e9b53938fba3c04f30785cee393fd1
Total tests
Successful since
#174 ()


Code commits

Author Commit Message Commit date
Florian Schmaus Florian Schmaus 02341f6330e9b53938fba3c04f30785cee393fd1 02341f6330e9b53938fba3c04f30785cee393fd1 Smack 4.4.0-beta3-SNAPSHOT
Florian Schmaus Florian Schmaus 6837c305e86593cf968dabf4fcfd45abb1ce05ec 6837c305e86593cf968dabf4fcfd45abb1ce05ec Smack 4.4.0-beta2
Florian Schmaus Florian Schmaus 4db7d787f7e4b6e525c9482d7088f673ff795026 4db7d787f7e4b6e525c9482d7088f673ff795026 [tcp] Add code comment why we have to copy the ByteBuffer
Florian Schmaus Florian Schmaus 08fc0ba0b4ecb33e882a9f3c722f5425e8772f0d 08fc0ba0b4ecb33e882a9f3c722f5425e8772f0d [tcp] Improve pendingWriteInterestAfterRead code comment
Florian Schmaus Florian Schmaus 525ee09ea15d7843e20d2d376f343cd5fe8ab76a 525ee09ea15d7843e20d2d376f343cd5fe8ab76a [tcp] Do not send SM ack after we send a </stream:stream>
Do net put an ack to the queue if it has already been shutdown. Some
servers, like ejabberd, like to request an ack even after we have send
a stream close (and hance the queue was shutdown). If we would not
check here, then the ack would dangle around in the queue, and be send
on the next re-connection attempt even before the stream open.

See the following trace of the MUC bookmarks integration test. The
fact that it is a MUC test does not matter, but this test does
disconnect the connection and reconnect it. Not how the server,
ejabberd in this case, requests an SM ack by sending an <r/> even
though we already send the </stream:stream>:

22:22:05 SENT (4):
<iq id='MD4UC-61' type='set'>
  <query xmlns='jabber:iq:private'>
    <storage xmlns='storage:bookmarks'>
      <conference name='Smack Inttest: 7in7j' autojoin='true' jid=''>
22:22:05 RECV (4):
<r xmlns='urn:xmpp:sm:3'/>
22:22:05 SENT (4):
<a xmlns='urn:xmpp:sm:3' h='29'/>
22:22:05 RECV (4):
<message to='' from='' type='headline'>
  <event xmlns=''>
    <items node='storage:bookmarks'>
      <item id='current'>
        <storage xmlns='storage:bookmarks'>
          <conference name='Smack Inttest: 7in7j' autojoin='true' jid=''>
  <addresses xmlns=''>
    <address jid='' type='replyto'/>
22:22:05 RECV (4):
<iq xml:lang='en-US' to='' from='' type='result' id='MD4UC-61'/>
22:22:05 SENT (4):
<presence id='6MS6J-20' type='unavailable'/>
<a xmlns='urn:xmpp:sm:3' h='31'/>
<!-- We have closed the stream -->
<!-- But the server still requests an SM ack -->
22:22:05 RECV (4):
<r xmlns='urn:xmpp:sm:3'/>
22:22:05 RECV (4):
22:22:05 XMPPConnection closed (XMPPTCPConnection[] (4))
22:22:05 SENT (4):
<a xmlns='urn:xmpp:sm:3' h='31'/>
22:22:05 SENT (4):
<stream:stream xmlns='jabber:client' to='' xmlns:stream='' version='1.0' from='' xml:lang='en-US'>
22:22:05 RECV (4): ?xml version='1.0'?>
<stream:stream id='3379123514446782311' ver
22:22:05 RECV (4): sion='1.0' xml:lang='en' xmlns:stream='' xmlns='jabber:client'>
  <invalid-xml xmlns='urn:ietf:params:xml:ns:xmpp-streams'/>
22:22:05 XMPPConnection closed due to an exception (XMPPTCPConnection[] (4))
org.jivesoftware.smack.XMPPException$StreamErrorException: invalid-xml You can read more about the meaning of this stream error at
<stream:error><invalid-xml xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error>
        at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(
        at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.access$700(
        at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$
        at java.base/

Jira issues

Unknown Issue TypeMD4UC-61Could not obtain issue details from Jira

Shared artifacts

Artifact File size
Project binary files 22 MB