Build: #19 failed Manual run by daryl herzmann
Code commits
Openfire (master)
-
daryl herzmann 6958b32f3d390a4b0ac96f9a121310d72076758b
Denote Openfire 4.9.0 Release
- distribution/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- i18n/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- plugins/openfire-plugin-assembly-descriptor/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- plugins/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- starter/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- xmppserver/changelog.html (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- xmppserver/pom.xml (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/XMPPServerInfoImpl.java (version 6958b32f3d390a4b0ac96f9a121310d72076758b)
-
Guus der Kinderen caa49202de1b2ce47c43f68699cc2363b138de2d
Alphabetically order the languages
- xmppserver/src/main/webapp/server-locale.jsp (version caa49202de1b2ce47c43f68699cc2363b138de2d)
- xmppserver/src/main/webapp/setup/index.jsp (version caa49202de1b2ce47c43f68699cc2363b138de2d)
-
Guus der Kinderen f338e0b0e8b880d4bddf032df6863e33c3f75793
OF-2872: Fix XML parsing when previous buffer couldn't be fully parsed
The previous code failed to properly update the read index of the ByteBuffer that is being read, in cases where the ByteBuffer that is parsed had an initial read index higher than 0.
Through manual testing, I've observed this to fix an issue where client connections that send Cyrillic characters get disconnected with a "Stopped parsing never ending stanza" exception.- xmppserver/src/main/java/org/jivesoftware/openfire/nio/XMLLightweightParser.java (version f338e0b0e8b880d4bddf032df6863e33c3f75793)
- xmppserver/src/test/java/org/jivesoftware/openfire/nio/XMLLightweightParserTest.java (version f338e0b0e8b880d4bddf032df6863e33c3f75793)
-
Guus der Kinderen aaa05b8b16b703f26dbb3668c17b8c470456db97
OF-2867: Admin console server-session-details fix
Fixing reference to `usingServerDialback` and `usingSaslExternal` (that are no true 'properties', and thus cannot be referenced like ones).- xmppserver/src/main/webapp/server-session-details.jsp (version aaa05b8b16b703f26dbb3668c17b8c470456db97)
-
Guus der Kinderen 92505397fad9de69c17b7b3a3bfae90ffbff2f63
OF-2867: Admin console should not use removed code
This fixes a bug that occurs on the server session details page, as it was using Openfire API that is removed as part of OF-2867.- xmppserver/src/main/webapp/server-session-details.jsp (version 92505397fad9de69c17b7b3a3bfae90ffbff2f63)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 9df99285ab170c39d7a1f86d58ddc05be1277f5a
Translate openfire_i18n.properties in fa_IR [Manual Sync]
99% of minimum 99% translated source file: 'openfire_i18n.properties'
on 'fa_IR'.
Sync of partially translated files:
untranslated content is included with an empty translation
or source language content depending on file format- i18n/src/main/resources/openfire_i18n_fa_IR.properties (version 9df99285ab170c39d7a1f86d58ddc05be1277f5a)
-
daryl herzmann b8872777f517972c5c7bf273eb7c4ac82067a4cd
Merge pull request #2515 from guusdk/OF-2867_Setup-OF-49-deprecation
OF-2867: Openfire setup should not use removed code -
telvideo <75522693+telvideo@users.noreply.github.com> 346fc6cf3af2d84710410a2f867be2a4bb1ae689
OF-2869: Add Persian (fa_IR) translation
This adds a new translation to Openfire: Persian (Farsi). Many thanks to Akbar Azimifar, who provided the translation!
---------
Co-authored-by: Guus der Kinderen <guus.der.kinderen@gmail.com>- i18n/src/main/resources/openfire_i18n_fa_IR.properties (version 346fc6cf3af2d84710410a2f867be2a4bb1ae689)
- xmppserver/src/main/java/org/jivesoftware/util/LocaleUtils.java (version 346fc6cf3af2d84710410a2f867be2a4bb1ae689)
- xmppserver/src/main/webapp/server-locale.jsp (version 346fc6cf3af2d84710410a2f867be2a4bb1ae689)
- xmppserver/src/main/webapp/setup/index.jsp (version 346fc6cf3af2d84710410a2f867be2a4bb1ae689)
-
Guus der Kinderen ba2632046821f560b0ec4b147143690bcb69043c
OF-2867: Openfire setup should not use removed code
By removing deprecated code, the Openfire setup failed. Specifically, a validation that checks for some runtime configuration failed, because it no longer could identify the 'home' directory. As this implementation used Java reflection, it went below the radar until now.- xmppserver/src/main/webapp/setup/index.jsp (version ba2632046821f560b0ec4b147143690bcb69043c)
-
daryl herzmann 98989ed4fc78f75c8571053a6cf0562f49ac50d7
Merge pull request #2464 from igniterealtime/dependabot/github_actions/docker/build-push-action-6
Bump docker/build-push-action from 5 to 6 -
daryl herzmann 847bb12c8db00c3b78185c3307687345b3b6e9bb
CI: adjustments to MSSQL
- build/ci/compose/scripts/mssql.sh (version 847bb12c8db00c3b78185c3307687345b3b6e9bb)
-
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> ae34f5069c6c3e7fbe554054dbe1b5c46eb7a098
Bump docker/build-push-action from 5 to 6
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v5...v6)
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>- .github/workflows/continuous-integration-workflow.yml (version ae34f5069c6c3e7fbe554054dbe1b5c46eb7a098)
-
Dan Caseley d1075610b89b60df185ce56f17a9398b09c7c406
OF-2863: CI - Update docker compose command to match GHA runners
- .github/workflows/continuous-integration-workflow.yml (version d1075610b89b60df185ce56f17a9398b09c7c406)
-
daryl herzmann b1410aa53e10579a8bec50511de7a4ca6887a78d
Merge pull request #2513 from guusdk/updater-fixes
Fixes to 'updater' for Openfire 4.9.0 -
Guus der Kinderen a06449c517f1cdddd6c8ed9ad53acfeaf7416a0d
Fixes to 'updater' for Openfire 4.9.0
- build/ci/updater/src/main/java/com/igniterealtime/openfire/updaterunner/Main.java (version a06449c517f1cdddd6c8ed9ad53acfeaf7416a0d)
- build/ci/updater/src/main/java/com/igniterealtime/openfire/updaterunner/PropertiesReader.java (version a06449c517f1cdddd6c8ed9ad53acfeaf7416a0d)
-
daryl herzmann a51e1c472877156fff7b1638681726f6ed7fc0a5
Merge pull request #2511 from guusdk/OF-2867_Remove-deprecated-code
Remove code marked for deprecation in 4.9.0 or later -
Guus der Kinderen 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae
Remove code marked for deprecation in 4.9.0 or later
Code that was marked for removal in version 4.9.0 should be removed.
Note that we shouldn’t remove code when the mark was applied in versions 4.8.1 or later. In those cases, lets bump up the removal to the next minor version (4.10.0). This allows developers to have one ‘full’ release cycle to be aware of deprecation, and adjust their code accordingly.- xmppserver/src/main/java/org/jivesoftware/openfire/Connection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/RoutingTable.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/SessionPacketRouter.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/commands/SessionData.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/component/ExternalComponentManager.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginManager.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpConnection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketConnection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketReader.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketReadingMode.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/VirtualConnection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/nio/NettyConnection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalSession.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteSession.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteSessionTask.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/Session.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketClientConnectionHandler.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/WebSocketConnection.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/util/JiveConstants.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/util/JiveGlobals.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/util/TaskEngine.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
- xmppserver/src/main/java/org/jivesoftware/util/cache/CacheFactory.java (version 12d212f5a9fc0f3c7df887537b3f5c64fbfacbae)
-
daryl herzmann 8144b2611667d43f916c5464922cf5495ac8856f
Merge pull request #2506 from guusdk/OF-2860_MUCRole-rename-nonbreaking
OF-2860: The non-breaking changes leading up to renaming the class MUCRole -
daryl herzmann b1b5b5d274a978d0e8691f5d1f1704512b89b18d
Merge pull request #2509 from guusdk/OF-2864_Deprecate-custom-base64
OF-2864: Deprecate org.jivesoftware.util.Base64 -
Guus der Kinderen c131aa1ce493895c41baa4edb85c33dcf8e3ea22
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MultiUserChatService#getMUCRoles`
Marks `org.jivesoftware.openfire.muc.MultiUserChatService#getMUCRoles` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MultiUserChatService#getOccupants` and refactors all known users from the old to the new method.
In 4.10.0, the replacement method's API will change, which will require users to refactor their code potentially twice (if they choose to use the replacement method prior to 4.10.0).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version c131aa1ce493895c41baa4edb85c33dcf8e3ea22)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version c131aa1ce493895c41baa4edb85c33dcf8e3ea22)
-
Guus der Kinderen 4100e7bf5f052d374b9ab8c6641424489b5bb572
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MUCRoom#addOccupantRole`
Marks `org.jivesoftware.openfire.muc.MUCRoom#addOccupantRole` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MUCRoom#addOccupant` and refactors all known users from the old to the new method.
In 4.10.0, the replacement method's API will change, which will require users to refactor their code potentially twice (if they choose to use the replacement method prior to 4.10.0).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 4100e7bf5f052d374b9ab8c6641424489b5bb572)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 4100e7bf5f052d374b9ab8c6641424489b5bb572)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoomManager.java (version 4100e7bf5f052d374b9ab8c6641424489b5bb572)
-
Guus der Kinderen 6fa48edaf31dd2532f59fe0154658b1fc6e34ed0
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MUCRoom#removeOccupantRole`
Marks `org.jivesoftware.openfire.muc.MUCRoom#removeOccupantRole` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MUCRoom#removeOccupant` and refactors all known users from the old to the new method.
In 4.10.0, the replacement method's API will change, which will require users to refactor their code potentially twice (if they choose to use the replacement method prior to 4.10.0).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 6fa48edaf31dd2532f59fe0154658b1fc6e34ed0)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version 6fa48edaf31dd2532f59fe0154658b1fc6e34ed0)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoomManager.java (version 6fa48edaf31dd2532f59fe0154658b1fc6e34ed0)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 6fa48edaf31dd2532f59fe0154658b1fc6e34ed0)
-
Guus der Kinderen c7a0214d0d3a064886695808cbc9e33834137103
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MUCRole#getRoleAddress`
Marks `org.jivesoftware.openfire.muc.MUCRole#getRoleAddress` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MUCRole#getOccupantJID` and refactors all known users from the old to the new method.
The name 'Occupant JID' reflects how the XEP refers to this data.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoomHistory.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoomManager.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/java/org/jivesoftware/util/cache/ConsistencyChecks.java (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version c7a0214d0d3a064886695808cbc9e33834137103)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/MUCRoleTest.java (version c7a0214d0d3a064886695808cbc9e33834137103)
-
Guus der Kinderen f047eb2b305768ce14166c849383b205d07fcdd5
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MUCRole#createRoomRole`
Marks `org.jivesoftware.openfire.muc.MUCRole#createRoomRole` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MUCRole#createRoomSelfRepresentation` and refactors all known users from the old to the new method.
In 4.10.0, the replacement method's API will change, which will require users to refactor their code potentially twice (if they choose to use the replacement method prior to 4.10.0).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version f047eb2b305768ce14166c849383b205d07fcdd5)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version f047eb2b305768ce14166c849383b205d07fcdd5)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version f047eb2b305768ce14166c849383b205d07fcdd5)
-
Guus der Kinderen 96184c70175694e73cb45d3447879f033dbc7e04
OF-2860: Deprecate `org.jivesoftware.openfire.muc.MUCRoom#getRole()`
Marks `org.jivesoftware.openfire.muc.MUCRoom#getRole()` for removal in 4.10.0.
This introduces a replacement method: `org.jivesoftware.openfire.muc.MUCRoom#getSelfRepresentation()` and refactors all known users from the old to the new method.
In 4.10.0, the replacement method's API will change, which will require users to refactor their code potentially twice (if they choose to use the replacement method prior to 4.10.0).- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCEventDelegate.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoomHistory.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQAdminHandler.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQMUCRegisterHandler.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQOwnerHandler.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoomManager.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/webapp/muc-room-affiliations.jsp (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 96184c70175694e73cb45d3447879f033dbc7e04)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/MUCRoomTest.java (version 96184c70175694e73cb45d3447879f033dbc7e04)
-
daryl herzmann ab537c1b08492720c270ac4e024a9f996c93c78c
Merge pull request #2463 from guusdk/OF-2830_PluginServlet-mapping
OF-2830 plugin servlet mapping -
daryl herzmann e6a3fd5e308660f71080a465a81fa523f4fa31b3
Merge pull request #2502 from guusdk/mvn-warnings-install4j
OF-2857: Replace Install4j runtime library -
daryl herzmann 67a1cdd4fb07e908ec57e845beb34755c1d632ca
Merge pull request #2501 from guusdk/mvn-warnings
Fix Maven warnings for distribution module -
Guus der Kinderen 71bb0488b2027bc7a1db0d4a16379f89a375cfda
OF-2864: Mark as deprecated in 4.9, remove in 4.10
- xmppserver/src/main/java/org/jivesoftware/util/Base64.java (version 71bb0488b2027bc7a1db0d4a16379f89a375cfda)
- xmppserver/src/main/java/org/jivesoftware/util/StringUtils.java (version 71bb0488b2027bc7a1db0d4a16379f89a375cfda)
-
Guus der Kinderen 9a007d2a83d571febe176f0a8d5003141dea43cd
OF-2864: Deprecate org.jivesoftware.util.Base64
Marked `org.jivesoftware.util.Base64` as deprecated, replaced all usage with `java.util.Base64`.
This replaces customer code with code provided by Java itself, reducing the maintenance load.- xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQMUCvCardHandler.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/RespondingServerStanzaHandler.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/SASLAuthentication.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/streammanagement/StreamManager.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/openfire/vcard/PhotoResizer.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/util/AesEncryptor.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/util/Base64.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/java/org/jivesoftware/util/StringUtils.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/webapp/login.jsp (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/main/webapp/system-clustering.jsp (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/KeystoreTestUtils.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/test/java/org/jivesoftware/openfire/sasl/ScramSha1SaslServerTest.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
- xmppserver/src/test/java/org/jivesoftware/openfire/session/RemoteInitiatingServerDummy.java (version 9a007d2a83d571febe176f0a8d5003141dea43cd)
-
Guus der Kinderen e552553333a6b6fb5cc24120c3a4332ba00c036b
OF-2860: Rename MUCRole variables
In preparation of the renaming of the MUCRole class, this commit renames all variables (and some comments / log messages). This aims to explicitly distinguish between the XEP-defined term 'role' and the usage of MUCRole, which is now mostly referenced as 'occupant'.
This commit is not supposed to introduce any functional change.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/HistoryRequest.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoomHistory.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/FMUCHandler.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQAdminHandler.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQOwnerHandler.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoomManager.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/java/org/jivesoftware/util/cache/ConsistencyChecks.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/main/webapp/muc-room-occupants.jsp (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/MUCRoomTest.java (version e552553333a6b6fb5cc24120c3a4332ba00c036b)
-
Guus der Kinderen 3b823f851987255b5d85e0c55b1531b8b82b81bf
OF-2858: Fix error condition for MUC PM
When sending a private message to a user that's not an occupant of the room, XEP-0045 section 7.5 defines that a different error condition is to be used than the one that Openfire has been using. This commit corrects the error condition.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 3b823f851987255b5d85e0c55b1531b8b82b81bf)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 2608e1205573b37b6a24d078e40dce7111cdd0d3
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 2608e1205573b37b6a24d078e40dce7111cdd0d3)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 1a4a8c8eee1e866c76c5c7f50d841284cf658e9c
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 1a4a8c8eee1e866c76c5c7f50d841284cf658e9c)
-
Guus der Kinderen 56b1baa974bfe639adb7adc5bc344a6c8c5d1c0b
OF-2857: Replace Install4j runtime library
This replaces the bundled install4j runtime library with one the is obtained from the author's Maven repository.
By no longer bundling the library, a nasty Maven warning that was shown during build disappears.
The replacement library is significantly newer than the original (the old version was never published in a Maven repository).
As a result:
- functional changes might have been introduced
- the Uninstall action that is part of Openfire source code was rewritten
The version that's used now is the same version as the version of Install4j that is used in Bamboo to generate the installers.- starter/libs/README.txt (version 56b1baa974bfe639adb7adc5bc344a6c8c5d1c0b)
- starter/libs/i4jruntime.jar (version 56b1baa974bfe639adb7adc5bc344a6c8c5d1c0b)
- starter/pom.xml (version 56b1baa974bfe639adb7adc5bc344a6c8c5d1c0b)
- starter/src/main/java/org/jivesoftware/openfire/launcher/Uninstaller.java (version 56b1baa974bfe639adb7adc5bc344a6c8c5d1c0b)
-
Guus der Kinderen ec3cd3b8bdf788e5f78e46e8a4c1b35728c15ec1
OF-2856: Avoid attempting to attach a directory to the project
The distribution-base artifact is a directory. Maven cannot attach directories to the project.
This commit overrides the default of 'attach the assembled artifact' to 'false'.- distribution/pom.xml (version ec3cd3b8bdf788e5f78e46e8a4c1b35728c15ec1)
-
Guus der Kinderen b6bcf067ab708769c65284a14e9ebf9598c9cb4b
OF-2855: Replace non-cross platform file system reference in assembly
This replaces a unix file system reference (`/`) with a Maven variable. As a result, the correct reference should be used on any platform on which Openfire is build.- distribution/src/assembly/basic-distribution.xml (version b6bcf067ab708769c65284a14e9ebf9598c9cb4b)
-
Guus der Kinderen ad1eef1821dadf30a72a5ec953be86d1d6620b79
OF-2854: Package of distribution module changed to 'pom'
The distribution module is a metadata module; it does not contain any resources that are directly to be exposed as an artifact (instead, it uses the Assembly and Install4J plugins to generate artifacts).
The module had the package type of 'jar', indicating that a jar artifact was to be produced. This resulted in an empty `distribution.jar` file to be generated.
By switching to the `pom` package type, this no longer is the case.- distribution/pom.xml (version ad1eef1821dadf30a72a5ec953be86d1d6620b79)
-
Guus der Kinderen 9fbe875827d9150f5ab1a225908ba03bb6a6d76d
New Unit test that verify the implementation of ScramSha1SaslServer
- xmppserver/src/test/java/org/jivesoftware/openfire/sasl/ScramSha1SaslServerTest.java (version 9fbe875827d9150f5ab1a225908ba03bb6a6d76d)
-
Guus der Kinderen d882efa465a9fe1ba8e5a86ee90491844a254b11
New Unit test that verify the implementation of ScramUtils
- xmppserver/src/test/java/org/jivesoftware/openfire/auth/ScramUtilsTest.java (version d882efa465a9fe1ba8e5a86ee90491844a254b11)
-
Guus der Kinderen c169651106d50097b481298e4d261c59c3db50ca
OF-2830: PluginServlet refactoring + unit tests
This adds unit tests that assert the problems identified in OF-2830. To facilitate unit tests, some refactoring of the code under test was needed. This does not intend to introduce functional changes.- xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java (version c169651106d50097b481298e4d261c59c3db50ca)
- xmppserver/src/test/java/org/jivesoftware/openfire/container/PluginServletTest.java (version c169651106d50097b481298e4d261c59c3db50ca)
-
Guus der Kinderen 95d40f625445152de82f8fd41e134ac4ed38762e
OF-2830: Fix wildcard mapping for plugin servlets
This replaces the pre-existing matching implementation of URLs (that may contain wildcards) with one that is more robust (and passes the unit tests introduced by the previous commit).- xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java (version 95d40f625445152de82f8fd41e134ac4ed38762e)
-
daryl herzmann 78a5afa988369783afc5c638ea538b02c7f2098d
skip test_set_topic aioxmpp test, for now
- .github/workflows/continuous-integration-workflow.yml (version 78a5afa988369783afc5c638ea538b02c7f2098d)
-
daryl herzmann bd2d0b7648e33c6cc8c8cb775e4415e5fa7a142f
test: enable all-but-three aioxmpp tests
- .github/workflows/continuous-integration-workflow.yml (version bd2d0b7648e33c6cc8c8cb775e4415e5fa7a142f)
-
daryl herzmann 82d5495b22ec828d937ecd3fd428820e3e2feb15
update aioxmpp repo to codeberg
- .github/workflows/continuous-integration-workflow.yml (version 82d5495b22ec828d937ecd3fd428820e3e2feb15)
-
Guus der Kinderen ffd001d4e34e7ca7619b0426bc1ceba297a86d7b
OF-2848: Ensure `<destroy/>` element in presence unavailabe when MUC is destroyed
Prior to this change, this element was present only when one of the optional attributes was provided.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version ffd001d4e34e7ca7619b0426bc1ceba297a86d7b)
-
Wentao Chang <wentao.chang@activenetwork.com> 183ae8777e871e0ea4741017c526d65026bd865e
Fixed: fix memory usage status bar issue.
- xmppserver/src/main/webapp/system-clustering.jsp (version 183ae8777e871e0ea4741017c526d65026bd865e)
-
daryl herzmann 446a66a76b5f546116ce1b961c191a7d1e01ccc3
Merge pull request #2490 from guusdk/OF-2843_OF-2844_MUC-ban
OF-2843 & OF-2844: MUC ban improvements -
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 5d5eb75b3939b067b9a37772ffbb865c49da7661
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 5d5eb75b3939b067b9a37772ffbb865c49da7661)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 4b2095f4fe5b3a777a16366ccd5cdb788edfd289
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 4b2095f4fe5b3a777a16366ccd5cdb788edfd289)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> d9910c13cfd65dafa12462e4989bd22e6c447c8d
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version d9910c13cfd65dafa12462e4989bd22e6c447c8d)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> f7950e18955de87b9dd9fbdd5f1b6040c30f9b97
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version f7950e18955de87b9dd9fbdd5f1b6040c30f9b97)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> af3ab65cc7f53ddf0209b96b883cf8cf758f5dd4
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version af3ab65cc7f53ddf0209b96b883cf8cf758f5dd4)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> b6ca856c0b3c76184ee1f6d1d90f3c37e9c19ff3
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version b6ca856c0b3c76184ee1f6d1d90f3c37e9c19ff3)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 96e0e1106a1197ce76bb090c0454445a4f4267a3
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 96e0e1106a1197ce76bb090c0454445a4f4267a3)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 9887f90eb40059532d84737afe91ef9363e413b6
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 9887f90eb40059532d84737afe91ef9363e413b6)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 43b3b951ad919892ca02b8d147c478f8931d92b3
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 43b3b951ad919892ca02b8d147c478f8931d92b3)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> 16d307b208a21dbeaca74168d40d3c9d6c07e974
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version 16d307b208a21dbeaca74168d40d3c9d6c07e974)
-
transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> f64e87460a67ee6b38117e856730e13166f135a1
Translate openfire_i18n.properties in zh_CN
100% translated source file: 'openfire_i18n.properties'
on 'zh_CN'.- i18n/src/main/resources/openfire_i18n_zh_CN.properties (version f64e87460a67ee6b38117e856730e13166f135a1)
-
Guus der Kinderen acc16bd64176de9a619187df572f489d3e2c9ac9
OF-2845: Countdown latch on connection close exception
This should prevent connections from having to wait for a 10-minute timeout when an exception occurs while trying to invoke the close listeners.- xmppserver/src/main/java/org/jivesoftware/openfire/nio/NettyConnection.java (version acc16bd64176de9a619187df572f489d3e2c9ac9)
-
Guus der Kinderen 97a3212049efe1c50ef42abc03e34f31f11e8ed2
OF-2843 & OF-2844: MUC ban improvements
An admin cannot ban an owner from a MUC room. XEP-0045 section 9.1 specifies:
> [A] user cannot be banned by an admin with a lower affiliation. Therefore, if an admin attempts to ban an owner, the service MUST deny the request and return a `<not-allowed/>` error to the sender
Openfire currently does send an error, but uses the `<conflict/>` condition. Instead, it must use the `<not-allowed/>` condition as specified by the XEP.
XEP-0045 Section 9.1 defines:
> If an admin or owner attempts to ban himself, the service MUST deny the request and return a `<conflict/>` error to the sender. (Note: This is different from the recommended service behavior on kicking oneself.)
Openfire currently allows admins to ban themselves. That should not be possible, as defined by the XEP.- i18n/src/main/resources/openfire_i18n.properties (version 97a3212049efe1c50ef42abc03e34f31f11e8ed2)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 97a3212049efe1c50ef42abc03e34f31f11e8ed2)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQAdminHandler.java (version 97a3212049efe1c50ef42abc03e34f31f11e8ed2)
-
daryl herzmann fceff57a3d6e89db8c8d5179cd6ffb5e004c8919
Merge pull request #2486 from guusdk/OF-2825_redux
OF-2825: Moved implementation of Service Discovery security considerations to individual providers -
daryl herzmann 019c894e9dfabadf868802ee82788578823e26bb
Merge pull request #2487 from guusdk/OF-2841_CAPS-user-specific
OF-2841: Make CAPS advertised on Stream user specific -
Guus der Kinderen 65426614ad314c435f745c7ce09abec92270bce8
OF-2841: Make CAPS advertised on Stream user specific
Registered users can get different features from the server than non-registered users. This should be expressed in the advertised CAPS.- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version 65426614ad314c435f745c7ce09abec92270bce8)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 65426614ad314c435f745c7ce09abec92270bce8)
-
Guus der Kinderen 7e64141a6ce8de6213d3701fe582014068202438
OF-2825: Moved implementation of Service Discovery security considerations to individual providers
Instead of applying the security considerations of section 8, XEP-0030 globally, they now are applied to the individual discovery data providers. This prevents them to be applied to providers where they do not apply (eg: MUC, that doesn't apply presence subscription based authorization at all).- xmppserver/src/main/java/org/jivesoftware/openfire/disco/DiscoInfoProvider.java (version 7e64141a6ce8de6213d3701fe582014068202438)
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version 7e64141a6ce8de6213d3701fe582014068202438)
- xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version 7e64141a6ce8de6213d3701fe582014068202438)
-
daryl herzmann d2b583cc0e50adf73c67af37686a6f5a6206c602
ci: ensure aioxmpp test failure fails
- .github/workflows/continuous-integration-workflow.yml (version d2b583cc0e50adf73c67af37686a6f5a6206c602)
-
daryl herzmann 3e0f992c3a55ff56f0087ce27da6108e93242ba1
Merge pull request #2483 from guusdk/OF-2825_Fix-for-self
OF-2825: Allow self to query for disco#info -
Guus der Kinderen da92f1c66d82f1d547a8c39abc601bf0e9c6906e
OF-2825: Allow self to query for disco#info
The previous fix for OF-2825 erroneously prevented a user to query for its own disco#info.- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version da92f1c66d82f1d547a8c39abc601bf0e9c6906e)
-
daryl herzmann 4f7666117875312e7b31d1229c9d9c38d3323366
Merge pull request #2467 from guusdk/OF-2834_bouncycastle-update
OF-2834: Bump BouncyCastle from 1.76 to 1.78.1 -
daryl herzmann 75b32e457f59ac3fafc391ae895ea96e09ad010d
Merge pull request #2479 from guusdk/OF-2840_XMPPDateTimeFormat-parsing
OF-2840: Minor improvements to XMPPDateTimeFormat parsing -
Guus der Kinderen 78dc4192a4fc8b74528247999b865c2d5692fd81
OF-2840: Minor improvements to XMPPDateTimeFormat parsing
Parsing should return null values (rather than throw an Exception) when null or empty values input values are used (to be more fault-tolerant).
A parsing exception's message should include the offending value (to help diagnostics).- xmppserver/src/main/java/org/jivesoftware/util/XMPPDateTimeFormat.java (version 78dc4192a4fc8b74528247999b865c2d5692fd81)
- xmppserver/src/test/java/org/jivesoftware/util/XMPPDateTimeFormatTest.java (version 78dc4192a4fc8b74528247999b865c2d5692fd81)
-
Guus der Kinderen 3a32ce998f9c151c9fcb99951d3a1174fb9a8783
OF-2814: Ensure that multi-byte characters in the XMPP data are parsed properly
Prioer to this change, parsing errors occurred when multi-byte characters where provided to the parser byte-by-byte (or in byte arrays where a multi-byte character was split over more than one byte array).
This commit re-introduces the fix for this problem that was created under OF-458. It uses a CharsetDecoder that will only read 'enough' bytes from an array, leaving bytes that form an incomplete character in the byte array (to be processed in the next iteration, when hopefully more data was added).
The original fix is refactored a little to account for the different API that is provided by Netty (as compared to the old MINA based code), and to facilitate unit testing (of which a couple are added).- xmppserver/src/main/java/org/jivesoftware/openfire/nio/NettyXMPPDecoder.java (version 3a32ce998f9c151c9fcb99951d3a1174fb9a8783)
- xmppserver/src/main/java/org/jivesoftware/openfire/nio/XMLLightweightParser.java (version 3a32ce998f9c151c9fcb99951d3a1174fb9a8783)
- xmppserver/src/test/java/org/jivesoftware/openfire/nio/XMLLightweightParserTest.java (version 3a32ce998f9c151c9fcb99951d3a1174fb9a8783)
-
Guus der Kinderen eed8ba82e313e3589d7d0e18bfe18415b17a4ad8
OF-2834: Bump BouncyCastle from 1.76 to 1.78.1
The OWASP dep-scan tool (https://github.com/owasp-dep-scan/dep-scan) has identified various CVEs related to the version of the BouncyCastle dependency that we're currently using. This commit updates the library to resolve that issue.- pom.xml (version eed8ba82e313e3589d7d0e18bfe18415b17a4ad8)
-
Guus der Kinderen 4daaf50e05dfd1b90f3749ab1a995e84e04dcc15
OF-2833: Fix serialization of User when date properties are null
Since OF-2768, various 'date'-based properties of the User class are more likely to be null (especially in context of LDAP/AD).
In this commit, a serialization issue is fixed that is triggered by these null-values.- xmppserver/src/main/java/org/jivesoftware/openfire/user/User.java (version 4daaf50e05dfd1b90f3749ab1a995e84e04dcc15)
-
Guus der Kinderen 009019b7edc72a577b82f9f2b051a01ae3fcde89
OF-2832: When merging data, handle null values
When merging VCard data, if either the left-hand or right-hand side data is null, simply return the other bit. The code already did this in one direction, but now does it for the other direction too.
This allows a VCard for a non-existing user to be set (which fixes setting avatars for MUC rooms).- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version 009019b7edc72a577b82f9f2b051a01ae3fcde89)
-
Guus der Kinderen 1a7c4fd96ba690e6005225fb8aaddaed10044d5b
LDAP: reduce log verbosity when requesting data for unknown user.
- xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version 1a7c4fd96ba690e6005225fb8aaddaed10044d5b)
-
Guus der Kinderen 07ecd07ad87a2b09863cabdb6d02c05da261317c
OF-2827: JDBCAuthProvider should not lowercase/trim provided username
By lowercasing the input, a username with a capital letter can't be used.
The closely related JDBCUserProvider does not lowercase/trim values. It is probably best that both providers treat usernames in the same way.- xmppserver/src/main/java/org/jivesoftware/openfire/auth/JDBCAuthProvider.java (version 07ecd07ad87a2b09863cabdb6d02c05da261317c)
-
Guus der Kinderen 00c88addd5fa8541b0318258bee4693d15d17142
OF-2838: Return error when updating someone else's VCard
Instead of silently ignoring such a request, return an error, as mandated by the XEP.- i18n/src/main/resources/openfire_i18n.properties (version 00c88addd5fa8541b0318258bee4693d15d17142)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 00c88addd5fa8541b0318258bee4693d15d17142)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQvCardHandler.java (version 00c88addd5fa8541b0318258bee4693d15d17142)
-
Guus der Kinderen 7c52305534bd493ce1a3054c7ad32153976b7716
Minor VCard improvements
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQvCardHandler.java (version 7c52305534bd493ce1a3054c7ad32153976b7716)
-
Guus der Kinderen 2759a5c642c799251cf6ce7115dae5aaefddb93f
OF-2839: Return error when non-existing VCard is requested.
When requesting a VCard from someone else, XEP-0054 (version 1.2) section 3.3 defines:
> If no vCard exists [...] the server MUST return a stanza error,
Furthermore:
> If no vCard exists or the user does not exist, the server MUST return a stanza error, which SHOULD be either <service-unavailable/> or <item-not-found/> (but the server MUST return the same error condition in both cases to help prevent directory harvesting attacks).
Finally, RFC 6121 section 8.5.1 defines:
> If the user account identified by the 'to' attribute does not exist, how the stanza is processed depends on the stanza type. For an IQ stanza, the server MUST return a <service-unavailable/> stanza error to the sender.
Openfire currently does not return an error, but an empty VCard. This is allowable when requesting one’s own VCard, but not when requesting that of others.
Instead, Openfire must return an error with the service-unavailable condition when someone is requesting a VCard that doesn’t exist, from an existing user.
Note that Openfire already returns service-unavailable when an IQ request is sent to a non-existing user.- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQvCardHandler.java (version 2759a5c642c799251cf6ce7115dae5aaefddb93f)
-
Guus der Kinderen fcca17d42db26927113e4944b9658e5303bc15be
Apply IDE suggestions
Minor, non-functional changes suggested by the IDE (spelling, non-needed code, etc).- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version fcca17d42db26927113e4944b9658e5303bc15be)
-
Guus der Kinderen b3f6919dd04afed190182e0807f89b68332f3983
OF-2835: Openfire should advertise CAPS support
As Openfire supports CAPS (it calculates a hash for its own service discovery information), advertise support through service discovery.- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version b3f6919dd04afed190182e0807f89b68332f3983)
-
Guus der Kinderen 303369d0eb078bc4c5bd0e6e44bed0917ad3df80
OF-2836: CapsManager should use provided algorithm
Use the provided algorithm for entity capability calculation, rather than assuming that it's `SHA-1`.- xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version 303369d0eb078bc4c5bd0e6e44bed0917ad3df80)
-
Guus der Kinderen 76b8b7f62f32bfbef8d7526b49324762678565c3
OF-2825: Implement XEP-0030's security considerations
Service Discovery's section 8 describes some security considerations that Openfire must implement.
These security considerations partially contradict what's defined in RFC-6121 8.5.1. To allow for that implementation to be applied differently, this commit refactors the code to allow for an override of the original implementation of the 'no-such-user' handling.- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version 76b8b7f62f32bfbef8d7526b49324762678565c3)
- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoItemsHandler.java (version 76b8b7f62f32bfbef8d7526b49324762678565c3)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQHandler.java (version 76b8b7f62f32bfbef8d7526b49324762678565c3)
-
Guus der Kinderen 4570e79b926538fb137f8b1a00dff10b10f57b37
Add code comment explaining re-entrant lock usage
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 4570e79b926538fb137f8b1a00dff10b10f57b37)
-
Guus der Kinderen 1e109775535b8c8c97d51843501cbec2ee8e95f9
Fixed a typo
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 1e109775535b8c8c97d51843501cbec2ee8e95f9)
-
Guus der Kinderen 3c7a0c684939ca5738868689360d22cb3583904a
OF-2824: Remove cluster-cache optimization
It is suspected that, under race conditions, the optimization removed by this commit introduces data inconsistency.
The optimization prevents modification of a second cache, as through the output of manipulation of the first cache it can be deduced that the second cache should already be in the expected state. By skipping manipulation of that second cache, a cluster-wide operation is prevented, which improves performance.
The presence-based override for the optimization - one that I frankly do not understand - becomes obsolete by this change, and is also removed.
The change introduced by this commit trades performance for more reliable data consistency. As an added benefit, the code becomes less complex, reducing maintenance costs.
This commit changes the public signature of the `addClientRoute` method of `RoutingTable`: it no longer returns a value. The return value is currently not used by Openfire's own code. It was used for only two days, back in 2007: it was introduced in commit a940eeff4f72e4e9da70fcd0b4a1db1b3c40cd8d where it was used to update a statistic. This statistic got removed two days later, in commit 67f9ab65c36b8a38f5ab7c480415897839da21f0. Given the nature of the code (RoutingTable being _very_ low level), it is not expected that third-party code uses this method. It contract change should therefor be reasonably safe to do.- xmppserver/src/main/java/org/jivesoftware/openfire/RoutingTable.java (version 3c7a0c684939ca5738868689360d22cb3583904a)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 3c7a0c684939ca5738868689360d22cb3583904a)
-
Guus der Kinderen 4e0e4829dd0e299092664139bb23db6bf654240d
OF-2824: Annotate ClientSession's address to be a _full_ JID
Any Session's address is non-null, but _client_ sessions also are guarenteed to be full JIDs (in other words: they have a non-null resource part).
This commit explicitly checks for this (to fail fast on any current and future bugs), and removes unneeded checks on usage. This intends to reduce code maintenance costs, by having less complex code.
It is not expected that this change will introduce runtime changes (as the values already are full JIDs).- xmppserver/src/main/java/org/jivesoftware/openfire/RoutingTable.java (version 4e0e4829dd0e299092664139bb23db6bf654240d)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 4e0e4829dd0e299092664139bb23db6bf654240d)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 4e0e4829dd0e299092664139bb23db6bf654240d)
-
Guus der Kinderen 30ab578e48227a8b2b7de165f690de980a8f528b
OF-2824: Relax introduced fail-fast behavior
In commit ef582e131f41bcb61bfb75c083986b92b0bcd002 fail-fast behavior was introduced that causes exceptions to be thrown when certain methods are invoked using a bare JID while the expected argument is a full JID.
For certain lookups, these unexpected bare JIDs appear to be used all the time, causing Openfire to become pretty unusable.
In this commit, the invocations that do not _modify_ cache content are short-circuited when a bare JID argument is used. This has the benefit of preventing the acquisition of a cluster-wide lock.- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 30ab578e48227a8b2b7de165f690de980a8f528b)
-
Guus der Kinderen 417657b7e296a458bc140a760956a351c74c7c61
OF-2824: Annotate Session's address to be non-null
Any Session's `address` property is expected to be non-null by the existing implementation. One notable exemption to this is `RemoteIncomingServerSession`, where the address _field_ is lazily initialized (and thus _can_ be null). Its getter value is guaranteed to be non-null though.
This commit annotates and asserts that various Session address fields, getters and setters to have non-null values.
The intention of this change is to simplify implementations (by dropping unneeded null-checks), more strictly document expected state (for easier maintenance) and introduce fail-fast behavior (that should help catch any current or future bugs).
It is not expected that this change will introduce runtime changes (as the values already are non-null).- xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version 417657b7e296a458bc140a760956a351c74c7c61)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalSession.java (version 417657b7e296a458bc140a760956a351c74c7c61)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteIncomingServerSession.java (version 417657b7e296a458bc140a760956a351c74c7c61)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/RemoteSession.java (version 417657b7e296a458bc140a760956a351c74c7c61)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/Session.java (version 417657b7e296a458bc140a760956a351c74c7c61)
-
Guus der Kinderen 67108eddd2346099eab7cd4081286548c8bf3d70
OF-2824: Manipulation of client-related caches in RoutingTable using the same lock
RoutingTableImpl has three closely related caches, that are used to represent the state of client session routes:
- `usersSessionsCache`
- `anonymousUsersCache`
- `usersCache`
Each value in the first cache is expected to correspond to a value in one of the other two caches.
Under OF-2824, a bug is described where `usersCache` contains values that are _not_ in `usersSessionsCache`. That shouldn't be possible.
Prior to this commit, manipulation of these caches is performed under a lock obtained from each of the caches. This means that the overall operation of adding an entry to `usersSessionsCache` and one of the other two caches is _not_ guarded by one singular lock (instead, two locks are used, each guarding the operation pertaining to that particular cache). This leaves room for a race-condition.
This commit addresses the race condition by using one singular lock to guard manipulations in all of these caches.
As all caches use a JID (in either bare or full form) as their key value, the singular lock introduced by this commit is based on the bare JID of the key that's being manipulated. This lock is obtained from the `usersSessionsCache`.
This change can lead to more lock contention (as more operations are guarded by the same lock). Simultaneously, less acquiring of locks will take place (as many operations previously required two locks to be acquired, while now, only one is needed. What the effects are on performance is as of yet undetermined.
This commit also introduces some related, minor changes:
- Logged messages are made more consistent
- Some operations have been moved outside of the protection of a (potentially cluster-wide) lock, to improve performance
- Where methods expect to be called with a full JID, exceptions are thrown when a bare JID is used. This fail-fast behavior is intended to uncover any existing or future bugs.- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 67108eddd2346099eab7cd4081286548c8bf3d70)
-
daryl herzmann 11f1e40a1bedcfa1100e11c31b365fb194f72d00
Merge pull request #2462 from igniterealtime/dependabot/github_actions/korthout/backport-action-3
Bump korthout/backport-action from 2 to 3 -
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 23babdefdd62407107fbd5cba45ce9f9be48fada
Bump korthout/backport-action from 2 to 3
Bumps [korthout/backport-action](https://github.com/korthout/backport-action) from 2 to 3.
- [Release notes](https://github.com/korthout/backport-action/releases)
- [Commits](https://github.com/korthout/backport-action/compare/v2...v3)
---
updated-dependencies:
- dependency-name: korthout/backport-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>- .github/workflows/backport.yml (version 23babdefdd62407107fbd5cba45ce9f9be48fada)
-
Guus der Kinderen a8f983fce12bf66bcce6c29e382255d21a1696b4
OF-2818: Netty should not use 5MB buffers (#2455)
This corrects a mistake where a configuration of having a _maximum_ buffer size was turned into having a _fixed_ buffer size.
Having 5MB buffers is bad, as with a limited amount of messages, a _lot_ of memory is being consumed.
This commit removes the hard-coded buffer size configuration, while retaining the maximum message length directive.
I've tested that, using a websocket client connection:
- a message of 128k characters can be sent using the default configuration;
- a message of 128k characters can not be sent when Openfire is reconfigured to use 4k for the `xmpp.parser.buffer.size` property- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/OpenfireWebSocketServlet.java (version a8f983fce12bf66bcce6c29e382255d21a1696b4)
-
Dan Caseley 56917ef9b8ec716bb822bcee96071c73ce7d87ae
OF-2819: Update Netty from 4.1.100 to 4.1.108
- pom.xml (version 56917ef9b8ec716bb822bcee96071c73ce7d87ae)
-
Guus der Kinderen 35ffe5ce47614938c1882c4d739b0cab72840758
OF-2676: add XEP-0478 to DOAP
Advertise that Openfire has partial support for XEP-0477.- documentation/openfire.doap (version 35ffe5ce47614938c1882c4d739b0cab72840758)
-
Guus der Kinderen b61b28c309d28d6c1e3752c1f70cb572d4755dd5
Update documentation/openfire.doap
Co-authored-by: Kim Alvefur <zash@zash.se>- documentation/openfire.doap (version b61b28c309d28d6c1e3752c1f70cb572d4755dd5)
-
Guus der Kinderen 979fda50712d0a355e03593802c1c4cf144b8977
OF-2816: i18n Hebrew update
More translations from Schimon. Translation is now 54.64% complete.- i18n/src/main/resources/openfire_i18n_he.properties (version 979fda50712d0a355e03593802c1c4cf144b8977)
-
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 928e29634f567ab5496c8cc081725405dbb8209d
Bump junit:junit in /.github/actions/connectivitytests-action/conntest (#2449)
Bumps [junit:junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1)
---
updated-dependencies:
- dependency-name: junit:junit
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>- .github/actions/connectivitytests-action/conntest/pom.xml (version 928e29634f567ab5496c8cc081725405dbb8209d)
-
Guus der Kinderen 1d7242860d31159271a33a983963720095fe1fc9
OF-2816: Add support for Hebrew language
This adds support for the Hebrew language.
The translations are made by Schimon Jehudah Zackary. Thanks!- i18n/src/main/resources/openfire_i18n_he.properties (version 1d7242860d31159271a33a983963720095fe1fc9)
- xmppserver/src/main/java/org/jivesoftware/util/LocaleUtils.java (version 1d7242860d31159271a33a983963720095fe1fc9)
- xmppserver/src/main/webapp/decorators/main.jsp (version 1d7242860d31159271a33a983963720095fe1fc9)
- xmppserver/src/main/webapp/decorators/setup.jsp (version 1d7242860d31159271a33a983963720095fe1fc9)
- xmppserver/src/main/webapp/server-locale.jsp (version 1d7242860d31159271a33a983963720095fe1fc9)
- xmppserver/src/main/webapp/setup/index.jsp (version 1d7242860d31159271a33a983963720095fe1fc9)