Build #3

Plan branch:
Run manually for releases

Build: #3 was successful Manual run by daryl herzmann

Code commits

Openfire (master)

  • Guus der Kinderen

    Guus der Kinderen a59c3dc4feaf5eb1c8cad8289394945bb549bd53

    OF-2161: Ensure that SSID for MUC PMs is the MUC JID
    When a private message that's exchanged in a MUC room is processed, it receives a stable and unique stanza ID. As per specification, Openfire adds a 'by' attribute. However, for private messages, this value is a full JID (representing the nickname of the user that sent the message), instead of a bare JID (representing the room in which the message was exchanged). This is fixed by ensuring that the JID used is a bare JID.

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version a59c3dc4feaf5eb1c8cad8289394945bb549bd53)
  • Guus der Kinderen

    Guus der Kinderen 9660d8552379dadeec68a66cf8d9222c25d0eac9

    Improve SubscriptionTask implementation
    The existing implementation lazily-loaded a subscription instance. Construction of such an instance is very cheap. Constructed instances are unlikely to be reused often by the SubscriptionTask that created them.

    To reduce complexity (and improve maintainability) of the code, the lazy-loading of the subscription instance is being removed.

    This should have not functional change. There is an API change that I deem neglible: a transient, package-protected field (that is not accessed outside of the class) is being removed.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version 9660d8552379dadeec68a66cf8d9222c25d0eac9)
  • Guus der Kinderen

    Guus der Kinderen 3530654c125f3a633fc61dc2eef9b492c9aae9ed

    Fix javadoc, indentation

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version 3530654c125f3a633fc61dc2eef9b492c9aae9ed)
  • Guus der Kinderen

    Guus der Kinderen a069a8e4e5c4490170f5191c36094c351c89fcfa

    OF-2162: Add 'ofrom' to private MUC messages
    This applies the changes applied to public MUC messages, introduced in OF-2089, and applies them to private messages too.

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version a069a8e4e5c4490170f5191c36094c351c89fcfa)
  • Guus der Kinderen

    Guus der Kinderen 534e3f511412612da1a6c66ce98d52da8166aad3

    OF-2077: Do not execute refresh pubsub node on cluster node that does not have the pubsub node loaded in-memory.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RefreshNodeTask.java (version 534e3f511412612da1a6c66ce98d52da8166aad3)
  • Guus der Kinderen

    Guus der Kinderen b18fced8d79e819ceac45eadc6e4770902e29d34

    OF-2077: Do not execute affiliate change on cluster node that does not have the pubsub node loaded in-memory.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/AffiliationTask.java (version b18fced8d79e819ceac45eadc6e4770902e29d34)
  • Guus der Kinderen

    Guus der Kinderen 05ca0bd5d9bdcb3af6a54f4b8825b02132d5e030

    OF-2077: Do not execute cancels subscription on cluster node that does not have the pubsub node loaded in-memory.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/CancelSubscriptionTask.java (version 05ca0bd5d9bdcb3af6a54f4b8825b02132d5e030)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version 05ca0bd5d9bdcb3af6a54f4b8825b02132d5e030)
  • Guus der Kinderen

    Guus der Kinderen f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391

    OF-2077: Use Optional instead of null values

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/AffiliationTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/CancelSubscriptionTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/ModifySubscriptionTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NewSubscriptionTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RefreshNodeTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RemoveNodeTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version f6051d0b52d14b6182a95ee4eb0d7ec39b2a4391)
  • Guus der Kinderen

    Guus der Kinderen 59ad0b4c385917b381587c87293785b7602909e5

    OF-2077: Do not execute remove pubsub node on cluster node that does not have the pubsub node loaded in-memory.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RemoveNodeTask.java (version 59ad0b4c385917b381587c87293785b7602909e5)
  • Guus der Kinderen

    Guus der Kinderen 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef

    OF-2077: Rename methods to better express intent
    Methods that return data conditionally should be named appropriately, as to avoid confusion.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/AffiliationTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/CancelSubscriptionTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/ModifySubscriptionTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NewSubscriptionTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RefreshNodeTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RemoveNodeTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version 3ca14f2dc12e07e9cb66feb5b9668f27a3a41fef)
  • Guus der Kinderen

    Guus der Kinderen da1863ade488684370f1bc37a1c772d5879437a3

    Improve contract of Pubsub cluster tasks
    This commit primarily adds javadoc comments. It also adds @Nonnull and @Nullable annotations, and replaces a method that has a typo in its name, leaving the old implementation marked as 'deprecated').

    Finally, it marks NodeChangeTask, which currently goes unused, as @Deprecated

    No functional changes are intended in this commit.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/NodeSubscription.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubEngine.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/AffiliationTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/CancelSubscriptionTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/FlushTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/ModifySubscriptionTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NewSubscriptionTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeChangeTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RefreshNodeTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/RemoveNodeTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version da1863ade488684370f1bc37a1c772d5879437a3)
  • Guus der Kinderen

    Guus der Kinderen b3da2e2c4c1b4a48e550dbd87baf18e1d81f9b69

    Javadoc fix

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCUser.java (version b3da2e2c4c1b4a48e550dbd87baf18e1d81f9b69)
  • Guus der Kinderen

    Guus der Kinderen 5f97a6fce8df286454dc03781701177bc4fd73bd

    OF-2077: Do not execute modify subscription on cluster node that does not have the pubsub node loaded in-memory.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/ModifySubscriptionTask.java (version 5f97a6fce8df286454dc03781701177bc4fd73bd)