Openfire (master)

• 

  Guus der Kinderen 23 Dec 2020 ed34db08c6fe2e929131053ddce52f26be505a91

  OF-2170: Prevent NullPointer

  • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version ed34db08c6fe2e929131053ddce52f26be505a91)
• 

  Guus der Kinderen 23 Dec 2020 4929df9ab98259ae433b0bb6c1198945c98e48cb

  OF-2170: Use CacheableOptional

  • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 4929df9ab98259ae433b0bb6c1198945c98e48cb)
• 

  Guus der Kinderen 23 Dec 2020 30ae3bc8ba3b0621af37574463dde4dd54faab99

  OF-2170: LDAP userDN cache should contain negative lookups
  By caching lookup failures, subsequent lookups are prevented, which will increase performance.

  • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 30ae3bc8ba3b0621af37574463dde4dd54faab99)
• 

  Guus der Kinderen 23 Dec 2020 a7f587a9b490277fb1e3ab0037fad440beb60c08

  OF-2169: Prevent exception for missing LDAP attribute
  When a VCard template refers to an attribute that a user does not have, the resulting value should be empty. This commit prevents a NullPointerException to be thrown.

  • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version a7f587a9b490277fb1e3ab0037fad440beb60c08)
  • xmppserver/src/test/java/org/jivesoftware/openfire/ldap/VCardTest.java (version a7f587a9b490277fb1e3ab0037fad440beb60c08)
• 

  Guus der Kinderen 23 Dec 2020 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a

  OF-2168: MUC presence broadcast supression based on role
  Openfire offers functionality to suppress the broadcast of occupants that have a certain role. The old implementation is based on the definition of that role that should be present in the presence stanza to be broadcast.
  
  When the presence stanza that is being processed does, for some reason, not include this role, the implementation fails. NullPointerExceptions have been observed in relation to this.
  
  It should be a lot safer to base the broadcast/do not broadcast decision based on the role that is assigned to the user, as this prevents the need to parse a stanza. This commit applies this new strategy.
  
  Additionally, this commit replaces the string-based represention of a role with a type-safe variant.

  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQOwnerHandler.java (version 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a)
  • xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 62ab9734dfb1f08795e8ac5b47e4a5d55ee8b51a)
• 

  Guus der Kinderen 17 Dec 2020 2a838898b3f59a63feb77fa057991f3e4e25dc4e

  OF-2163: Prevent unexpected stanza modifications to leak information
  Delivering a stanza to a MUC room occupant changes the addressing of the stanza (the room JID is replaced by the real JID). It is often undesirable that this change is applied to the original stanza (that can be processed further), as such changes can leak the privacy-sensitive real address of the recipient.
  
  This commit creates defensive copies of the stanza that is being sent, to prevent leaking the real address of the recipient.

  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/HistoryRequest.java (version 2a838898b3f59a63feb77fa057991f3e4e25dc4e)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRole.java (version 2a838898b3f59a63feb77fa057991f3e4e25dc4e)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQMUCvCardHandler.java (version 2a838898b3f59a63feb77fa057991f3e4e25dc4e)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java (version 2a838898b3f59a63feb77fa057991f3e4e25dc4e)
  • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 2a838898b3f59a63feb77fa057991f3e4e25dc4e)