Build #2

Plan branch:
Run manually for releases

Build: #2 was successful Manual run by Guus der Kinderen

Code commits

Openfire (master)

  • Guus der Kinderen

    Guus der Kinderen 99f6c5b9b72f7d71507d09db94704747f749f5a6

    OF-2381: Prevent high-frequency MUC ghost detection pings
    When an occupant of a MUC room is inactive, Openfire can send it pings to see if it is still alive.

    The existing implementation would generate a ping during each periodic check, after an occupant was inactive, which is to frequent. Subsequent pings should not be sooner than the configured allowed idle time.

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 99f6c5b9b72f7d71507d09db94704747f749f5a6)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/OccupantManager.java (version 99f6c5b9b72f7d71507d09db94704747f749f5a6)
  • Guus der Kinderen

    Guus der Kinderen b15d484577af4955b369cdd2ffe8623735c96cd7

    OF-2381: Check for activity before kicking ghost MUC user
    MUC Ghost detection uses an IQ Ping to determine if an occupant is a ghost and should be kicked.

    Prior to this commit, unanswered Pings always resulted in a kick, which proves to be overzealous:
    - if the ping was not answered, but activity since the ping request was detected (eg: the client reconnected), there's no need to kick the occupant.
    - if the ping was not answered, but the occupant is no longer connected to the local cluster node, there should be no kick. If the occupant is still connected, then it likely reconnected to another cluster node.

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version b15d484577af4955b369cdd2ffe8623735c96cd7)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/OccupantManager.java (version b15d484577af4955b369cdd2ffe8623735c96cd7)
  • Guus der Kinderen

    Guus der Kinderen 2c4b77e568cc299c8364533cdb2346a647d93866

    OF-2381: Cancel pending Ping when MUC occupant disconnects
    When a MUC occupant disconnects, a pending ghost detection ping task should be aborted. This reduces the chance that a lingering task incorrectly removes a reconnected occupant.

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version 2c4b77e568cc299c8364533cdb2346a647d93866)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/OccupantManager.java (version 2c4b77e568cc299c8364533cdb2346a647d93866)