Build: #9 was successful Manual run by daryl herzmann
Code commits
Openfire (master)
-
daryl herzmann <akrherz@iastate.edu> ac717b36b7087feb26f994206a1608ade01c8da2
Merge pull request #2096 from guusdk/release_4.7.3
denote Openfire 4.7.3 release -
Guus der Kinderen c39d84895659e64ff22b913115bfcf815c47c32b
denote Openfire 4.7.3 release
- distribution/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- i18n/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- plugins/openfire-plugin-assembly-descriptor/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- plugins/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- starter/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- xmppserver/changelog.html (version c39d84895659e64ff22b913115bfcf815c47c32b)
- xmppserver/pom.xml (version c39d84895659e64ff22b913115bfcf815c47c32b)
- xmppserver/src/main/java/org/jivesoftware/openfire/spi/XMPPServerInfoImpl.java (version c39d84895659e64ff22b913115bfcf815c47c32b)
-
Guus der Kinderen 058f41e6250d92d9d3d95477197ff0c40455f115
OF-2490: Better handle PEP requests to non-local/non-registered users
Only local, registered users of Openfire have a PEP service. Other users do not. When a client tries to interact with such a non-existing PEP service, the current behavior of Openfire is to very verbosely log this as an (unexpected) error.
This code tries to properly handle this scenario, by returning a nice error back to the requestee, and logging it less verbosely.- xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version 058f41e6250d92d9d3d95477197ff0c40455f115)
-
Guus der Kinderen b1de41af5b83686318b677ef446d5afd69dcc9a3
OF-2489: Reduce log level severity of SOCKS5 error
Whenever a peer sends unexpected data to the file transfer proxy, an exception occurs. As this is not something that can be 'fixed' by an Openfire administrator, the error shouldn't be logged as verbosely as on level ERROR.
This commit reduces the log level on which this is logged, and improves the wording of the logged message a little.- xmppserver/src/main/java/org/jivesoftware/openfire/filetransfer/proxy/ProxyConnectionManager.java (version b1de41af5b83686318b677ef446d5afd69dcc9a3)
-
Guus der Kinderen ac31ea5b1182ed0564f3f0e6878794dcec438c21
OF-2488: Reduce log level severity of DNS lookup failure
When a particular DNS SRV record doesn't exist, there is no need to log this on level ERROR with a stack trace. The administrator of Openfire is unlikely to be able to fix this, while it occurs all the time.- xmppserver/src/main/java/org/jivesoftware/openfire/net/DNSUtil.java (version ac31ea5b1182ed0564f3f0e6878794dcec438c21)
-
Guus der Kinderen 48a9e9d5337d07dfb21d4fe1399e704a88e6aabf
Revert "OF-400: Truncate MUC subjects longer than 100 characters"
This reverts commit 0c42c426caef3d08ae878010045108c6235d85fd.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 48a9e9d5337d07dfb21d4fe1399e704a88e6aabf)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 48a9e9d5337d07dfb21d4fe1399e704a88e6aabf)
-
Guus der Kinderen 881e9567b8bc93c21fc028b32c7e157799f8b6c9
OF-2423: Improve removal of client sessions from cache
Prior to this, the failure to identify a client session as a (regular) user session resulted in the session being assumed an anonymous user session. When a session is removed twice (which should not occur, but does occur with websockets for some reason), this causes a second client route to be removed from the cache.
This commit ensures that a session is indeed an anonymous session before assuming that it is.
For websockets, a warning will still be logged, as there are still two attempts to remove the session. Optimizing this is the subject of another issue: OF-2485- xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java (version 881e9567b8bc93c21fc028b32c7e157799f8b6c9)
-
Guus der Kinderen 7719e483978aa97af00879170cd0126f6b902c88
OF-2471: Display GroupJID human readable name in Audit viewer
When modifying MUC permissions for a Group, display the Group name, not its base-32 identifier.- xmppserver/src/main/webapp/muc-room-affiliations.jsp (version 7719e483978aa97af00879170cd0126f6b902c88)
-
Guus der Kinderen f3dfa03a6ff3a97be8bb14e001f1bafddb83d2ca
OF-2481: Fix server details on s2s page
- xmppserver/src/main/webapp/server-session-details.jsp (version f3dfa03a6ff3a97be8bb14e001f1bafddb83d2ca)
-
Guus der Kinderen a3a5d4921cf3fa93f930e6137ee3a40e21992bcd
OF-2487: More atomicly replace XMLProperties files
When updating XMLProperties files (`openfire.xml`, `security.xml`), do not:
- create a new temp file
- remove the old file
- copy temp file to the location of the old file
- remove the temp file file
Instead, do this more atomicly, as such:
- create a new temp file
- move temp file to replace to old file
There will leave Openfire in a more consistent state if somewhere along the line, things go wrong. Also, it reduces code a bit.- xmppserver/src/main/java/org/jivesoftware/util/XMLProperties.java (version a3a5d4921cf3fa93f930e6137ee3a40e21992bcd)
-
Guus der Kinderen 818839dbe04bf1259047c7ea9c1190b10a70c08f
OF-2483: Delay restart of admin console when truststore content is changed
This mimics similar behavior introduced by OF-2212 for the identity store. When the trust store is modified by an administrator, restarting the admin console immediately is undesirable, as it kicks out the admin that is busy applying changes.- xmppserver/src/main/webapp/import-truststore-certificate.jsp (version 818839dbe04bf1259047c7ea9c1190b10a70c08f)
- xmppserver/src/main/webapp/security-truststore.jsp (version 818839dbe04bf1259047c7ea9c1190b10a70c08f)
-
Guus der Kinderen 0c42c426caef3d08ae878010045108c6235d85fd
OF-400: Truncate MUC subjects longer than 100 characters
Openfire's database support only 100 characters for a MUC room subject.
To prevent database errors, this commit truncates subjects that are longer than this.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 0c42c426caef3d08ae878010045108c6235d85fd)
- xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 0c42c426caef3d08ae878010045108c6235d85fd)
-
Guus der Kinderen 1feb7dde7b6e9baced475e2b7ecada72b3f69fc7
OF-2486: Ensure mediated MUC invite has a 'from'.
XEP-0045 mandates a 'from' attribute on the 'invite' element, used for mediated invitations. This aught to be the address of the inviter. In some scenarios, there is not an identifiable XMPP entity that is the inviter (eg: when an invitation is generated through the admin console or REST api). In such cases, this commit will use the bare JID of the room itself as the invitation. Reasoning that it can be thought of as the inviter, and having at least some value is less likely to break clients that expect the attribute to be present.- xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version 1feb7dde7b6e9baced475e2b7ecada72b3f69fc7)
-
akrherz <akrherz@iastate.edu> 5dbe5eda419f2c9be3f982012956973ac9e51026
OF-2484 truncate last update instant to millis
- xmppserver/src/main/java/org/jivesoftware/openfire/update/UpdateManager.java (version 5dbe5eda419f2c9be3f982012956973ac9e51026)
-
akrherz <akrherz@iastate.edu> 2d5d5f17503bbd134c228225a368b67bde60f534
OF-1396 fix redirect on cancel button on pubsub page
- xmppserver/src/main/webapp/pubsub-service-summary.jsp (version 2d5d5f17503bbd134c228225a368b67bde60f534)
-
Guus der Kinderen a6ef00ed2293bb570bc0db5c5203e7deb6f5f5bd
OF-2181: Have links in info boxes stand out
Links in info boxes without text decoration and using the same font color are very hard to spot. To help end-users identify links, I've changed the color of the link, and added an underline text decoration to them.- xmppserver/src/main/webapp/style/global.css (version a6ef00ed2293bb570bc0db5c5203e7deb6f5f5bd)
-
Guus der Kinderen e08838b196032cb8d1b6bb595e9f9765a9fec4fc
OF-2482: Fix invalid description element in admin-sidebar.xml
This issue has been present for a couple of years apparently, but I'm only recently seeing the admin console pages that it affects throwing an error. Maybe some dependency update in 4.8 introduces more strictness? In any case, having this fixed is a good thing, as it should help show tooltips for the affected menu items.- xmppserver/src/main/resources/admin-sidebar.xml (version e08838b196032cb8d1b6bb595e9f9765a9fec4fc)
-
Guus der Kinderen 57f909ffe32b1e5d1986e411c3c290027a476595
OF-2467: Do not reload admin page when changing MUC affiliation dropdown
The admin console page that allows you to change MUC room permissions / affiliations has a drop-down box that lists all possible affiliations. Whenever that drop-down is changed, the page used to reload, causing all modifications to be lost. This was done to show or hide the 'nickname' input field.
This commit shows/hides that field with javascript magic, removing the need for a page reload.- xmppserver/src/main/webapp/muc-room-affiliations.jsp (version 57f909ffe32b1e5d1986e411c3c290027a476595)
-
Guus der Kinderen 3071be44badf1fee4830ab9ab64d3a71328f092f
OF-2466: Groups presented in MUC room affiliation page should be ordered
- xmppserver/src/main/webapp/muc-room-affiliations.jsp (version 3071be44badf1fee4830ab9ab64d3a71328f092f)