Generates the latest/greatest Maven-based artifacts for the Openfire project, every night.

Build: #3263 was successful Scheduled with changes by Dan Caseley and Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
1 second
Duration
11 minutes
Labels
None
Agent
mesonet-ah.agron.iastate.edu (2)
Revision
d9f966f1ade13034d2328eb10dfe0b76a9fe304e
Total tests
2007
Successful since
#3235 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 55f400f4b1e48da9a26bf0b033be8a5932653817 OF-3257: Use constant-time comparison for channel binding data in SCRAM-SHA-1(-PLUS) SASL server
Previously, the comparison of the expected and received channel binding payloads in ScramSha1SaslServer used Arrays.equals, which is not guaranteed to operate in constant time. This could potentially leak information about the channel binding data through timing side-channels.

This change replaces Arrays.equals with MessageDigest.isEqual, ensuring that the comparison is performed in constant time. This strengthens the implementation against timing attacks, aligns with secure coding best practices, and provides defense-in-depth for sensitive authentication operations.
Guus der Kinderen Guus der Kinderen 7325e1f3f14d5e2ee8ddc23b02265c23c306dbe4 OF-3257/OF-3258 (code review): Prevent order-dependent failures by resetting the property after each test.
Guus der Kinderen Guus der Kinderen d7e92d5a4b0ab130310cf7a9eb50b7be139e7414 OF-3257/OF-3258: Improve one-time initialization of SERVER_SECRET_NONEXISTENT_USERS
The previous method for one-time initialization of the SERVER_SECRET_NONEXISTENT_USERS property (which depended on a static initializer block) proved to be fragile.

In this commit, initialization happens in a getter that should be used instead of directly accessing the property.
Guus der Kinderen Guus der Kinderen 38b2549c1a8753fffcc25dc54300ec0417d94c9b OF-3257 (code review): Remove unused imports
Guus der Kinderen Guus der Kinderen fe4f4ad6bc7e97947e02ee1e4df7a8655f85392c OF-3257: Avoid short-circuiting in SCRAM by introducing deterministic fake keys
When storedKey or serverKey are missing, generate deterministic fake values derived from a server-side secret and the username. This ensures that authentication follows the same execution path regardless of user existence, reducing susceptibility to timing attacks.

Includes unit tests to verify determinism and key separation.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-3257Could not obtain issue details from Jira
Unknown Issue TypeOF-3258Could not obtain issue details from Jira

Shared artifacts

Artifact File size
install4j-generated media 5 KB