Generates the latest/greatest Maven-based artifacts for the Openfire project, every night.

Build: #3269 was successful Scheduled with changes by Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
1 second
Duration
10 minutes
Labels
None
Agent
mesonet-ah.agron.iastate.edu (2)
Revision
04a773e3c7da10b1a2324e32b1b0754f1da46b6d
Total tests
1728
Successful since
#3235 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 8644f4de8cfaef3c626bb6c9e424f12ef3dbe759 OF-3260: Support RFC 7239 Forwarded header for proxied client IP resolution
Add support for the standardized HTTP `Forwarded` header (RFC 7239) alongside existing `X-Forwarded-*` handling in proxied deployments.

Extended proxy connector configuration in both BOSH and Admin Console to include a configurable `Forwarded` header name.

Updated admin pages to expose and persist the RFC-compliant header setting (`FHeader`) in addition to legacy header settings.
Guus der Kinderen Guus der Kinderen 01a4e5ab740951a861cd576740a3a6de3fdb08e8 (code review) Use consistent names for i18n properties
Guus der Kinderen Guus der Kinderen 04a773e3c7da10b1a2324e32b1b0754f1da46b6d (code review) Improve audit logged messages
Log the value obtained from the property, rather than whatever was provided by the end-user. In 99% of the times, this should be equal, but the property itself should always be right.
Guus der Kinderen Guus der Kinderen 68ebbe69bf0fcb74499ee9c4b62eb51143e68065 OF-3261 (code review): Prevent nondeterministic order of stored trusted proxies
Guus der Kinderen Guus der Kinderen 5e152d9031f8b6f4e72f023d5c5a19d27f7ab78c OF-3261: Allow reverse proxies to be verified
Before trusting remote-peer provided HTTP headers like `Forwarded` and `X-Forwarded-For`, the source of these headers should be validated. This prevents malicious clients from setting this header themselves.

This commit introduces a wrapper for Jetty's ForwarededRequestCustomizer (which replaces the reported IP address of the remote peer with a value from the HTTP headers). When Openfire is now configured with a non-empty set of trusted proxies, such replacement only occurs when the remote peer is one of the trusted proxies.

This functionality has been added to the Admin Console and webbinding implementations, using two distinct properties:
- `adminConsole.forwarded.trusted.proxies`
- `httpbind.forwarded.trusted.proxies`

Valid values are IP addresses (IPv4 and IPv6) and ranges.

The admin console has been modified to allow for configuration of these values through the pages where related functionality was already provided.

A small CSS tweak was introduced: Openfire's setup had an implementation where a question-mark icon can be used to provide a tooltip help text. That has now been moved from 'setup' to 'global', so that it can be used both during setup, but also in the admin console itself (after setup has finished).

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-3260Could not obtain issue details from Jira
Unknown Issue TypeOF-3261Could not obtain issue details from Jira

Shared artifacts

Artifact File size
install4j-generated media 5 KB