Build #958

Plan branch:
Generates the latest/greatest Maven-based artifacts for the Openfire project, every night.

Build: #958 was successful Scheduled with changes by Guus der Kinderen

Stages & jobs

  1. Build and Package

  2. Deploy

  3. copy nightlies to website

Code commits

Openfire (master)

  • Guus der Kinderen

    Guus der Kinderen a14a783528aab9438f29bf5f7e6245de3282b450

    OF-353: LDAP Remove support for 'enclosed' DNs.
    As a resolution for JM-1327, the concept of 'enclosing' DNs with double-quote (") characters was introduced.

    The previous commit adds more elaborate escaping of reserved characters, which makes this 'enclosing' redundant. As the code now uses javax.naming.* types, instead of Strings, to represent DNs, it'll be more challenging to restorte the 'enclosing' functionality.

    To reduce code complexity, the 'enclosing' functionality (that no longer serves any purpose) is removed in this commit.

    • i18n/src/main/resources/openfire_i18n.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • i18n/src/main/resources/openfire_i18n_de.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • i18n/src/main/resources/openfire_i18n_es.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • i18n/src/main/resources/openfire_i18n_pt_PT.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • i18n/src/main/resources/openfire_i18n_ru_RU.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • i18n/src/main/resources/openfire_i18n_zh_CN.properties (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version a14a783528aab9438f29bf5f7e6245de3282b450)
    • xmppserver/src/main/webapp/setup/ldap-server.jspf (version a14a783528aab9438f29bf5f7e6245de3282b450)
  • Guus der Kinderen

    Guus der Kinderen 80d3ff37cf28e578cc8909ebea06269c30456c91

    OF-353: Allow baseDN to have spaces
    The baseDN value is used to compose the connect host(s) URL. This value is a space-separated string of URLs. When a baseDN contains a space character, this character must be escaped, to prevent it from being interpreted as a second connect host.

    This commit adds URL encoding to the baseDN when it's used to create the connect host URL.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 80d3ff37cf28e578cc8909ebea06269c30456c91)
    • xmppserver/src/test/java/org/jivesoftware/openfire/ldap/LdapManagerTest.java (version 80d3ff37cf28e578cc8909ebea06269c30456c91)
  • Guus der Kinderen

    Guus der Kinderen f326a1566376391169736642db13087ba1e426b5

    Javadoc typo fix

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version f326a1566376391169736642db13087ba1e426b5)
  • Guus der Kinderen

    Guus der Kinderen e168b8f391e46008e338ab83c05cdd9cc22b47a6

    OF-353: LDAP: improve character escaping
    This adds additional escaping of LDAP strings, including those defined in RFC-4514.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version e168b8f391e46008e338ab83c05cdd9cc22b47a6)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version e168b8f391e46008e338ab83c05cdd9cc22b47a6)
    • xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version e168b8f391e46008e338ab83c05cdd9cc22b47a6)
  • Guus der Kinderen

    Guus der Kinderen 8988aefd569bf25d14e8aeac424ebca7daf7f306

    OF-353: Prevent redundant boxing.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 8988aefd569bf25d14e8aeac424ebca7daf7f306)
  • Guus der Kinderen

    Guus der Kinderen ad4962b24700844a2aecfd3a64f585ba0cf1389c

    OF-353: Improve escaping for JNDI
    As LDAP is being accessed through JNDI, data needs to be handled in a way that is aware of JNDI specifics.

    For input parameters, this was already taken into account. A similar handling however, failed for processing search results. This commit adds that.

    Additionally, the implementation responsible for this is no longer custom code. Instead, the LdapName class (provided by Java) is now used for this purpose.

    • xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version ad4962b24700844a2aecfd3a64f585ba0cf1389c)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version ad4962b24700844a2aecfd3a64f585ba0cf1389c)
    • xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version ad4962b24700844a2aecfd3a64f585ba0cf1389c)
  • Guus der Kinderen

    Guus der Kinderen ba53868ae63a700cf54f3caf187d62bf614e9c98

    OF-353: Improve exception message logging.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version ba53868ae63a700cf54f3caf187d62bf614e9c98)
  • Guus der Kinderen

    Guus der Kinderen 9275cdb6df54f6a9c0d9fe52a556e5c3dcce97d4

    OF-353: Properly concat RDN values.
    As found by lgtm.com: https://lgtm.com/projects/g/igniterealtime/Openfire/rev/pr-39a7f695da8e9cbf775306367871905c327b97ac

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version 9275cdb6df54f6a9c0d9fe52a556e5c3dcce97d4)
  • Guus der Kinderen

    Guus der Kinderen 777cffcf2a7c888dd29d33bf8cd9eda14f1b1102

    OF-353: Prevent redundant initialization of arrays.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 777cffcf2a7c888dd29d33bf8cd9eda14f1b1102)
  • Guus der Kinderen

    Guus der Kinderen c018cd4e3cba2ca1f25bd799e57bcebbed7541d1

    OF-353: Add optional escaping of RDN.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version c018cd4e3cba2ca1f25bd799e57bcebbed7541d1)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version c018cd4e3cba2ca1f25bd799e57bcebbed7541d1)
  • Guus der Kinderen

    Guus der Kinderen f732dec6de8d7fd4eef1931b910cde24580f7160

    OF-353: Removed redundant if (debug) checks, tweaked logging.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version f732dec6de8d7fd4eef1931b910cde24580f7160)
  • Guus der Kinderen

    Guus der Kinderen 5b9d6ecccc5223f82877770480517157d9170924

    OF-353: Remove unused property

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 5b9d6ecccc5223f82877770480517157d9170924)
  • Guus der Kinderen

    Guus der Kinderen 62eaa8a67c2745361e1a7129d62f0d9a505e04ac

    OF-353: Fixing up log messages.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 62eaa8a67c2745361e1a7129d62f0d9a505e04ac)
  • Guus der Kinderen

    Guus der Kinderen 90364691e771c6f3f39edc636f7a29049c2aaef9

    OF-353: Remove redundant catch

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 90364691e771c6f3f39edc636f7a29049c2aaef9)
  • Guus der Kinderen

    Guus der Kinderen e131ff4578d2835b97cf051834c74ac7941e1ae0

    OF-353: Allow for RDNs with more than one component.
    When searching for 'mtucker' in the basedn 'o=jivesoftware, o=com', the code should be able to handle a response that consists of more than one RDN value, like 'uid=mtucker,ou=People'.

    Shamelessly stolen the commit from @Fishbowler's https://github.com/Fishbowler/Openfire/commit/fb12dfc48b53dfadd1f94ee713a1194fb3e50455

    • xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthProvider.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationMapping.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationPolicy.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapUserProvider.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/main/webapp/setup/setup-admin-settings_test.jsp (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
    • xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version e131ff4578d2835b97cf051834c74ac7941e1ae0)
  • Guus der Kinderen

    Guus der Kinderen 046a8a419ecb5d8a315de82e57c0d0970a38aa8a

    OF-353: Refactor parseAsLdapName to keep Enumeration out

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 046a8a419ecb5d8a315de82e57c0d0970a38aa8a)
  • Guus der Kinderen

    Guus der Kinderen ed1269b6851c4c2d12f4127603e7442720ff07c7

    OF-353: Remove redundant initializers and cast.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version ed1269b6851c4c2d12f4127603e7442720ff07c7)
  • Guus der Kinderen

    Guus der Kinderen 5b721eea9d5f3b8853f397db4d28f7b36c02bb58

    OF-353: Revert from LdapName to String for adminDN
    Earlier commits introduces the usage of LdapName to represent DNs. This had an unexpected side effect: the LDAP admin DN now strictly requires the full DN.

    In the past, the userprincipalname format (user.name@domain.com) could be used, but not anymore. This will likely break some installs.

    This commit reverts back to String to represent the adminDN.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 5b721eea9d5f3b8853f397db4d28f7b36c02bb58)
    • xmppserver/src/main/webapp/profile-settings.jsp (version 5b721eea9d5f3b8853f397db4d28f7b36c02bb58)
    • xmppserver/src/main/webapp/setup/ldap-server.jspf (version 5b721eea9d5f3b8853f397db4d28f7b36c02bb58)
  • Guus der Kinderen

    Guus der Kinderen 098ab6cc10f6a2a653e5fac145c60792ff2c30bf

    OF-353: Remove deprecated methods
    The OF-353 implementation changes the API considerably. There's no value in keeping some old, unused methods around, as there'll be API incompatibilities anyway.

    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 098ab6cc10f6a2a653e5fac145c60792ff2c30bf)
  • Guus der Kinderen

    Guus der Kinderen 99161e841941dbdbcb060da320c6f0d8bd02b6ea

    OF-353: Use RDN instead of LdapName, escape for JNDI.
    In a recent commit, string-based representations of LDAP distinguished names were replaced with instances of LdapName.

    User and Groups are referred to in Openfire code by relative references, RDNs. Java has a more specific implementation for that: Rdn. In this commit, Rdn replaces LdapName when group or user references are being represented.

    Additionally, RDN values are properly escaped when their string representation is used in a JNDI-based lookup, which is a Java-specific requirement to working with LDAP via JNDI. This effectively solves issues with users or groups that contain the forward-slash character.

    • xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthProvider.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationPolicy.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapUserProvider.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/webapp/setup/setup-admin-settings.jsp (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/main/webapp/setup/setup-admin-settings_test.jsp (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
    • xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version 99161e841941dbdbcb060da320c6f0d8bd02b6ea)
  • Guus der Kinderen

    Guus der Kinderen 8c1df6ac4abe3022ce618ea7122835b1218d7e65

    OF-353: LDAP - use javax.naming.* types instead of Strings
    To represent LDAP DNs, Strings have been used. Java provides a more specific, and more suitable set of types for this purpose.

    By using the types in the javax.naming package, additional functionality becomes available, and type-safety is improved throughout the code.

    • xmppserver/src/main/java/org/jivesoftware/admin/LdapUserTester.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthProvider.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapAuthorizationPolicy.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapManager.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapUserProvider.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapVCardProvider.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/webapp/profile-settings.jsp (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/webapp/setup/ldap-server.jspf (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/main/webapp/setup/setup-admin-settings_test.jsp (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)
    • xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version 8c1df6ac4abe3022ce618ea7122835b1218d7e65)