Build: #2236 was successful
Job: Run Maven was successful
Code commits
Openfire (master)
-
Guus der Kinderen 219963deaff81025ed862c46ee95748e705c5d9f
OF-2608: Do not wait for Dialback response if connection is closed
While waiting for a response to a Dialback request, Openfire should terminate when the underlying connection is closed.- xmppserver/src/main/java/org/jivesoftware/openfire/server/OutgoingServerSocketReader.java (version 219963deaff81025ed862c46ee95748e705c5d9f)
- xmppserver/src/main/java/org/jivesoftware/openfire/server/ServerDialback.java (version 219963deaff81025ed862c46ee95748e705c5d9f)
-
Guus der Kinderen dfb7d9d25d09e21de9b0ae7b880f7613cc271b96
OF-2612: Migrate unit test implementation to JUnit 5
Most unit tests are refactored to use JUnit 5 instead of 4.
Notable exceptions:
- FlattenNestedGroupsTest, which uses org.zapodot:embedded-ldap-junit which currently is based on JUnit 4 (JUnit 5 support being tracked in https://github.com/zapodot/embedded-ldap-junit/issues/57 )
- DBUnit-based tests- xmppserver/src/test/java/dom/io/XMPPPacketReaderTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/admin/LoginLimitManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/admin/SiteMinderServletRequestAuthenticatorTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/OfflineMessageStoreTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/SessionPacketRouterTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/admin/GroupBasedAdminProviderTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/archive/ArchiverTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/auth/JDBCAuthProviderTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/carbons/MessageCarbonsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/cluster/ClusterMonitorTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/container/PluginManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesListenerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/forward/ForwardTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/AbstractGroupProviderTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupJIDTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/handler/IQEntityTimeHandlerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/http/HttpSessionDeliverable.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/CertificateUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/OpenfireX509TrustManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/LdapManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/VCardTemplateTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/VCardTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/HistoryStrategyTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/MUCRoleTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/MUCRoomTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/spi/MucPrivilegesTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/spi/OccupantManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/net/DNSUtilTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/nio/XMLLightweightParserTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/nio/XmlNumericCharacterReferenceTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CollectionNodeTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/LeafNodeTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/session/SessionTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/spi/ConnectionTypeTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/spi/EncryptionArtifactFactoryTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/stanzaid/StanzaIDUtilTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/streammanagement/StreamManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/openfire/user/UserManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/AdminConsoleTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/AesEncryptorTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/BlowfishEncryptorTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/CacheUtilTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/CacheableOptionalTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/CertificateManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/CertificateTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/CollectionUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/EntityCapabilitiesManagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/GraphicsUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/JIDTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/JavaSpecVersionTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/LDAPTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/ListPagerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/LocaleUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/SAXReaderUtilTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/StringUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/SystemPropertyTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/VersionTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/WebXmlUtilsTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/XMLPropertiesTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/XMPPDateTimeFormatTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/XPPWriterTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/cache/DefaultExternalizableUtilTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
- xmppserver/src/test/java/org/jivesoftware/util/cache/ReverseLookupComputingCacheEntryListenerTest.java (version dfb7d9d25d09e21de9b0ae7b880f7613cc271b96)
-
Guus der Kinderen bbdcf46f5d70d50c1eb45443b58f5272840a6ead
OF-2613: Upgrade database in unit tests to 34
This updates the database that's used in unit testing from 33 to 34. This prevents this update from being performed prior to each test execution.- xmppserver/src/test/resources/datasets/openfire.script (version bbdcf46f5d70d50c1eb45443b58f5272840a6ead)
-
Guus der Kinderen c2c611954d2200d4e43601b60d145419ca916590
Minor improvements of unit test code
This removes a couple of disabled unit tests and applies IDE suggested improvements on code and spelling. Nothing major.- xmppserver/src/test/java/org/jivesoftware/Fixtures.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/auth/JDBCAuthProviderTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/container/PluginManagerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/AbstractGroupProviderTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerNoMockTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/handler/IQEntityTimeHandlerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/http/HttpSessionDeliverableTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/CheckChainTrustedTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/KeystoreTestUtils.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/keystore/OpenfireX509TrustManagerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/LdapManagerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/VCardTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/muc/HistoryStrategyTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/net/DNSUtilTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/nio/XmlNumericCharacterReferenceTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/openfire/stanzaid/StanzaIDUtilTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/AdminConsoleTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/CacheableOptionalTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/CertificateManagerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/CollectionUtilsTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/StringUtilsTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/SystemPropertyTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/WebXmlUtilsTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/XMLPropertiesTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/XPPWriterTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/cache/DefaultExternalizableUtilTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
- xmppserver/src/test/java/org/jivesoftware/util/cache/ReverseLookupComputingCacheEntryListenerTest.java (version c2c611954d2200d4e43601b60d145419ca916590)
-
Guus der Kinderen 138f4b90c0558a3ff0ccb7924611df5bcb6aad9f
OF-2612: Use BOM for JUnit and Mockito dependencies
As per review feedback: using BOMs to simplify maintenance of the dependency definitions.
This also bumps Mockito from 5.3.1 to 5.4.0, and removes unused dependency definitions of Mockito.- xmppserver/pom.xml (version 138f4b90c0558a3ff0ccb7924611df5bcb6aad9f)
-
Guus der Kinderen fe41fa5da7d8be3f0c553e9938aaf1993a8c48b4
OF-2612: Migrate from JUnit 4 to JUnit 5
Adds JUnit 5 to the classpath, including the 'vintage' support for JUnit 4. Unit tests, even without modifications, remain functional.- xmppserver/pom.xml (version fe41fa5da7d8be3f0c553e9938aaf1993a8c48b4)
-
Guus der Kinderen 7c8ec7f704d516bd749900b0917c7751b6798b47
OF-2070: Remove disabled FlattenNestedGroupsTest unit test
It’s been three years without progress (I gave it a quick stab just now, but couldn’t get it to work). Meanwhile, it starts to accumulate technical debt (one of its dependencies triggers vulnerability warnings in static analysis).
The implementation will remain part of the the source code version control history. If needed, it can be resurrected from there.- xmppserver/pom.xml (version 7c8ec7f704d516bd749900b0917c7751b6798b47)
- xmppserver/src/test/java/org/jivesoftware/openfire/ldap/FlattenNestedGroupsTest.java (version 7c8ec7f704d516bd749900b0917c7751b6798b47)
- xmppserver/src/test/resources/org/jivesoftware/openfire/ldap/flattenNestedGroups.ldif (version 7c8ec7f704d516bd749900b0917c7751b6798b47)