Build: #231 was successful Manual run by daryl herzmann

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
1 second
Duration
8 minutes
Labels
None
Revision
7e1c8d1b5804f616648aed2f204863f052789a28
Total tests
1781
Successful since
#190 ()

Tests

Code commits

Author Commit Message Commit date
daryl herzmann daryl herzmann 7e1c8d1b5804f616648aed2f204863f052789a28 Merge pull request #3209 from akrherz/v504
Denote Openfire 5.0.4 Release
daryl herzmann daryl herzmann 23661785e93c43b4ab0831eb4f793a275ea50530 Denote Openfire 5.0.4 Release
copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> f99a88985dfd118f31a6ff7b9f643635e35c15e6 fix(pubsub): always update lastPublished when same item is overwritten (XEP-0060 §7.1.2)
Root cause of PubSubExtIntegrationTest failure:
setLastPublishedItem() only updated the in-memory lastPublished cache
when the new item's creation date was *strictly after* the existing one.
When a publisher re-publishes an item with the same ItemID in rapid
succession (within the same millisecond, common in integration tests),
both items share the same CacheFactory.getClusterTime() value.
The after() check returns false, so lastPublished is NOT updated.
The persistence layer correctly performs an SQL UPDATE, but
getPublishedItem() short-circuits by returning the stale in-memory
lastPublished instead of going to the database, causing the test
assertion ("item equals first, not second") to fail.

Fix: add a third update condition — always update when the incoming
item has the same unique identifier (same node + same ItemID) as the
current lastPublished. Overwrites are always reflected in the cache
regardless of timestamp resolution.

Adds 3 regression tests in LeafNodeTest covering same-ID/same-time
overwrite, same-time different-ID non-overwrite, and newer-time
different-ID update.

Co-authored-by: akrherz <210858+akrherz@users.noreply.github.com>
(cherry picked from commit ddfc5252b879c76e93c0ed5684e64221cdf47587)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeXEP-0060Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.deb files 55 MB