Build: #129 was successful Manual run by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
3 seconds
Duration
1 minute
Labels
None
Revision
fd46423632c6213ee50b89fb30e3bc2a0fff9ef5
Total tests
475
Successful since
#1 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen fd46423632c6213ee50b89fb30e3bc2a0fff9ef5 OF-2424: Assert when LocalSession is null
Under certain circumstances (notably, when a session is detached), a session's connection can be null.

This commit adds assertions to identify the null-ability of a sessin's connection, and ensures that a null connection is not attempted to be used in a context where it is assumed to be non-null.
Guus der Kinderen Guus der Kinderen 7a263910aad48cff1806c9cd99073e8950cebc06 OF-2456: properly propagate a nickname change over the cluster.
Guus der Kinderen Guus der Kinderen 040f5c501000337e81986b2d12a533550cfc0029 Removed two redundant null-checks spotted by LGTM.
Guus der Kinderen Guus der Kinderen dc44ebc479ddea92deff84aab8fbce72ba80ba68 OF-2458: Guard access to field to prevent ConcurrentModificationException
The internal field 'presence' should not be modified when read, as that has been observed to lead to ConcurrentModificationException being thrown.

This commit adds a lock to all access to the 'presence' and related 'extendedInformation' fields, to prevent this from happening.

Additionaly, the instance returned by the `getPresence()` method has been replaced with a defensive copy (much of the invoking code did immediately create such a copy after acquiring the instance, which now has been removed).
Guus der Kinderen Guus der Kinderen 04c3b5080ce87dc47ed3da6f2448c76ec35567c9 Minor non-functional changes (mostly spelling)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2424Could not obtain issue details from Jira
Unknown Issue TypeOF-2444Could not obtain issue details from Jira
Unknown Issue TypeOF-2456Could not obtain issue details from Jira
Unknown Issue TypeOF-2458Could not obtain issue details from Jira