Build: #72 was successful Manual run by daryl herzmann
Code commits
Openfire (main)
-
github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> 362f4dc4c110f4ba193f09603a954c7575cbcc99
OF-2818: Netty should not use 5MB buffers (#2457)
This corrects a mistake where a configuration of having a _maximum_ buffer size was turned into having a _fixed_ buffer size.
Having 5MB buffers is bad, as with a limited amount of messages, a _lot_ of memory is being consumed.
This commit removes the hard-coded buffer size configuration, while retaining the maximum message length directive.
I've tested that, using a websocket client connection:
- a message of 128k characters can be sent using the default configuration;
- a message of 128k characters can not be sent when Openfire is reconfigured to use 4k for the `xmpp.parser.buffer.size` property
(cherry picked from commit 46191c19590f7d414791a05a4693433cb4cc061f)
Co-authored-by: Guus der Kinderen <guus.der.kinderen@gmail.com>- xmppserver/src/main/java/org/jivesoftware/openfire/websocket/OpenfireWebSocketServlet.java (version 362f4dc4c110f4ba193f09603a954c7575cbcc99)