Build #2,270

Plan branch:
Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #2270 was successful Changes by Guus der Kinderen

Code commits

Openfire (master)

  • Guus der Kinderen

    Guus der Kinderen bd200df2fabf56fd1a129650718e37003f06fd0c

    OF-2403: Apply i18n to memory usage text on admin console

    • i18n/src/main/resources/openfire_i18n.properties (version bd200df2fabf56fd1a129650718e37003f06fd0c)
    • i18n/src/main/resources/openfire_i18n_de.properties (version bd200df2fabf56fd1a129650718e37003f06fd0c)
    • i18n/src/main/resources/openfire_i18n_nl.properties (version bd200df2fabf56fd1a129650718e37003f06fd0c)
    • i18n/src/main/resources/openfire_i18n_ru_RU.properties (version bd200df2fabf56fd1a129650718e37003f06fd0c)
    • xmppserver/src/main/webapp/index.jsp (version bd200df2fabf56fd1a129650718e37003f06fd0c)
  • Guus der Kinderen

    Guus der Kinderen 24d1a249055dd487aaa471595b322b0e4d6c44a2

    OF-2403: Use maximum rather than committed memory to calculate usage
    When calculating how much of the available memory is being used by Openfire, use the absolute maximum amount of memory available to Openfire as the upper bound, not the amount of memory that is currently committed.

    • xmppserver/src/main/java/org/jivesoftware/util/MemoryUsageMonitor.java (version 24d1a249055dd487aaa471595b322b0e4d6c44a2)
    • xmppserver/src/main/webapp/index.jsp (version 24d1a249055dd487aaa471595b322b0e4d6c44a2)
  • Guus der Kinderen

    Guus der Kinderen 5da9dffec20a0d8973c1573a3a4cac3d6310846e

    OF-2403: Memory usage should be recorded directly after GC
    To prevent memory usage to include (a lot of) to-be-garbage-collected data (which leads to higher utilization numbers, which needlessly alarms some users), the reported memory usage should display memory used directly after the most recent garbage collect.

    One concern that I have is that this change introduces a reference to a class in the com.sun hierarchy of packages (specifically: GarbageCollectionNotificationInfo). I do not believe that all classes in this hierarchy are considered 'closed API', but I've not been able to determine conclusively if GarbageCollectionNotificationInfo is. If it is, then its usage might cause problems when Openfire is using a non-Oracle JDK. The class is annotated with jdk.Exported, which I believe makes it safe to use.

    • xmppserver/src/main/java/org/jivesoftware/util/MemoryUsageMonitor.java (version 5da9dffec20a0d8973c1573a3a4cac3d6310846e)
    • xmppserver/src/main/webapp/index.jsp (version 5da9dffec20a0d8973c1573a3a4cac3d6310846e)