Build: #2271 was successful Changes by Guus der Kinderen
Code commits
Openfire (master)
-
Guus der Kinderen 670229ff18cba21d34e709557b71bc6c0479d601
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ReentrantLock.- xmppserver/src/main/java/org/jivesoftware/openfire/roster/RosterManager.java (version 670229ff18cba21d34e709557b71bc6c0479d601)
-
Guus der Kinderen 3c7a6758d89b39c55ee9e754dfa8e28c2ada5caa
LGTM: Do not synchronize on a String
Instead of a String-based mutexes (which are fairly easy to accidentally duplicate in unrelated parts of code), use a mutex that is guaranteed to be scoped to the code that should be executed under protection of a lock.- xmppserver/src/main/java/org/jivesoftware/openfire/MulticastRouter.java (version 3c7a6758d89b39c55ee9e754dfa8e28c2ada5caa)
-
Guus der Kinderen d581fc8666bc357a119c648f94d5dbdb5e358f8d
Make fields final
- xmppserver/src/main/java/org/jivesoftware/openfire/multiplex/ConnectionMultiplexerManager.java (version d581fc8666bc357a119c648f94d5dbdb5e358f8d)
-
Guus der Kinderen 748d2246d3922808e69fe423fa3d4382ab3fb500
Prevent null-references.
- xmppserver/src/main/java/org/jivesoftware/util/Base64.java (version 748d2246d3922808e69fe423fa3d4382ab3fb500)
-
Guus der Kinderen 3a58cba3d29d3bbdd922e97793ac0978bea99ac8
LGTM: suppress false positive
- xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientTrustManager.java (version 3a58cba3d29d3bbdd922e97793ac0978bea99ac8)
-
Guus der Kinderen 82a9a1f3ca40b91dbddcba96129be9f48b1194bc
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ReentrantLock.- xmppserver/src/main/java/org/jivesoftware/openfire/commands/AdHocCommandManager.java (version 82a9a1f3ca40b91dbddcba96129be9f48b1194bc)
- xmppserver/src/main/java/org/jivesoftware/openfire/commands/SessionData.java (version 82a9a1f3ca40b91dbddcba96129be9f48b1194bc)
-
Guus der Kinderen e2ad0516aea19dc2fa7c01dca114560fc858db68
Replaced unneeded use of boxed type with primitive.
- xmppserver/src/main/java/org/jivesoftware/database/DbConnectionManager.java (version e2ad0516aea19dc2fa7c01dca114560fc858db68)
-
Guus der Kinderen 97bb323eb0a38d21bc338ab43da427df4e3d58b1
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ConcurrentMap to provide equal (or better) thread-safety.- xmppserver/src/main/java/org/jivesoftware/openfire/multiplex/ConnectionMultiplexerManager.java (version 97bb323eb0a38d21bc338ab43da427df4e3d58b1)
-
Guus der Kinderen 33b58e67b9c3653942ff80a7667d6369540a1701
Make fields final
- xmppserver/src/main/java/org/jivesoftware/openfire/commands/AdHocCommandManager.java (version 33b58e67b9c3653942ff80a7667d6369540a1701)
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version 33b58e67b9c3653942ff80a7667d6369540a1701)
-
Guus der Kinderen 84b718d63d52dfdc8ad1f8fe0ae87726f24f2ad0
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ReentrantLock.- xmppserver/src/main/java/org/jivesoftware/openfire/privacy/PrivacyListManager.java (version 84b718d63d52dfdc8ad1f8fe0ae87726f24f2ad0)
-
Guus der Kinderen 9538dad7f54ce089b06632a9b54023c252a093a2
Remove unused code
- xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientTrustManager.java (version 9538dad7f54ce089b06632a9b54023c252a093a2)
-
Guus der Kinderen 17425bac7733a697e22d80f45a7957898d9c1ade
Make fields final
- xmppserver/src/main/java/org/jivesoftware/openfire/privacy/PrivacyListManager.java (version 17425bac7733a697e22d80f45a7957898d9c1ade)
-
Guus der Kinderen fd5c603342019fb93326bbfbc1362a816fdf7e42
Don't create instance to use a static method.
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version fd5c603342019fb93326bbfbc1362a816fdf7e42)
-
Guus der Kinderen 051be8c0d0c881e26e88500f66539a0595bb8cbc
LGTM: remove useless null-check
- xmppserver/src/main/java/org/jivesoftware/openfire/component/InternalComponentManager.java (version 051be8c0d0c881e26e88500f66539a0595bb8cbc)
-
Guus der Kinderen 9fb278fbbbab194ede65741cf14adb1c02b0574e
LGTM: ensure that streams are closed
- xmppserver/src/main/java/org/jivesoftware/admin/ASN1DERTag.java (version 9fb278fbbbab194ede65741cf14adb1c02b0574e)
- xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientTrustManager.java (version 9fb278fbbbab194ede65741cf14adb1c02b0574e)
-
Guus der Kinderen 615186da00e37a6890bd7077bd5e221ff281a09e
LGTM: Do not synchronize on a String
Instead of a String-based mutexes (which are fairly easy to accidentally duplicate in unrelated parts of code), use a mutex that is guaranteed to be scoped to the code that should be executed under protection of a lock.
The String that was used here was 'namespaced', which makes it unlikely that a problem would have been introduced here. The replacement is safer.- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubEngine.java (version 615186da00e37a6890bd7077bd5e221ff281a09e)
-
Guus der Kinderen 732bf7d9c561ed84c455f0d53c83f7c823006270
Removed unused regular expression.
- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version 732bf7d9c561ed84c455f0d53c83f7c823006270)
-
Guus der Kinderen 8d78d228c937e5ddca51eec6b165d794310cde4e
Replace redundant array initializer
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/IdentityStore.java (version 8d78d228c937e5ddca51eec6b165d794310cde4e)
-
Guus der Kinderen ecee8262ed3ff07af778653bdd378b9f96c0e14b
Replace with enhanced for-loop
- xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientTrustManager.java (version ecee8262ed3ff07af778653bdd378b9f96c0e14b)
-
Guus der Kinderen 9d66b4d8666d84984c7cd630981c9d3689f42e67
Suppress a false positive for LGTM
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStoreConfiguration.java (version 9d66b4d8666d84984c7cd630981c9d3689f42e67)
-
Guus der Kinderen d853c50591e0f3f40d10f8f4b3d59fa60c04ecbd
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ConcurrentMap to provide equal (or better) thread-safety.- xmppserver/src/main/java/org/jivesoftware/openfire/commands/AdHocCommandManager.java (version d853c50591e0f3f40d10f8f4b3d59fa60c04ecbd)
-
Guus der Kinderen 44256fef103366dae58240250ccf09e18de7a733
Remove null checks that are unneeded
- xmppserver/src/main/java/org/jivesoftware/openfire/keystore/IdentityStore.java (version 44256fef103366dae58240250ccf09e18de7a733)
-
Guus der Kinderen 43399f363d4720baae815136fa4fd17fedfca3c7
Replaced unneeded use of boxed type with primitive.
- xmppserver/src/main/java/org/jivesoftware/database/bugfix/OF33.java (version 43399f363d4720baae815136fa4fd17fedfca3c7)
-
Guus der Kinderen 328ae6b9477ab6fa57a2fa1268e00e4176a1cfde
LGTM: equals() implementation should have matching hashCode()
- xmppserver/src/main/java/org/jivesoftware/openfire/SessionResultFilter.java (version 328ae6b9477ab6fa57a2fa1268e00e4176a1cfde)
-
Guus der Kinderen bc469b46c01bf44e6c1f633ff7e359e439b410aa
LGTM: Do not use a String-based mutex
This replaces a String-based mutex with usage of a ConcurrentMap to provide equal (or better) thread-safety.- xmppserver/src/main/java/org/jivesoftware/util/StringUtils.java (version bc469b46c01bf44e6c1f633ff7e359e439b410aa)
-
Guus der Kinderen b0f55ef89baacfafeed9a62282fcd5b91aff6258
LGTM: Do not synchronize on a String
Instead of a String-based mutexes (which are fairly easy to accidentally duplicate in unrelated parts of code), use a mutex that is guaranteed to be scoped to the code that should be executed under protection of a lock.
The String that was used here was 'namespaced', which makes it unlikely that a problem would have been introduced here. The replacement is safer.- xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version b0f55ef89baacfafeed9a62282fcd5b91aff6258)