Build #2,418

Plan branch:
Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
23 minutes
Labels
None
Agent
Default Agent
Revision
a92b532f5d2d12907bd54606ddcd945b82b63fbc
Total tests
1342
Fixed in
#2419 (Changes by Guus der Kinderen)

Tests

Responsible

  • Guus der Kinderen Guus der Kinderen Automatically assigned

Code commits

Author Commit Message Commit date
Alex Gidman <alex.gidman@surevine.com> Alex Gidman <alex.gidman@surevine.com> 87f5d15d552d7253de35cf347ad8cd32b02cfa0c fix: OF-1913 - reinit connection when transferring session, move stream tag processing code to initiateSession
Alex Gidman <alex.gidman@surevine.com> Alex Gidman <alex.gidman@surevine.com> 31f9e4af7248ce4fb3a6a7e2960cf9856c50f232 fix: OF-1913 - move server-to-server specific functionality out of StanzaHandler to ServerStanzaHandler
Guus der Kinderen Guus der Kinderen a92b532f5d2d12907bd54606ddcd945b82b63fbc Revert "OF-1913: Refactor incoming stanza processing"
This reverts commit a0262b2e67b190e88679996aba7e7fcdc1dbce24.

Unsure, why, but this breaks the unit tests. I'd like to retain the changes for a later review, but want to be able to merge the PR. Hence the revert, instead of a history rewrite to remove the commit.
Guus der Kinderen Guus der Kinderen a44afebb1ebc26dcbd7b6b31f051cd40a2e88ac9 OF-1913: Refactor incoming stanza processing
This splits up the session creation and initial data exchange for incoming server sessions.
Alex Gidman <alex.gidman@surevine.com> Alex Gidman <alex.gidman@surevine.com> 55e3c761249cf5f7d908f3606c5b372690e52c17 fix: OF-1913 - transfer session authentication method when new session created for existing connection

5 more changes...

Tests

New test failures 1
Status Test View job Duration
Collapse Failed LocalIncomingServerSessionTest incomingTest(ServerSettings, ServerSettings)[284]
Build 1 sec 
org.opentest4j.AssertionFailedError: expected: not <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:35)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:30)
	at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:301)
	at org.jivesoftware.openfire.session.LocalIncomingServerSessionTest.incomingTest(LocalIncomingServerSessionTest.java:309)
(126 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-1913Could not obtain issue details from Jira