Build #2,440

Plan branch:
Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
11 minutes
Labels
None
Agent
Default Agent
Revision
daca2cfe2c78425c90fd3a19ca12605f4e31d415
Total tests
1346
Successful since
#2419 ()

Tests

Code commits

Author Commit Message Commit date
Matthew Vivian <matthew.vivian@surevine.com> Matthew Vivian <matthew.vivian@surevine.com> daca2cfe2c78425c90fd3a19ca12605f4e31d415 Fix: Correctly clean up OutgoingServerSession
On cleanup of old S2S sessions, the `OutgoingServerSessionListener#onConnectionClose` is called for the outbound connection, at this time the routing table contains a single route, but the route is not removed because the session passed to `OutgoingServerSessionListener#onConnectionClose` as the "`handback`" parameter has an empty `outgoingDomainPairs` field.

So when `OutgoingServerSessionListener#onConnectionClose` tries to `removeServerRoute(domainPair)` by iterating over `session.getOutgoingDomainPairs()` there is no `domainPair` to remove.

Adding the Outgoing Domain Pair to the new session on `transferConnectionToNewSession` allows the route to be cleaned up correctly.
Guus der Kinderen Guus der Kinderen 10d5f8067c9daf3a6ad95b2b0f700b3923cc8730 Prevent deadlock in Netty Outbound S2S