Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #2583 was successful Changes by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
11 minutes
Labels
None
Agent
ip-172-31-27-151.eu-central-1.compute.internal
Revision
2759a5c642c799251cf6ce7115dae5aaefddb93f
Total tests
1398
Successful since
#2581 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 7c52305534bd493ce1a3054c7ad32153976b7716 Minor VCard improvements
Guus der Kinderen Guus der Kinderen 2759a5c642c799251cf6ce7115dae5aaefddb93f OF-2839: Return error when non-existing VCard is requested.
When requesting a VCard from someone else, XEP-0054 (version 1.2) section 3.3 defines:

> If no vCard exists [...] the server MUST return a stanza error,

Furthermore:

> If no vCard exists or the user does not exist, the server MUST return a stanza error, which SHOULD be either <service-unavailable/> or <item-not-found/> (but the server MUST return the same error condition in both cases to help prevent directory harvesting attacks).

Finally, RFC 6121 section 8.5.1 defines:

> If the user account identified by the 'to' attribute does not exist, how the stanza is processed depends on the stanza type. For an IQ stanza, the server MUST return a <service-unavailable/> stanza error to the sender.

Openfire currently does not return an error, but an empty VCard. This is allowable when requesting one’s own VCard, but not when requesting that of others.

Instead, Openfire must return an error with the service-unavailable condition when someone is requesting a VCard that doesn’t exist, from an existing user.

Note that Openfire already returns service-unavailable when an IQ request is sent to a non-existing user.
Guus der Kinderen Guus der Kinderen 00c88addd5fa8541b0318258bee4693d15d17142 OF-2838: Return error when updating someone else's VCard
Instead of silently ignoring such a request, return an error, as mandated by the XEP.
Guus der Kinderen Guus der Kinderen b3f6919dd04afed190182e0807f89b68332f3983 OF-2835: Openfire should advertise CAPS support
As Openfire supports CAPS (it calculates a hash for its own service discovery information), advertise support through service discovery.
Guus der Kinderen Guus der Kinderen fcca17d42db26927113e4944b9658e5303bc15be Apply IDE suggestions
Minor, non-functional changes suggested by the IDE (spelling, non-needed code, etc).

Jira issues

IssueDescriptionStatus
4 more issues…
Unknown Issue TypeOF-2825Could not obtain issue details from Jira
Unknown Issue TypeOF-2835Could not obtain issue details from Jira
Unknown Issue TypeOF-2836Could not obtain issue details from Jira
Unknown Issue TypeOF-2838Could not obtain issue details from Jira
Unknown Issue TypeOF-2839Could not obtain issue details from Jira