Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).
OF-3026: State changes of LocalRoutingTable should happen under guard of a lock
When modifications to a LocalRoutingTable is made, this should always happen under guard of a lock that also guards related changes to the corresponding cache.
This commit should reduce the possibility of state inconsistencies. It does so by re-using the Cache-sourced locks that were originally introduced by the changes for issue ENT-425.
In the past, we introduced deadlock potential by putting more operations under guard of a lock. From history, I don't think we ever attempted this change. Additionally, as the code that's now moved under guard of the pre-existing lock is not (intended to be) used by code outside of this package (the class has a corresponding access modified), this change should have minimal risks of introducing such a deadlock.
OF-3026: LocalClientRoutingTable addRoute and removeRoute consistency
The argument used to add or remove a route to/from localClientRoutingTable should be created in the same way, for consistency.
Note that this is a non-functional change, as in practice, the `toString` and `toFullJID` invocations would have resulted in the same value. An earlier check ensures that the only difference in those two methods (checking if the resource part is not null) isn't a factor.
OF-2974: Move script tags out of connection settings pages
To allow for stricter CSP directives, these pages should no longer contain inline `<script>` elements.
This commit restores broken functionality that, in older versions of Openfire, appears to have hidden certain configuration form elements based on the setting of others.
