Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).
OF-2966: BOSH events should execute in-order
BOSH related events (mostly: processing of received stanzas) are executed by a worker pool of threads.
Events for each individual session must be processed in the same order in which they are received. Prior to this change, every event was potentially executed by a different worker thread. This can cause some events to be processed (or finish processing) before an earlier event finishes execution in another worker thread.
This commit adds FIFO-based queuing of events, that ensures that events that belong to the same session are processed:
- by only one thread from the worker pool;
- in the same order in which they're received.
OF-2966: Periodic clean-up of BOSH working thread queues
In the previous commit, a mechanism was introduced that ensures per-session FIFO processing of events, using a queuing mechanism based on Futures.
This commit adds a periodic check to see if any events are queued for sessions that no longer exist, discarding those events if they're found.
The cleanup is intended as a safeguard measure against slow accumulation of non-executable events, which over time could lead to memory starvation.
Chore: when debug logging, replace string concat of message
Instead of concatenation, use the `{}` construct will prevent building the string until it's actually logged.
Although it's probably a performance improvement, it's mainly a readability improvement.
OF-2966: BOSH 'close' executed by worker threads
By having the 'close' routine be executed by the same worker threads that process regular BOSH data, the processing order of all of these will make use of the FIFO mechanism introduced in the last two commits.
This helps ensure that a 'close' (terminate) event is processed only after stanzas that were received earlier have been processed - assuming that this processing is synchronous.
