Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #2997 was successful Changes by Guus der Kinderen

Stages & jobs

  1. Default Stage

  2. Continuous Integration

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
13 minutes
Labels
None
Agent
mesonet-ah.agron.iastate.edu
Revision
d226e917c8cba9a3e5edd2c26ea368ce855f7b84
Total tests
1811
Successful since
#2937 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 45b0221b64f9b2ba21e2953bb503118656b95fb3 OF-2694 (code review feedback): (more) correctly encode SCRAM-SHA-1 test vector
Instead of concatenating two base64 strings, concat the byte-parts of the channel-binding data, and base64 encode the result. This better conforms to https://datatracker.ietf.org/doc/html/rfc5802#section-7
Guus der Kinderen Guus der Kinderen f39641d3f8b22024dd3320e6a56a80f0ab04a654 OF-2694: Make available `tls-server-end-point` channel binding by default
This registers the corresponding provider without any ceremony. Future modifications could introduce configurability, but as support for this channel binding is mandatory per XEP, hard-coding seems acceptable.
Guus der Kinderen Guus der Kinderen e9759983513777462a9b082b13d660a645e0cee1 OF-2694: Add SCRAM-SHA-1-PLUS mechanism with channel binding support
Introduces SCRAM-SHA-1-PLUS SASL mechanism, implementing RFC 5802 channel binding for TLS.

Advertise SCRAM-SHA-1-PLUS by default, but only when channel binding is available and session is encrypted.
Guus der Kinderen Guus der Kinderen ea80cd3df604f98a0efa5828a390f9a2e0dd96f3 OF-2879: Implement XEP-0440: SASL Channel-Binding Type Capability
With Channel Binding now available (as this commit follows commits that implements these under OF-2694), Openfire should announce what type of channel binding types it supports. The mechanism for this is define in XEP-0440. This commit implements this mechanism.

Additionally, the channel binding type that is used for a session (if any) is now shown on its 'session details' page on the admin console.
Guus der Kinderen Guus der Kinderen ddec6a6f7fb4756dd60e9890e4456d7c1afff230 OF-2694 (code review feedback): Additional hardening + unit test coverage
This adds more validation of the exchanged data in the SASL handshake, and adds more unit test coverage.

Small refactorings have been applied to make ScramSha1SaslServer easier to unit-test. It now no longer unconditionally uses static calls to other classes. Such classes can be provided via a `@VisibleForTesting` constructor.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2694Could not obtain issue details from Jira
Unknown Issue TypeOF-2879Could not obtain issue details from Jira
Unknown Issue TypeXEP-0440Could not obtain issue details from Jira

Shared artifacts

Artifact File size
Unpacked project files 267 MB