Build #2,512

Plan branch:
Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #2512 was successful

Job: Build was successful

Stages & jobs

  1. Default Stage

Code commits

Openfire (master)

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 271731d66f6cbdb4eed2fae9997c4daa5bce1b29

    Merge pull request #2348 from guusdk/OF-880_NoSuchUser-IQ-handling
    OF-880: IQHandlers must comply with RFC 6121 Section 8.5.1 by default

  • Guus der Kinderen

    Guus der Kinderen 3c658c44e632f99f6bc78ffd2c0940a501ee62c0 m

    OF-880: IQHandlers must comply with RFC 6121 Section 8.5.1 by default
    This builds on a previous attempt to add support for IQ handling with regards to RFC 6121 Section 8.5.1 (No Such User), which was added in 15e6c5619d6ade7c40de95a1a7a158b1a9358ff0 and got partially reverted in 637cc81733092275c2726b43ebe603c0cbd438fe

    The original fix got reverted, because pre-existing code (in IQHandlers of plugins) depends on non-compliant behavior.

    With this new commit, I'm re-introducing the fix, but am adding a mechanism for individual plugins to opt out.

    • xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQHandler.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQSessionEstablishmentHandler.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
  • Guus der Kinderen

    Guus der Kinderen 44349ac44fc98d9e9e474305ae0f5b8c4d219856 m

    OF-880: No Such User detection to evaluate pre-authenticated session
    A pre-authenticed session should not be consided a 'no such user' case.

    Given the implementation, it's hard to identify a pre-authenticated session based on a (bare JID) 'to' address. The API is designed to be used by 'from' addresses.

    Pre-authenticated sessions are unlikely to be the subject of a query, unless it is the client itself issuing the query. Aioxmpp's tests have been observed to perform disco/info requests prior to authentication. Given this, we can use the 'from' address (full JID) if its bare JID matches the addressee for the 'no such user' detection.

    • xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 44349ac44fc98d9e9e474305ae0f5b8c4d219856)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQHandler.java (version 44349ac44fc98d9e9e474305ae0f5b8c4d219856)