Build: #2984 was successful
Job: Build was successful
Code commits
Openfire (master)
-
Milan Tyagi <milantyagi2004@gmail.com> 5bc15034261f11840fe620b265f05263d01e7961
OF-2970: Implement HTTP Cache-Control headers in the admin console
Static assets (JS, CSS, images, fonts) now use configurable
short-term caching (default: public, max-age=3600) instead of
long-lived immutable caching, preventing stale assets after upgrades
while still reducing redundant requests.
Dynamic/admin pages now receive no-store/no-cache/must-revalidate
headers to prevent sensitive content from being cached by browsers
or proxies.
Changes include:
- Replace immutable year-long caching with configurable short-term caching
- Add configurable SystemProperties for static resource extensions and max-age
- Apply cache headers after chain.doFilter() to inspect response status
- Restrict cache headers to successful (200/304) responses only
- Skip header application for committed responses or existing Cache-Control headers
- Remove unnecessary query parameter stripping from URI processing
- Add comprehensive unit tests covering static resources, dynamic pages,
error responses, committed responses, case-insensitive matching,
and configurable properties- xmppserver/src/main/java/org/jivesoftware/admin/CacheControlFilter.java (version 5bc15034261f11840fe620b265f05263d01e7961)
- xmppserver/src/main/webapp/WEB-INF/web.xml (version 5bc15034261f11840fe620b265f05263d01e7961)
- xmppserver/src/test/java/org/jivesoftware/admin/CacheControlFilterTest.java (version 5bc15034261f11840fe620b265f05263d01e7961)
- xmppserver/web/WEB-INF/web.xml (version 5bc15034261f11840fe620b265f05263d01e7961)
-
Milan Tyagi <milantyagi2004@gmail.com> cd3554956ef0a73bb8258def4c925c9aca21573a
OF-2970: Address review feedback for CacheControlFilter
- Replaced STATIC_RESOURCE_EXTENSIONS SystemProperty from a
comma-separated String type to a List<String> type using
buildList(String.class). This leverages the framework's native
list support and eliminates the need for manual CSV parsing
in the getStaticExtensions() helper method, which has been removed.
- Added missing i18n description entries in openfire_i18n.properties
for the two new system properties:
- adminConsole.static-resource-extensions
- adminConsole.static-resource-max-age
This fixes the "???system_property.X???" error shown on the
admin console System Properties page.- i18n/src/main/resources/openfire_i18n.properties (version cd3554956ef0a73bb8258def4c925c9aca21573a)
- xmppserver/src/main/java/org/jivesoftware/admin/CacheControlFilter.java (version cd3554956ef0a73bb8258def4c925c9aca21573a)
-
Milan Tyagi <milantyagi2004@gmail.com> a4c921bf869742c4b6088a3939709231e6453a1b
fix implement stream to handle custom values
- xmppserver/src/main/java/org/jivesoftware/admin/CacheControlFilter.java (version a4c921bf869742c4b6088a3939709231e6453a1b)