Build: #18 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (4.2)
-
Florian Schmaus <flo@geekplace.eu> 76adf22ba19e3f519eb13073778f6721f747a3ea
Add missing break statement to deleteViaServiceAdministration()
in IntTestUtil.- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/IntTestUtil.java (version 76adf22ba19e3f519eb13073778f6721f747a3ea)
-
Florian Schmaus <flo@geekplace.eu> 1e0481b3558509b03aa9c1c691dba17d88ceb9df
Add PubSubManager.getOrCreateLeafNode(String)
- smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/PubSubAssertionError.java (version 1e0481b3558509b03aa9c1c691dba17d88ceb9df)
- smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/PubSubManager.java (version 1e0481b3558509b03aa9c1c691dba17d88ceb9df)
-
Florian Schmaus <flo@geekplace.eu> 762939068b8f1f4f9965f77da085cd1c9c0c5d12
Add javadoc for SASLMechanism.getPriority()
- smack-core/src/main/java/org/jivesoftware/smack/sasl/SASLMechanism.java (version 762939068b8f1f4f9965f77da085cd1c9c0c5d12)
-
Florian Schmaus <flo@geekplace.eu> 3d1cf61caff092d03649619819b2ebcb42e1de68
Add comment to ScramMechanism.getChannelBindingName()
- smack-core/src/main/java/org/jivesoftware/smack/sasl/core/ScramMechanism.java (version 3d1cf61caff092d03649619819b2ebcb42e1de68)
-
Florian Schmaus <flo@geekplace.eu> 3ce597391518e4587bb10efd09f890abec917562
Also add stanzas to unacknowledgedStanzas while shutting down
This caused the WaitForClosingStreamElementTest integration test to
fail, because the last presences stanzas, which are send after done()
in the writer thread would return true, are not added to the
unacknowledgedStanzas queue.
The result was:
SEVERE: WaitForClosingStreamElementTest.waitForClosingStreamElementTest (LowLevel): Failed
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.invokeLowLevel(SmackIntegrationTestFramework.java:466)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runTests(SmackIntegrationTestFramework.java:375)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.run(SmackIntegrationTestFramework.java:165)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.main(SmackIntegrationTestFramework.java:84)
Caused by: java.lang.AssertionError: Sync poing yielded failure exception
at org.jivesoftware.smack.WaitForClosingStreamElementTest.waitForClosingStreamElementTest(WaitForClosingStreamElementTest.java:46)
... 8 more
Caused by: org.jivesoftware.smack.sm.StreamManagementException$StreamManagementCounterError: There was an error regarding the Stream Mangement counters. Server reported 3 handled stanzas, which means that the 3 recently send stanzas by client are now acked by the server. But Smack had only 1 to acknowledge. The stanza id of the last acked outstanding stanza is FqL1X-144
at org.jivesoftware.smack.tcp.XMPPTCPConnection.processHandledCount(XMPPTCPConnection.java:1847)
at org.jivesoftware.smack.tcp.XMPPTCPConnection.access$2600(XMPPTCPConnection.java:149)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(XMPPTCPConnection.java:1176)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.access$300(XMPPTCPConnection.java:980)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$1.run(XMPPTCPConnection.java:996)
at java.lang.Thread.run(Thread.java:745)- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 3ce597391518e4587bb10efd09f890abec917562)
-
Florian Schmaus <flo@geekplace.eu> 43715460c6ecba2f893e2fcfe1622faca6e41075
Fix SASL SCRAM-SHA-1(-PLUS) priority
Fixes SMACK-749.
Thanks to Grigory Fedorov for reporting this and to Kim Alvefur for
helping to diagnose the issue.- smack-core/src/main/java/org/jivesoftware/smack/sasl/core/SCRAMSHA1Mechanism.java (version 43715460c6ecba2f893e2fcfe1622faca6e41075)
- smack-core/src/main/java/org/jivesoftware/smack/sasl/core/ScramSha1PlusMechanism.java (version 43715460c6ecba2f893e2fcfe1622faca6e41075)
-
Florian Schmaus <flo@geekplace.eu> de783dce735aa9042d5942cd48f123522f1c1cd7
Add SASLMechanism.toString()
- smack-core/src/main/java/org/jivesoftware/smack/sasl/SASLMechanism.java (version de783dce735aa9042d5942cd48f123522f1c1cd7)
-
Florian Schmaus <flo@geekplace.eu> b6f7d019c775cd4a22e0f7f642e33259f904f2f4
Use SASLMechanism.toString() in getRegisterdSASLMechanisms()
of SASLAuthentication.- smack-core/src/main/java/org/jivesoftware/smack/SASLAuthentication.java (version b6f7d019c775cd4a22e0f7f642e33259f904f2f4)
-
Florian Schmaus <flo@geekplace.eu> 140e8faae35dd502fb8cc03e34c3bfe0e0b86710
Add Smack logo
thanks to Muhammad Bilal Siddiq for providing these.- resources/logo/smack-logo-plain.ai (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710)
- resources/logo/smack-logo-plain.svg (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710)
- resources/logo/smack-logo-with-text.ai (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710)
- resources/logo/smack-logo-with-text.svg (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710)
-
Florian Schmaus <flo@geekplace.eu> dcac9531e772a87b8e30549d03571ce5a334c67b
Fix SASLAuthentication.getRegisteredSASLMechanisms
by using a LinkedHashMap which is insertion-ordered as compared to
HashMap.- smack-core/src/main/java/org/jivesoftware/smack/SASLAuthentication.java (version dcac9531e772a87b8e30549d03571ce5a334c67b)
-
Florian Schmaus <flo@geekplace.eu> 3640339073dbc9400288d682a9d65cef53ab1375
Fix ConnectionConfiguration.getEnabledSaslMechanisms()
in case enabledSaslMechanisms is null, because then unmodifiableSet()
will throw an NPE.
Thanks to Nándor Holozsnyák for reporting.- smack-core/src/main/java/org/jivesoftware/smack/ConnectionConfiguration.java (version 3640339073dbc9400288d682a9d65cef53ab1375)
-
Florian Schmaus <flo@geekplace.eu> 0a6843f41f6bc2f8fc52019868179279a9b44fdc
Make StreamNegotiator weakly reference XMPPConnection
by extending Manager.
Because FileTransferNegotiator will hold a strong reference to the
StreamNegotiators, which will eventually prevent XMPPConnection from
being GC'ed if no weak references in StreamNegotiator are used.
Thanks to Werner Glanzer for pointing this out.- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc)
-
Florian Schmaus <flo@geekplace.eu> a592a12229fa5448c3c52f9ae802220c536efd85
Make InBandBytestreamManager use weak references to XMPPConnection
- smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java (version a592a12229fa5448c3c52f9ae802220c536efd85)
-
Florian Schmaus <flo@geekplace.eu> 525feaa16156da1197338877e15d3a0ab54ec8ab
Add SynchronizationPoint.getFailureException()
- smack-core/src/main/java/org/jivesoftware/smack/SynchronizationPoint.java (version 525feaa16156da1197338877e15d3a0ab54ec8ab)
- smack-integration-test/src/main/java/org/jivesoftware/smack/WaitForClosingStreamElementTest.java (version 525feaa16156da1197338877e15d3a0ab54ec8ab)