Build: #2 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (4.2)
-
Florian Schmaus <flo@geekplace.eu> b0fef6ffcbe18af78db93aa4b0d7e9fe24e90d15
Ensure that populateHostAddressees() doesn't return a list with 'null'
Thanks to Grigory Fedorov for reporting this.- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version b0fef6ffcbe18af78db93aa4b0d7e9fe24e90d15)
-
Florian Schmaus <flo@geekplace.eu> 51d3c3176638eb7e9e08e6facf71d589bc2ccb04
Initialize Socket in TCP connection when proxy is used
Thanks to Grigory Fedorov for reporting this.- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 51d3c3176638eb7e9e08e6facf71d589bc2ccb04)
-
Florian Schmaus <flo@geekplace.eu> bfc14227caba62de16de59fef8a09dbbdb2ec10e
Propagate stream errors on connect/login to the caller
Before this, if there was a stream error response by the server to our
stream open, that error response would only be handled in the reader
thread, and the user would get a message like:
"org.jivesoftware.smack.SmackException$NoResponseException: No
response received within reply timeout. Timeout was
5000ms (~5s). While waiting for SASL mechanisms stream feature from
server"
while the server may actually sent something like
<stream:stream
xmlns='jabber:client'
xmlns:stream='http://etherx.jabber.org/streams'
id='6785787028201586334'
from='jabbim.com'
version='1.0'
xml:lang='en'>
<stream:error>
<policy-violation xmlns='urn:ietf:params:xml:ns:xmpp-streams'>
</policy-violation>
<text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>
Too many (2) failed authentications from this IP
address (1xx.66.xx.xxx). The address will be unblocked at 04:24:00
06.01.2017 UTC
</text>
</stream:error>
</stream:stream>
It was necessary to change saslFeatureReceived from SmackException to
XMPPException in order to return the StreamErrorException at this sync
point. But this change in return required the introduction of a
tlsHandled sync point for SmackException (which just acts as a wrapper
for the various exception types that could occurn when establishing
TLS). The tlsHandled sync point is marked successful even if no TLS
was established in case none was required and/or if not supported by
the server.- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e)
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e)
- smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e)
-
Florian Schmaus <flo@geekplace.eu> cff91f5a920f31cf6ee1e1eb085a490d109c8125
Use correct element and namepsace in AccountManager.isSupported()
- smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java (version cff91f5a920f31cf6ee1e1eb085a490d109c8125)
-
Florian Schmaus <flo@geekplace.eu> 7167a55f81d6f51db04ee739799813b1a280d835
AccountManager: Don't fallback to disco#info if not authenticated
- smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java (version 7167a55f81d6f51db04ee739799813b1a280d835)
-
Florian Schmaus <flo@geekplace.eu> 24bbe63da1ed67dccfd10d514c063ca59cdb4ec0
Minor code improvements in DNSutil
- smack-core/src/main/java/org/jivesoftware/smack/util/DNSUtil.java (version 24bbe63da1ed67dccfd10d514c063ca59cdb4ec0)
-
Florian Schmaus <flo@geekplace.eu> b343b499b55421e9b808c875bfdb82c0fba28009
MiniDNS resolver: Fix exception when there is only a A or AAAA RR
W/System.err: java.lang.IllegalStateException: Can not perform operation because the DNS resolution was unsuccessful
W/System.err: at de.measite.minidns.hla.ResolverResult.throwIseIfErrorResponse(ResolverResult.ja va:113)
W/System.err: at de.measite.minidns.hla.ResolverResult.getAnswers(ResolverResult.java:56)
W/System.err: at org.jivesoftware.smack.util.dns.minidns.MiniDnsResolver.lookupHostAddress0(Mini DnsResolver.java:130)
W/System.err: at org.jivesoftware.smack.util.dns.DNSResolver.lookupHostAddress(DNSResolver.java: 52)
W/System.err: at org.jivesoftware.smack.AbstractXMPPConnection.populateHostAddresses(AbstractXMP PConnection.java:612)
W/System.err: at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectUsingConfiguration(XMPPTCPC onnection.java:555)
W/System.err: at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectInternal(XMPPTCPConnection. java:885)
W/System.err: at org.jivesoftware.smack.AbstractXMPPConnection.connect(AbstractXMPPConnection.ja va:374)
W/System.err: at com.example.bosleo.chatapp.ChatConnection.connect(ChatConnection.java:147)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService.initConnection(ChatConnectionS ervice.java:82)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService.access$100(ChatConnectionServi ce.java:20)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService$1.run(ChatConnectionService.ja va:105)
W/System.err: at java.lang.Thread.run(Thread.java:818)
W/System.err: Caused by: de.measite.minidns.hla.ResolutionUnsuccessfulException: Asking for 192.168.2.128. IN AAAA yielded an error response NX_DOMAIN
W/System.err: at de.measite.minidns.hla.ResolverResult.getResolutionUnsuccessfulException(Resolv erResult.java:89)
W/System.err: at de.measite.minidns.hla.ResolverResult.throwIseIfErrorResponse(ResolverResult.ja va:111)
W/System.err: ... 12 more- smack-resolver-minidns/src/main/java/org/jivesoftware/smack/util/dns/minidns/MiniDnsResolver.java (version b343b499b55421e9b808c875bfdb82c0fba28009)