Build: #419 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> 08c228ef99b59c7c16b44941875e1ea640db3b62
Merge branch '4.2'
-
Florian Schmaus <flo@geekplace.eu> 76adf22ba19e3f519eb13073778f6721f747a3ea m
Add missing break statement to deleteViaServiceAdministration()
in IntTestUtil. -
Florian Schmaus <flo@geekplace.eu> 1e0481b3558509b03aa9c1c691dba17d88ceb9df m
Add PubSubManager.getOrCreateLeafNode(String)
-
Florian Schmaus <flo@geekplace.eu> 140e8faae35dd502fb8cc03e34c3bfe0e0b86710 m
Add Smack logo
thanks to Muhammad Bilal Siddiq for providing these.- resources/logo/smack-logo-plain.ai (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710) (diffs)
- resources/logo/smack-logo-plain.svg (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710) (diffs)
- resources/logo/smack-logo-with-text.ai (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710) (diffs)
- resources/logo/smack-logo-with-text.svg (version 140e8faae35dd502fb8cc03e34c3bfe0e0b86710) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 762939068b8f1f4f9965f77da085cd1c9c0c5d12 m
Add javadoc for SASLMechanism.getPriority()
-
Florian Schmaus <flo@geekplace.eu> 43715460c6ecba2f893e2fcfe1622faca6e41075 m
Fix SASL SCRAM-SHA-1(-PLUS) priority
Fixes SMACK-749.
Thanks to Grigory Fedorov for reporting this and to Kim Alvefur for
helping to diagnose the issue. -
Florian Schmaus <flo@geekplace.eu> 3ce597391518e4587bb10efd09f890abec917562 m
Also add stanzas to unacknowledgedStanzas while shutting down
This caused the WaitForClosingStreamElementTest integration test to
fail, because the last presences stanzas, which are send after done()
in the writer thread would return true, are not added to the
unacknowledgedStanzas queue.
The result was:
SEVERE: WaitForClosingStreamElementTest.waitForClosingStreamElementTest (LowLevel): Failed
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.invokeLowLevel(SmackIntegrationTestFramework.java:466)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runTests(SmackIntegrationTestFramework.java:375)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.run(SmackIntegrationTestFramework.java:165)
at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.main(SmackIntegrationTestFramework.java:84)
Caused by: java.lang.AssertionError: Sync poing yielded failure exception
at org.jivesoftware.smack.WaitForClosingStreamElementTest.waitForClosingStreamElementTest(WaitForClosingStreamElementTest.java:46)
... 8 more
Caused by: org.jivesoftware.smack.sm.StreamManagementException$StreamManagementCounterError: There was an error regarding the Stream Mangement counters. Server reported 3 handled stanzas, which means that the 3 recently send stanzas by client are now acked by the server. But Smack had only 1 to acknowledge. The stanza id of the last acked outstanding stanza is FqL1X-144
at org.jivesoftware.smack.tcp.XMPPTCPConnection.processHandledCount(XMPPTCPConnection.java:1847)
at org.jivesoftware.smack.tcp.XMPPTCPConnection.access$2600(XMPPTCPConnection.java:149)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(XMPPTCPConnection.java:1176)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.access$300(XMPPTCPConnection.java:980)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$1.run(XMPPTCPConnection.java:996)
at java.lang.Thread.run(Thread.java:745) -
Florian Schmaus <flo@geekplace.eu> b6f7d019c775cd4a22e0f7f642e33259f904f2f4 m
Use SASLMechanism.toString() in getRegisterdSASLMechanisms()
of SASLAuthentication. -
Florian Schmaus <flo@geekplace.eu> de783dce735aa9042d5942cd48f123522f1c1cd7 m
Add SASLMechanism.toString()
-
Florian Schmaus <flo@geekplace.eu> 3d1cf61caff092d03649619819b2ebcb42e1de68 m
Add comment to ScramMechanism.getChannelBindingName()
-
Florian Schmaus <flo@geekplace.eu> dcac9531e772a87b8e30549d03571ce5a334c67b m
Fix SASLAuthentication.getRegisteredSASLMechanisms
by using a LinkedHashMap which is insertion-ordered as compared to
HashMap. -
Florian Schmaus <flo@geekplace.eu> 3640339073dbc9400288d682a9d65cef53ab1375 m
Fix ConnectionConfiguration.getEnabledSaslMechanisms()
in case enabledSaslMechanisms is null, because then unmodifiableSet()
will throw an NPE.
Thanks to Nándor Holozsnyák for reporting. -
Florian Schmaus <flo@geekplace.eu> 0a6843f41f6bc2f8fc52019868179279a9b44fdc m
Make StreamNegotiator weakly reference XMPPConnection
by extending Manager.
Because FileTransferNegotiator will hold a strong reference to the
StreamNegotiators, which will eventually prevent XMPPConnection from
being GC'ed if no weak references in StreamNegotiator are used.
Thanks to Werner Glanzer for pointing this out.- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java (version 0a6843f41f6bc2f8fc52019868179279a9b44fdc) (diffs)
-
Florian Schmaus <flo@geekplace.eu> a592a12229fa5448c3c52f9ae802220c536efd85 m
Make InBandBytestreamManager use weak references to XMPPConnection
-
Florian Schmaus <flo@geekplace.eu> 525feaa16156da1197338877e15d3a0ab54ec8ab m
Add SynchronizationPoint.getFailureException()
-
Florian Schmaus <flo@geekplace.eu> fc9748b56743a0d44e6db757cc8a9837d09ed741 m
Smack 4.2.1-SNAPSHOT