Build: #584 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> daab6039a1af48199a709873020ba81096fb4b2d
Merge tag '4.3.3'
Smack 4.3.3 -
Florian Schmaus <flo@geekplace.eu> b054c4fe77435cc9cdbdd2722e9bb923815acdc7 m
Smack 4.3.3
-
Florian Schmaus <flo@geekplace.eu> 0de0873abb3b34618bb9b771800c505609a2113f m
version.gradle: Add link to SMACK-858
-
Georg Lukas <georg@op-co.de> e5bbd19ef11e4111d8927f44be5061e765975962 m
StanzaDroppedListener for XEP-0198 resumption failures
If a stream resume fails, smack will re-send all queued stanzas after a
reconnect. However, it does not make sense to re-send them:
* IQs / IQ responses have probably timed out
* MUC messages and PMs will be rejected as you haven't rejoined yet
* regular messages should be amended with a <delay> element
This patch adds a StanzaDroppedListener interface to the
XMPPTCPConnection. If at least one StanzaDroppedListener is provided,
all queued messages will be drained into the StanzaDroppedListener(s).
Otherwise, the original behavior of attempting to transmit them will be
followed.
Discussion: https://discourse.igniterealtime.org/t/xep-0198-resume-failure-reconnect-resending-of-muc-messages/83510/3
Signed-off-by: Georg Lukas <georg@op-co.de> -
Florian Schmaus <flo@geekplace.eu> c4289b2c1819bd7b62dca9ed7743410b19665296 m
Add AbstractXMPPConnection.initState()
and init/reset the sychronization points there.
This method is called right at the beginning of connect() and at the
end of shutdown(). -
Florian Schmaus <flo@geekplace.eu> 7d2c3ac9f9ca28b172b3acb41d95ba9aa2583a63 m
Do not call synchronized methods in reader/writer thread
This may cause deadlocks with a call to acquire(2) on the introduced
readerWriterSemaphore in initConnection(), which is also synchronized. -
Florian Schmaus <flo@geekplace.eu> 7518bf9a25a8c8ac7e25fa5daff9d50ab4801bd7 m
Add descriptive text to StanzaError.toString()
-
Florian Schmaus <flo@geekplace.eu> 5da6dea138cf57a96e6bd4d9298fdb497be5b64a m
Throw exception to reduce call sites of notifyConnectionError()
in XMPPTCPConnection. -
Florian Schmaus <flo@geekplace.eu> 569f7417a8e2bc59462f0112334ae1cddab73dde m
Add AuthenticatedConnectionInitiallyEstablished timestamp
-
Florian Schmaus <flo@geekplace.eu> 3d1a781a2228d9d2fe31f6b8c96687ca3dc56eb5 m
Show correct reply timeout value in StanzaCollector's NoResponseException
-
Florian Schmaus <flo@geekplace.eu> 7f0932a481016505d58daf6cc4dbcbd5991573e0 m
Reset the MUC self-presence collector on presence stanzas on join
To prevent timeouts when joining very large MUCs we now reset the
self-presence collector's timeout for every other (occupant) presence
we receive.
Fixes SMACK-859. -
Florian Schmaus <flo@geekplace.eu> f602de8771db507f4538a60302a0f2d2bca218f6 m
Call shutdown() in connect() on exception
to clean up the state build up by connect().
Related to SMACK-855 there is the possiblitiy of a stray (writer)
thread if, for example, tlsHandled.checkifSuccessOrWaitorThrow() in
XMPPTCPConnection.connectInternal() throws. This commit should prevent
that.- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version f602de8771db507f4538a60302a0f2d2bca218f6) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version f602de8771db507f4538a60302a0f2d2bca218f6) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java (version f602de8771db507f4538a60302a0f2d2bca218f6) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version f602de8771db507f4538a60302a0f2d2bca218f6) (diffs)
-
Florian Schmaus <flo@geekplace.eu> f4ebd530e6de4cafad8fe6b12546fc1bd71b2754 m
Add note about module dependencies to JavaxResolver
Related to SMACK-856. -
Florian Schmaus <flo@geekplace.eu> 78ee22c2611ee49c989092d9686d521b719df88a m
Revert "Do not set com.sun.jndi.dns.DnsContextFactory in JavaxResolver"
This reverts commit ac9641f09187ae4a393c5f1acb1e94e66f24a64f.
Reverted because now an NoInitialContextException is now thrown.
Related to SMACK-856. -
Florian Schmaus <flo@geekplace.eu> 456d645e275d3439c3a8369dbbc9238600b84167 m
Use different version specifier for jxmpp and MiniDNS
Fixes SMACK-858. -
Florian Schmaus <flo@geekplace.eu> 5f7cfd04bdccb140383124235f7fea424dd566d6 m
Add further unit test to StableUniqueStanzaIdTest
-
Florian Schmaus <flo@geekplace.eu> 3bdc1d30b11686ca50bd537663d9ea1b77bba9a1 m
Correctly name provider INSTANCE fields
and make them 'final' where possible.- smack-experimental/src/main/java/org/jivesoftware/smackx/sid/provider/OriginIdProvider.java (version 3bdc1d30b11686ca50bd537663d9ea1b77bba9a1) (diffs)
- smack-experimental/src/main/java/org/jivesoftware/smackx/sid/provider/StanzaIdProvider.java (version 3bdc1d30b11686ca50bd537663d9ea1b77bba9a1) (diffs)
- smack-experimental/src/test/java/org/jivesoftware/smackx/sid/StableUniqueStanzaIdTest.java (version 3bdc1d30b11686ca50bd537663d9ea1b77bba9a1) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 5a2109e73fd346baa5aba2ff64e351b8a98e30d4 m
Move cast in extra line in ADD_ORIGIN_ID_INTERCEPTOR
-
Florian Schmaus <flo@geekplace.eu> 4da4558b29857a02cdc32f09befd84295186d8ef m
Make origin-id interceptor static and rename it
-
Florian Schmaus <flo@geekplace.eu> 27749b21376a34870986635df5c4619aec240e0b m
Remove unused filter in StableUniqueStanzaIdManager
-
Florian Schmaus <flo@geekplace.eu> 47f76952e3da3901b43f68c1b39a8e89726ad727 m
Smack 4.3.3-SNAPSHOT