Build: #1514 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> 382ed9d87167c2e327bca065dd53e63c17f5059d
Merge tag '4.2.0-rc2'
Smack 4.2.0-rc2 -
Florian Schmaus <flo@geekplace.eu> ce194819db065be646c54e032b68f40a09922ec7 m
Smack 4.2.0-rc2
-
Florian Schmaus <flo@geekplace.eu> 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63 m
Rename "PacketReplyTimeout" → "ReplyTimeout"
- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SASLAuthentication.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SmackConfiguration.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SmackException.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/StanzaCollector.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SynchronizationPoint.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/XMPPConnection.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/SmackConfigurationTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/ping/PingTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/pubsub/ConfigureFormTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-im/src/test/java/org/jivesoftware/smack/roster/RosterTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-im/src/test/java/org/jivesoftware/smack/roster/SubscriptionPreApprovalTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-repl/src/main/java/org/igniterealtime/smack/smackrepl/IoT.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
- smack-repl/src/main/java/org/igniterealtime/smack/smackrepl/TlsTest.java (version 7c46f58c806eb179608c3bb662b8cfbcc7a6cc63) (diffs)
-
Florian Schmaus <flo@geekplace.eu> b5415fe841ab452bf967515958aba618583792d1 m
Don't wait the reply timeout in OfflineMessageManager.getMessages(List<String>)
for the last message. We now count the number of messages we want to
retrieve, and don't wait for another message if we have already
received all.
Thanks to King Jeong Hun for reporting this. -
Florian Schmaus <flo@geekplace.eu> f31cc6e043410d9b81d969622354261751033d1e m
Fix IllegalArgumentException on DNS lookup if XMPP domain is wrong
Fixes the following exception thrown if the user had entered a non-existend XMPP domain:
java.lang.IllegalArgumentException: Must provide at least one InetAddress
at org.jivesoftware.smack.util.dns.HostAddress.<init>(HostAddress.java:55)
at org.jivesoftware.smack.util.dns.DNSResolver.lookupHostAddress(DNSResolver.java: 56)
at org.jivesoftware.smack.util.DNSUtil.resolveDomain(DNSUtil.java:209)
at org.jivesoftware.smack.util.DNSUtil.resolveXMPPServiceDomain(DNSUtil.java:136)
at org.jivesoftware.smack.AbstractXMPPConnection.populateHostAddresses(AbstractXMP PConnection.java:626)
at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectUsingConfiguration(XMPPTCPC onnection.java:556)
at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectInternal(XMPPTCPConnection. java:888)
at org.jivesoftware.smack.AbstractXMPPConnection.connect(AbstractXMPPConnection.ja va:377)
Thanks to Grigory Fedorov for reporting. -
Florian Schmaus <flo@geekplace.eu> 9d8caf0563554559f6b5bf50b3bd43c030307e34 m
Fix "XEP-0323: IoT - Sensor Data" namespace
-
Florian Schmaus <flo@geekplace.eu> d47463a5332fc06ee87f5aac4bf378f9629368f1 m
Deprecate Chat API, introduce new Chat API
Also add (From|To)TypeFilter and update/fix the documentation in a few places.- documentation/extensions/index.md (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- documentation/extensions/xhtml.md (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- documentation/gettingstarted.md (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- documentation/messaging.md (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/filter/AbstractJidTypeFilter.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/filter/FromTypeFilter.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/filter/ToTypeFilter.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smack/chat2/Chat.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smack/chat2/ChatManager.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smack/chat2/IncomingChatMessageListener.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smack/chat2/OutgoingChatMessageListener.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smack/chat2/package-info.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateListener.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/chat/Chat.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManager.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManagerListener.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/chat/ChatMessageListener.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-im/src/test/java/org/jivesoftware/smack/chat/ChatConnectionTest.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smack/ChatTest.java (version d47463a5332fc06ee87f5aac4bf378f9629368f1) (diffs)
-
Florian Schmaus <flo@geekplace.eu> b0fef6ffcbe18af78db93aa4b0d7e9fe24e90d15 m
Ensure that populateHostAddressees() doesn't return a list with 'null'
Thanks to Grigory Fedorov for reporting this. -
Florian Schmaus <flo@geekplace.eu> 51d3c3176638eb7e9e08e6facf71d589bc2ccb04 m
Initialize Socket in TCP connection when proxy is used
Thanks to Grigory Fedorov for reporting this. -
Florian Schmaus <flo@geekplace.eu> bfc14227caba62de16de59fef8a09dbbdb2ec10e m
Propagate stream errors on connect/login to the caller
Before this, if there was a stream error response by the server to our
stream open, that error response would only be handled in the reader
thread, and the user would get a message like:
"org.jivesoftware.smack.SmackException$NoResponseException: No
response received within reply timeout. Timeout was
5000ms (~5s). While waiting for SASL mechanisms stream feature from
server"
while the server may actually sent something like
<stream:stream
xmlns='jabber:client'
xmlns:stream='http://etherx.jabber.org/streams'
id='6785787028201586334'
from='jabbim.com'
version='1.0'
xml:lang='en'>
<stream:error>
<policy-violation xmlns='urn:ietf:params:xml:ns:xmpp-streams'>
</policy-violation>
<text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>
Too many (2) failed authentications from this IP
address (1xx.66.xx.xxx). The address will be unblocked at 04:24:00
06.01.2017 UTC
</text>
</stream:error>
</stream:stream>
It was necessary to change saslFeatureReceived from SmackException to
XMPPException in order to return the StreamErrorException at this sync
point. But this change in return required the introduction of a
tlsHandled sync point for SmackException (which just acts as a wrapper
for the various exception types that could occurn when establishing
TLS). The tlsHandled sync point is marked successful even if no TLS
was established in case none was required and/or if not supported by
the server.- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version bfc14227caba62de16de59fef8a09dbbdb2ec10e) (diffs)
-
Florian Schmaus <flo@geekplace.eu> cff91f5a920f31cf6ee1e1eb085a490d109c8125 m
Use correct element and namepsace in AccountManager.isSupported()
-
Florian Schmaus <flo@geekplace.eu> 7167a55f81d6f51db04ee739799813b1a280d835 m
AccountManager: Don't fallback to disco#info if not authenticated
-
Florian Schmaus <flo@geekplace.eu> 24bbe63da1ed67dccfd10d514c063ca59cdb4ec0 m
Minor code improvements in DNSutil
-
Florian Schmaus <flo@geekplace.eu> b343b499b55421e9b808c875bfdb82c0fba28009 m
MiniDNS resolver: Fix exception when there is only a A or AAAA RR
W/System.err: java.lang.IllegalStateException: Can not perform operation because the DNS resolution was unsuccessful
W/System.err: at de.measite.minidns.hla.ResolverResult.throwIseIfErrorResponse(ResolverResult.ja va:113)
W/System.err: at de.measite.minidns.hla.ResolverResult.getAnswers(ResolverResult.java:56)
W/System.err: at org.jivesoftware.smack.util.dns.minidns.MiniDnsResolver.lookupHostAddress0(Mini DnsResolver.java:130)
W/System.err: at org.jivesoftware.smack.util.dns.DNSResolver.lookupHostAddress(DNSResolver.java: 52)
W/System.err: at org.jivesoftware.smack.AbstractXMPPConnection.populateHostAddresses(AbstractXMP PConnection.java:612)
W/System.err: at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectUsingConfiguration(XMPPTCPC onnection.java:555)
W/System.err: at org.jivesoftware.smack.tcp.XMPPTCPConnection.connectInternal(XMPPTCPConnection. java:885)
W/System.err: at org.jivesoftware.smack.AbstractXMPPConnection.connect(AbstractXMPPConnection.ja va:374)
W/System.err: at com.example.bosleo.chatapp.ChatConnection.connect(ChatConnection.java:147)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService.initConnection(ChatConnectionS ervice.java:82)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService.access$100(ChatConnectionServi ce.java:20)
W/System.err: at com.example.bosleo.chatapp.ChatConnectionService$1.run(ChatConnectionService.ja va:105)
W/System.err: at java.lang.Thread.run(Thread.java:818)
W/System.err: Caused by: de.measite.minidns.hla.ResolutionUnsuccessfulException: Asking for 192.168.2.128. IN AAAA yielded an error response NX_DOMAIN
W/System.err: at de.measite.minidns.hla.ResolverResult.getResolutionUnsuccessfulException(Resolv erResult.java:89)
W/System.err: at de.measite.minidns.hla.ResolverResult.throwIseIfErrorResponse(ResolverResult.ja va:111)
W/System.err: ... 12 more -
Florian Schmaus <flo@geekplace.eu> e9bbe9a475640754783fa6def2ad4e9db66e4120 m
Fix OOB exception when setHostAddress(InetAddress) is used.
Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.charAt(String.java:658)
at org.jivesoftware.smack.util.dns.HostAddress.<init>(HostAddress.java:48)
at org.jivesoftware.smack.util.dns.HostAddress.<init>(HostAddress.java:62)- smack-core/src/main/java/org/jivesoftware/smack/util/dns/HostAddress.java (version e9bbe9a475640754783fa6def2ad4e9db66e4120) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/dns/SRVRecord.java (version e9bbe9a475640754783fa6def2ad4e9db66e4120) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version e9bbe9a475640754783fa6def2ad4e9db66e4120) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 157ff138a41e8244b3bf766606a054b8a73a73c3 m
Smack 4.2.0-rc2-SNAPSHOT