Build: #1747 failed Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> e2a196fa52222a6816dd850ee8380335a90f7850
[sinttest] Improve status output
-
Florian Schmaus <flo@geekplace.eu> 6c84356278bb55c067ae0f336cd18cc6d914faa0
[sinttest] Recycle low-level test connections
-
Florian Schmaus <flo@geekplace.eu> dd4cd8cede84d8d0bbb9ce6ee8091b8885ea273c
[sinttest] Disconnect unrecycleable connections
-
Florian Schmaus <flo@geekplace.eu> 2900cc22740d20a12699a93c207eb67a316bec2e
[sinttest] Disconnect connection in LoginIntegrationTest
So that it will cause an connectionClosedOnError() callback, caused by
an connection-timeout stream error. -
Florian Schmaus <flo@geekplace.eu> 22baa742983f1f3e7f6a941b7c26de7a1463c291
[tcp] Remove flush() in writer thread
We will flush the stream after the closing stream tag has been written
anyway. No need to do it here. -
Florian Schmaus <flo@geekplace.eu> 84b7adb7646f6437b905f756943bbd846a782862
[tcp] Remove javadoc throws annotation
This method does no longer throw. -
Florian Schmaus <flo@geekplace.eu> 7d129d6f6ce40c6f9a7b6e2c066428e929066836
[tcp] Cleanup handling of stream errors in XMPPTCPConnection
There is no need to notify waiting threads, throwing the stream error
will also notify them. Also settings tlsHandled to true is no longer
necessary. -
Florian Schmaus <flo@geekplace.eu> b7465e820002aee48ce2ba37b54ceb45bc48b199
[tcp] Do not needlessly wait for closing stream tag
-
Florian Schmaus <flo@geekplace.eu> 81f10b0c5ba421a74fd228d7c48fc685e058c457
[core] Synchronize notifyConnectionError()
Synchronize notifyConnectionError() so that only one exception is
handled and remove the ASYNC_BUT_ORDERED usage here. The
ASYNC_BUT_ORDERED was added with 7d2c3ac9f ("Do not call synchronized
methods in reader/writer thread"), but is no longer necessary, since
the Semaphores where replaced with conditions in the previous commit. -
Florian Schmaus <flo@geekplace.eu> 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce
Remove SynchronizationPoint
This continues the design started with e98d42790 ("SmackReactor/NIO,
Java8/Android19, Pretty print XML, FSM connections"), where the
exceptions that caused an operation to fail, are not recorded within
SynchronizationPoint but within the connection instance itself.- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SmackException.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SynchronizationPoint.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/XmppInputOutputFilter.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/c2s/ModularXmppClientToServerConnection.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/c2s/internal/ModularXmppClientToServerConnectionInternal.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/compression/CompressionModule.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/fsm/State.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/fsm/StateTransitionResult.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/Supplier.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smack/WaitForClosingStreamElementTest.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/ConnectionAttemptState.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppTcpTransportModule.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
- smack-tcp/src/test/java/org/jivesoftware/smack/tcp/PacketWriterTest.java (version 57961a8cc1f2df6ecc1afa8c4f8460794d8d2dce) (diffs)
-
Florian Schmaus <flo@geekplace.eu> b1a4ccfae8999b900947029ad72f819fa2918328
[core] Do not weakly reference "channel selected" callback
Since d65f2c932 ("Bump Error Prone version to 2.3.4 and fix new bug
patterns") the channel selected callback is no longer a final field of
the connection instance, hence it may be come null even if the
connection instance is still strongly referenced. Also the
ConnectionAttemptState class uses simply a lambda as callback, which
is also not strongly referenced otherwise.
The "channel selected" callback was wrapped in weak reference, so that
connection instances could get gc'ed if they are still connected but
the user lost all references to them. In this case, the weak reference
to the connection instance would become 'null' and
selectionKey.cancel() would be called.
This change means that a socket and its selection key of a "leaked"
connected connection instance continues to be part of the reactor. But
this may not be that bad: first, users are expected to manager their
connection instances, and disconnect them before they are
discarded. And secondly, at some point the connection likely will get
disconnected, and in this case, the socket and its selection key will
be removed from the reactor. -
Florian Schmaus <flo@geekplace.eu> eae8acb856075a3d43a73a42c76591e9489c0d17
[gradle] Add 'sinttestAll' task
-
Florian Schmaus <flo@geekplace.eu> 10c6e5d121bec0e0cabef5c12e0585019228529f
[openpgp] Use default constructor of DummyConnection in unit tests