Build: #1914 was successful Rebuilt by Guus der Kinderen
Code commits
Smack (master)
-
Florian Schmaus 5cbcd676457ca9429f3788ab7e77681171fbc50d
[sinttest] Add MultiUserChatIntegrationTest.mucTestChangeRoomName
-
Florian Schmaus b2331aaacfe522d18a9096df3eb4fb0df30e37d1
[sinttest] Throw IllegalArgumentException if no tests have been selected
-
Florian Schmaus 3e2d01ce637ea86bd12bcba9d64c7841e7b3ebf1
Merge pull request #594 from guusdk/sinttest_specref-normalization-access
[sinttest] Configuration.normalizeSpecification() should be public -
Florian Schmaus 0db1c7a988b678cd3806186373d1db3d4e930af2
Merge pull request #593 from guusdk/sinttest_specref-normalization-dash
[sinttest] Normalization of SpecificationReference to include dash-seperator -
Florian Schmaus 6ae8234d255bcf6e19a5faf50d70a2892f35b0b4
[sinttest] Add MultiUserChatIntegrationTest.mucTestVisitorNotAllowedToChangeSubject
-
Florian Schmaus a7083872101454f6dde10d6d69e546be3115ad9b
[muc] Add roomconfig_changesubject support to MucConfigFormManager
-
Florian Schmaus 147071ff643971b4d873ddbdb16e347e4e353652
[muc] Fix changeSubject() to throw XMPPErrorException on failures
When Smack requests a subject change of a MUC, an error returned by
the server (eg: 'forbidden') should be propagated (as suggested by the
pre-existing javadoc).
Reported-by: Guus der Kinderen <guus@goodbytes.nl> -
Florian Schmaus 7acde2acabd622d6b5801e4c6693acdd9a68ab4a
[sinttest] Drop testReceivePresenceAndApprovalAndRosterPush
This tests reliably fails, not only for me. I suspect that it is
related to the order of events checked by this tests, that can not be
reliably tested, even with sync listeners.
It is also is primarily a test for server behavior. -
Florian Schmaus 4ce926bd63ca6e94998fce27264dc47463f4473f
[core] Use StanzaView as StanzaIdFilter constructor parameter type
Instead of Stanza, use StanzaView as constructor parameter type of
StanzaIdFilter. Even though StanzaView also includes builders, the
Stanza ID is even immutable in builders. -
Florian Schmaus 1f34f3e613d3390962afbaf11903cd41986dbeaf
[sinttest] Directly use rosterTwo instead of Roster.getInstanceFor()
-
Guus der Kinderen 121d4ac2459dd6244d36a90794a2779ba7a57aad m
[sinttest] Normalization of SpecificationReference to include dash-seperator
When comparing SINT-configuration to annotations, a bit of normalization occurs, to ensure that common variations in denoting a specification are detected to be equal to each-other.
The dash (`-`) character is commonly used when referencing a specification (eg: `XEP-0001`).
This commit ensures that usage of a dash (`-`) character is included in the normalization process, making `XEP 0001`, `XEP0001` and `XEP-0001` all to be identified as the same reference. -
Guus der Kinderen 4cc9a7d7ebdcdf48ccf19deef82256dd39cbcbb5 m
[sinttest] Configuration.normalizeSpecification() should be public
It is likely to be desirable to re-use the normalization of specification references, for example in implementations of `TestRunResultProcessor`.