Build #1,917

Plan branch:
Nightly Distribution of the master branch

Build: #1917 failed Changes by Florian Schmaus

Stages & jobs

  1. Default Stage

  2. Deploy

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
11 minutes
Labels
None
Revision
cf8a8466e444041f7169bd6b86ed492390b2f056
Total tests
890
Failing since
#1916 (Changes by Guus der Kinderen and Florian Schmaus – )
Fixed in
#1920 (Manual run by daryl herzmann)
No failed test found. A possible compilation error occurred.

Tests

Responsible

  • Guus der Kinderen Guus der Kinderen Automatically assigned

Code commits

Author Commit Message Commit date
Florian Schmaus Florian Schmaus cf8a8466e444041f7169bd6b86ed492390b2f056 Merge remote-tracking branch 'origin/master'
Guus der Kinderen Guus der Kinderen 98dbc0ee2eb1e15ae83c7ed9025a9b3075670bb1 m [muc] Prevent duplicate processing of mediated invitations
MUC mediated invitations usually have the form

<message
    from='coven@chat.shakespeare.lit'
    id='nzd143v8'
    to='hecate@shakespeare.lit'>
  <x xmlns='http://jabber.org/protocol/muc#user&#39;>
    <invite from='crone1@shakespeare.lit/desktop'>
      <reason>
        Hey Hecate, this is the place for all good witches!
      </reason>
    </invite>
    <password>cauldronburn</password>
  </x>
</message>
(source: XEP-0045 Example 57.)

However, previous versions of XEP-0045 specified an additional <x
xmlns='jabber:x:conference'> element to be included (see
implementation note in XEP-0045). Therefore, a legacy implementation
may emit a mediated invitations in the form of

<message
    from="smack-inttest-mediated-invite-from-8ta77-hw9igz@conference.example.org"
        to="smack-inttest-two-8ta77@example.org">
  <x xmlns="http://jabber.org/protocol/muc#user">
    <invite from="smack-inttest-one-8ta77@example.org"/>
  </x>
  <x xmlns="jabber:x:conference" jid="smack-inttest-mediated-invite-from-8ta77-hw9igz@conference.example.org"/>
</message>

Unfortunately, this matches
MultiUserChatManager.DIRECT_INVITATION_FILTER because
GroupChatInvitation matches <x xmlns="jabber:x:conference"/>. However
the message is not a direct invitation but a mediated one. Besides
this invoking the wrong listeners (direct vs. medidated) the value for
'inviter' that's used to invoke that listener will be false.

To fix this, extend DIRECT_INVITATION_FILTER with
NotFilter.of(MUCUser.class) to avoid matching those legacy mediated
invitations.

Fixes SMACK-943

Co-authored-by: Florian Schmaus <flo@geekplace.eu>
Florian Schmaus Florian Schmaus 0bb3bf292c051181fae272e1a0b5b97f3dc5dbaa m [core] Add NotFilter.of(Class<E extends ExtensionElement>)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeSMACK-943Could not obtain issue details from Jira
Unknown Issue TypeXEP-0045Could not obtain issue details from Jira

Shared artifacts

Artifact File size
Project binary files 23 MB

Error summary for Default Job

The job generated some errors, drill down into the full build log for more details.

OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
Found 0 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':smack-android:publishMavenJavaPublicationToCustomRepoRepository'.
> Failed to publish publication 'mavenJava' to repository 'customRepo'
   > Could not PUT 'https://oss.sonatype.org/content/repositories/snapshots/org/igniterealtime/smack/smack-android/4.5.0-alpha4-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Content access is protected by token

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s