Build: #1921 was successful Manual run by Guus der Kinderen
Code commits
Smack (master)
-
Florian Schmaus d27fef0baefe03f3543f51ccf748902260814a29
[sinttest] Do not leak stanza listener in MultiUserChatOccupantIntegrationTest
-
Florian Schmaus c322ce804693f7973649d9ba1cb2aa399a3975ba
Merge pull request #601 from guusdk/sint_muc-guarantee-order
[sint] Refactor test to ensure stanza order -
Guus der Kinderen 0c9d521084fe63ea4bd38d53efeb9a43ac128c82 m
[sint] Refactor test to ensure stanza order
The test that's modified in this commit asserts that upon MUC join, stanzas are received in a particular order.
The previous implementation depended on several event listeners (one for presence, one for messages) that did not always fire in the same order in which the corresponding stanzas arrived. This made the approach unsuitable to reliably test the order in which stanzas arrive.
This commit stops using Smack's MUC API when trying to collect the order in which stanzas arrive. Instead, it joins a chatroom and listens for its stanzas using basic stanza handling. As this uses exactly one stanza listener, that's guaranteed to be invoked in order of stanza arrival, any synchronicity issue in the previous implementation no longer applies. -
Florian Schmaus 47d4cbe0943bd0355b6d1d6c840d830536b60af9
Merge branch '4.4'
-
Florian Schmaus ba02a868f60d7b58224e190baf7654ef87251df3 m
[caps] Use DataForm.getFormType() when sorting
-
Guus der Kinderen a1e85d644f188325251dc42d6b40247b64815d53 m
[caps] Additional test that asserts CAPS dataform ordering
XEP-0115 defines that any dataforms in the disco#info stanza is
ordered prior to the computation of the verification string. This
commit adds a test that verifies that this is done by Smack.
See SMACK-944. -
Guus der Kinderen 95adfb3cdf8d2d85f10d91dd0399e7f13072130e m
[caps] Ensure dataforms are ordered prior to ver calculation
Fixes SMACK-944. -
Florian Schmaus 9254f735c79a047626c6579cd9b5ede82be202d2
[sinttest] Refactor MultiResulitSyncPoint TimeoutException message construction for readability
- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/util/MultiResultSyncPoint.java (version 9254f735c79a047626c6579cd9b5ede82be202d2) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatOccupantIntegrationTest.java (version 9254f735c79a047626c6579cd9b5ede82be202d2) (diffs)
-
Florian Schmaus 68fa90435e8b2aee5f6151184ce9c036884bc570
Merge pull request #599 from guusdk/sint_assertresult-multisync
[sinttest] Improving assertions for MultiResultSyncPoint -
Florian Schmaus 98ff4d8a6508bae34da980ce1299dd2f3fcbdd4f
Merge pull request #598 from guusdk/sint_muc-occupant-race
[sinttest] Fix race condition in MUC test -
Guus der Kinderen 7e9a5713e96812dc64ba2555fdf79646bb15f707 m
[sinttest] Improve test assertion message
Making use of the new assertion handling for MultiResultSyncPoint, the integration test that uses that implementation can now get improved assertion messages. This will allow users to more quickly determine why a test is failing. -
Guus der Kinderen 440b49763829237fbb966fd723cd71fcf81730ce m
[sinttest] Add AssertResult for MultiResultSyncPoint
This adds an AssertResult implementation for MultiResultSyncPoint that mimics the equivalent for ResultSyncPoint.- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/AbstractSmackIntTest.java (version 440b49763829237fbb966fd723cd71fcf81730ce) (diffs)
- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/util/MultiResultSyncPoint.java (version 440b49763829237fbb966fd723cd71fcf81730ce) (diffs)
-
Guus der Kinderen adafcdb6d1dc6806ec487b7d74ccdc7df15066b4 m
[sinttest] Fix race condition in MUC test
When occupant One waits for occupant Two to join the room, One should register the corresponding listener _before_ Two joins.
Without this, a race conditions occurs, where Two could have joined the room before One registered the listener, thus missing the event.