Skip to navigation
Skip to content

Stages & jobs

Build Stage
- Build
Deploy
- Copy to website

Code commits

Smack (master)

Florian Schmaus 25 Sep 2024 220faa9d3d02210728066b320b4dd05ad48cdd69

Merge pull request #637 from Flowdalic/drop-gradle-plugin
[build] Drop unused freefair maven-plugin
Florian Schmaus 25 Sep 2024 1fffb90783edd0f1539c8644665921f7fe6a65c2

[build] Drop unused freefair maven-plugin
- build-logic/build.gradle (version 1fffb90783edd0f1539c8644665921f7fe6a65c2) (diffs)
Florian Schmaus 25 Sep 2024 c5e9e4832d458725e33f63be35d43740075f1a94

Merge pull request #635 from akrherz/aqute_version
[build] Downgrade bnd gradle plugin to 6.4.0
daryl herzmann 25 Sep 2024 6857ac6b877644656797529de34851eff903d7e9

[ci] Add java 11 to build matrix
- .github/workflows/ci.yml (version 6857ac6b877644656797529de34851eff903d7e9) (diffs)
Florian Schmaus 25 Sep 2024 c4d16a6d6c3f1c6ae5d98e77f60c0427342088de

Merge pull request #636 from Flowdalic/bump-error-prone
[build] Bump error prone from 2.9.0 to 2.32.0
Florian Schmaus 25 Sep 2024 beacb5eb8e958a5a8c855ed13fa2480eaa9425f2

[build] Bump error prone from 2.9.0 to 2.32.0
daryl herzmann 25 Sep 2024 d217c32e7241422006f995100d9ccec209ee21d7

[build] Downgrade bnd gradle plugin to 6.4.0
7.0.0 requires Java 17
- build-logic/build.gradle (version d217c32e7241422006f995100d9ccec209ee21d7) (diffs)
Florian Schmaus 25 Sep 2024 55400633c83bf69be7628f6871f7b9e9432389db

Merge pull request #634 from Flowdalic/rename-java8-to-java11
Rename smack-java8(-full) to smack-java11(-full)
Florian Schmaus 25 Sep 2024 07d9d694da484821637eb63182e95f4bff2d7450

Rename smack-java8(-full) to smack-java11(-full)
To denote that Smack now requires at least Java 11 to run. Fixes
SMACK-953.
Florian Schmaus 25 Sep 2024 5d2ca5d7d32ff48504e84e2ed789af64a629bb34

Merge pull request #633 from Flowdalic/ci-java-21
[github ci] Build also with Java 21
Florian Schmaus 25 Sep 2024 2eddf1949a25dbf46b27f04852325eeee7b34650

[github ci] Build also with Java 21
Florian Schmaus 25 Sep 2024 348a3ab0918db3ca7afae67da34e51def0600666

Merge pull request #630 from guusdk/sint_formtest-smack-4.5.0-beta2
[sint] Fix compatibility with Smack 4.5.0-beta2
Florian Schmaus 25 Sep 2024 f59d7f3257ca1555b4e68f20f8ae60e8355428df

Merge pull request #632 from Flowdalic/smack-gradle-bump
Bump to Gradle 8.10.2, require Java 11
Florian Schmaus 25 Sep 2024 1e5d34eacf9a84f6dc2b5e918274d587bd35c030

Bump to Gradle 8.10.2, require Java 11
Bump Gradle from 6.8.3 to 8.10.2 and increase the minimum required
Java version from 8 to 11 (SMACK-953).

The switch from Java 8 to 11 caused some Bytecode portability issues
regarding NIO Buffers. Java changed with version 9 the return type of
some subclasses of Buffer to return the specific Buffer type instead
of the Buffer superclass [JDK-4774077]. For example, ByteBuffer.filp()
previously returned Buffer, while it does return ByteBuffer now.

This sensible change was not reflected by the Android API [1], which
means that AnimalSniffer rightfully started to complain that there is
no method "ByteBuffer ByteBuffer.flip()" in Android, there is only
"Buffer ByteBuffer.flip()", and those are incompatible methods on
Java's Bytecode layer.

As workaround, this changes

    return charBuffer.flip().toString();

to

    ((java.nio.Buffer) charBuffer).flip();
    return charBuffer.toString();

to restore the Bytecode portability between Android and Java.

Errorprone also got new checks, of which JavaUtilDate and JdkObsolete
are wroth mentioning.

JavaUtilData basically strongly recommends to use Java's newer time
API over java.util.Date. But since Smack was Java 8 until now,
j.u.Date is widely used.

Similar JdkObsolete mentions obsolete JDK APIs, like data structures
like Vector and Stack. But mostly LinkedList, which should usually be
replaced by ArrayList. And this is what this commit largely does.

JDK-4774077: JDK-4774077">https://bugs.openjdk.org/browse/JDK-4774077
1: https://issuetracker.google.com/issues/369219141
Guus der Kinderen 19 Sep 2024 e4fcdb68795fe3d311a78cc44824b9e92c0c64ad

[sint] Fix compatibility with Smack 4.5.0-beta2
Due to a change in Smack 4.5.0-beta2, test execution of (all) SINT tests is aborted when `FormTest` is executed.

It appears that Smack now has more strict argument validation when setting thread IDs on message stanzas. This validation should not fail for the tests that are shipped with Smack.

This is the stack trace when executing the failing test (which no longer occurs after the change in this commit is applied):

```
Exception in thread "main" java.lang.IllegalArgumentException: thread must not be null nor empty
        at org.jivesoftware.smack.util.StringUtils.requireNotNullNorEmpty(StringUtils.java:533)
        at org.jivesoftware.smack.packet.Message$Thread.<init>(Message.java:326)
        at org.jivesoftware.smack.packet.MessageBuilder.setThread(MessageBuilder.java:70)
        at org.jivesoftware.smack.packet.MessageBuilder.setThread(MessageBuilder.java:66)
        at org.jivesoftware.smackx.xdata.FormTest.testFilloutForm(FormTest.java:133)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.lambda$runTests$0(SmackIntegrationTestFramework.java:476)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runConcreteTest(SmackIntegrationTestFramework.java:556)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework$PreparedTest.run(SmackIntegrationTestFramework.java:764)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runTests(SmackIntegrationTestFramework.java:544)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.run(SmackIntegrationTestFramework.java:277)
        at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.main(SmackIntegrationTestFramework.java:115)
```
- smack-integration-test/src/main/java/org/jivesoftware/smackx/xdata/FormTest.java (version e4fcdb68795fe3d311a78cc44824b9e92c0c64ad) (diffs)