Build: #1909 was successful
Job: Default Job was successful
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> 1bba38decd668d663871be0c2d68aa6da7a455d6
Merge pull request #519 from guusdk/SINT_roster-presence-based
[sinttest] Add roster tests that are driven by presence stanzas -
Florian Schmaus <flo@geekplace.eu> 36d6ff29950c04e4322c4ce0a3707acd5e54fd33
Merge pull request #482 from Fishbowler/xep-0045-coverage-part4
[sinttest] Additional tests covering s7 of XEP-0045 -
Dan Caseley <dan@caseley.me.uk> 855f01e6b2d8e35ee6ac440f204e9d91e80c645c m
[sinttest] Additional tests for s7 of XEP-0045
- smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MucConfigFormManager.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/util/MultiResultSyncPoint.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/AbstractMultiUserChatIntegrationTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatEntityIntegrationTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatIntegrationTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatOccupantIntegrationTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/test/java/org/igniterealtime/smack/inttest/util/MultiResultSyncPointTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
- smack-integration-test/src/test/java/org/igniterealtime/smack/inttest/util/ResultSyncPointTest.java (version 855f01e6b2d8e35ee6ac440f204e9d91e80c645c) (diffs)
-
Guus der Kinderen ad756810c1b2e49990534d30af9b3cb8e11de60b m
SINT: Removing invalid test
The implementation of the test that is being removed depends on a server
characteristic that will cause a loop of presence stanzas (which obviously is
bad). A RFC3921-compliant client can send an 'acknowledgement' after receiving
a presence 'subscribed' stanza, in the form of a presence 'subscribe' stanza.
See section 8.2 of RFC3921.
When a server implementation does not ignore this acknowledgement, the domain
of the recipient MUST (RFC6121 section 3.1.3) respond with a 'subscribed' on
behalf of the recipient (which is what the now removed test was verifying).
This can trigger the RFC3921-compliant sender to again receive 'subscribed',
that it again can acknowledge, which causes a loop.
To test RFC6121, the subscription state of the recipient must somehow be
modified to reflect a different state than that of the initiator. I'm not sure
if that is feasible with the SINT framework. -
Guus der Kinderen 26ec0d412d335d2c127f2928bc4f57a266cdc4c5 m
SINT: Add roster tests that are driven by presence stanzas
RFC-6121 defines server-sided behavior of the interaction between presence stanzas and rosters.
This commit adds tests for that behavior.